From patchwork Sat May 13 15:32:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Butterfield X-Patchwork-Id: 9725379 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5D45F60146 for ; Sat, 13 May 2017 15:33:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45812288E0 for ; Sat, 13 May 2017 15:33:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 39F7D288E4; Sat, 13 May 2017 15:33:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE866288E1 for ; Sat, 13 May 2017 15:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751564AbdEMPdC (ORCPT ); Sat, 13 May 2017 11:33:02 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:32791 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750935AbdEMPdB (ORCPT ); Sat, 13 May 2017 11:33:01 -0400 Received: by mail-it0-f65.google.com with SMTP id l145so7613419ita.0 for ; Sat, 13 May 2017 08:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=3utSEcaI6ETfCyIR2dqck6BRgEjN7IqM+4SQys+rXy4=; b=FtEu8JbTI2ed70NN4U/GSctk2UJiwto/W9ego/LnSVtogQWInwUVPI9g1lpqQ/ch2S 8rcGsnlYOt8YwTOrxvqjEXUC+7oVhpmHcRjultiZv4hqGucuvEPvUNX4m6EodTS4qlgn KoXvGed9UAUpJaDiTyNop1zcjigL8hz0H5iS9N1fKQ+OGmCCseJFvTelizXS+gZF3Kz8 is0VhFIvALWn30yduVaue00IBYpXL5IxKvH+gHaaHTko6TVFDuuENl3O/qWgEBgOD1PZ AaryF3a7PRNnu9l7Aj1RFa6pWDmeAzvK2CGfwLILfoasCK1r3V1vM4qh0HR9K/ogeuxj 3QTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3utSEcaI6ETfCyIR2dqck6BRgEjN7IqM+4SQys+rXy4=; b=DmSBYS4gqgYQDZDWrOoVNKDO1mSxdZfehx20LhaogVx8WLothfbLX2hzuPd1uHseXs cgW/D2+vRuxTtb2Hl1z2XVnIPAMOFmaX/qnbsS+Zdk/Q4fJJULug9dcyFXvDLeQg4fE1 SBa191PkM3dLLN3m45lBOB00INWH7gIQQhd9uPUZQATW79yKV5mmcjfWeq97D12IDZhV Dr+ZmKfcokossCGtYXtbTz4R3iL/ek1nGxq44JbQaJpFoEC4uoUgmo34CH24lDhXqh2I lpMEXNsFl/d1UtYleAuThG0QhWONv/w7pEyWigiwSD96SolUZcS/QgP+Xkr3JtJFb0lI wINg== X-Gm-Message-State: AODbwcA06Sf2mrXY0f+kjJpvyyNMi0gdP1ZhyEpk4TNYty5lrOFg5ihj dYJvGFyvD3oKbw== X-Received: by 10.36.58.9 with SMTP id m9mr2001756itm.2.1494689580708; Sat, 13 May 2017 08:33:00 -0700 (PDT) Received: from localhost.localdomain (c-73-181-28-74.hsd1.co.comcast.net. [73.181.28.74]) by smtp.gmail.com with ESMTPSA id m89sm2760732ioi.32.2017.05.13.08.32.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 13 May 2017 08:33:00 -0700 (PDT) From: David Butterfield To: target-devel@vger.kernel.org Cc: David Butterfield Subject: [PATCH] fix qcow.c compiler warnings Date: Sat, 13 May 2017 09:32:44 -0600 Message-Id: <20170513153244.26918-1-dab21774@gmail.com> X-Mailer: git-send-email 2.12.2.575.gb14f27f Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Change bdev->blocksize to signed, used in comparison <= 0 in qcow_open(). Change iovec_segment() and iovec_memset() to be static functions. define _GNU_SOURCE 1 to match -D_GNU_SOURCE --- qcow.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qcow.c b/qcow.c index 9f108ae..d6b2bd2 100644 --- a/qcow.c +++ b/qcow.c @@ -44,7 +44,7 @@ * THE SOFTWARE. */ -#define _GNU_SOURCE +#define _GNU_SOURCE 1 #include #include #include @@ -89,7 +89,7 @@ struct bdev { /* from TCMU configfs configuration */ int64_t size; uint64_t num_lbas; - uint32_t block_size; + int32_t block_size; int fd; /* image file descriptor */ }; @@ -1167,7 +1167,7 @@ out: } /* returns number of iovs initialized in seg */ -size_t iovec_segment(struct iovec *iov, struct iovec *seg, size_t off, size_t len) +static size_t iovec_segment(struct iovec *iov, struct iovec *seg, size_t off, size_t len) { struct iovec *seg_start = seg; @@ -1195,7 +1195,7 @@ size_t iovec_segment(struct iovec *iov, struct iovec *seg, size_t off, size_t le return seg - seg_start; } -void iovec_memset(struct iovec *iov, int iovcnt, int c, size_t len) +static void iovec_memset(struct iovec *iov, int iovcnt, int c, size_t len) { while (len && iovcnt) { size_t n = min(iov->iov_len, len);