From patchwork Tue Oct 31 18:03:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10035063 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A9B0260327 for ; Tue, 31 Oct 2017 18:03:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A19842851D for ; Tue, 31 Oct 2017 18:03:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 961332884E; Tue, 31 Oct 2017 18:03:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ECED52851D for ; Tue, 31 Oct 2017 18:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932638AbdJaSDZ (ORCPT ); Tue, 31 Oct 2017 14:03:25 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:25243 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932626AbdJaSDY (ORCPT ); Tue, 31 Oct 2017 14:03:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1509473004; x=1541009004; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=gGmYZaTgmWazraNKrfTWGWt5ad9QNrcDtA8cL3Bob9A=; b=NBkOxBMGxReflcOt/RdsTUOum6zlPWEdwUK6tAyX/e0PFUDcNVEcQovu ARnswoLroS/AG/i+v0ilIAOESoI58QI6ybQki0rGvXm7VOykjPKBrfmNM SeXSZsi/erGsWS40rW9CLvA5edekAPmSdF1DISIwAhFVv4lWT67GBJSRM v/FAuXN4j+BR+GDkzMp5dI1oVSIt0w0R2JZgn7togqgttJfWcVDipfa/n u4hYr5LM4IQnMp015haja1DCwnQ2FamlpspOonQ08+YwDZ+o41snGd928 unfF16DB57yEizDc5HE3rN5cDpOq0cZd9l1oAMr5DxDo2xM0ZitOdULhb A==; X-IronPort-AV: E=Sophos;i="5.44,325,1505750400"; d="scan'208";a="60328610" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 01 Nov 2017 02:03:22 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP; 31 Oct 2017 11:01:07 -0700 Received: from unknown (HELO MILHUBIP04.sdcorp.global.sandisk.com) ([10.177.9.97]) by uls-op-cesaip02.wdc.com with ESMTP; 31 Oct 2017 11:03:23 -0700 Received: from milsmgip12.sandisk.com (10.177.8.100) by MILHUBIP04.sdcorp.global.sandisk.com (10.177.9.97) with Microsoft SMTP Server id 14.3.319.2; Tue, 31 Oct 2017 11:03:22 -0700 X-AuditID: 0ab1095a-d99e3980000146e4-4b-59f8baea0452 Received: from thinkpad-bart.int.fusionio.com ( [10.177.8.100]) by (Symantec Messaging Gateway) with SMTP id F7.A9.18148.AEAB8F95; Tue, 31 Oct 2017 11:03:22 -0700 (PDT) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" CC: Nicholas Bellinger , Christoph Hellwig , , Bart Van Assche , Hannes Reinecke , Mike Christie Subject: [PATCH 01/11] target: Move a declaration of a global variable into a header file Date: Tue, 31 Oct 2017 11:03:09 -0700 Message-ID: <20171031180319.19258-2-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171031180319.19258-1-bart.vanassche@wdc.com> References: <20171031180319.19258-1-bart.vanassche@wdc.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCJMWRmVeSWpSXmKPExsXCtZEjRffVrh+RBn8/81hc+vOF0WLBm71s FitXH2WyWDUxz2L58X9MFuuPbGC0aFt9htGidelbJgcOj/vbjzB5PDi0mcVj980GNo+PT2+x eLzfd5XNY/2WqywenzfJebQf6GYK4IjisklJzcksSy3St0vgyuhY/oCt4Chvxcd9+1kaGJ9w dzFyckgImEgcaJzC3MXIxSEksJpRYuf9d+wgCTYBPYlT8/YxgdgiArkSpx7eYAIpYhZ4wijR 8nMfWJGwQKREy85pbCA2i4CqRMemBrAGXgFria9Nj5ggNshLvF9wnxHE5hSwkXjbs5sFxBYC qrm2dwnzBEbuBYwMqxjFcjNzinPTMwsMjfSKE/NSMouz9ZLzczcxgsOJM2oH4/WJ5ocYmTg4 pRoYg59f9jE8p55ym29zjoCH8d1Qm+71Ae9t596L993styDbTymC5YxESVXaOR/vfj4Ljpov 5y9wiSlfP+mRZMPu5e5S/qDQh2m/4s3dL8SkHsetbZp7erHL+++/D6dM3HPEYZvqR83D72a9 eztdu0PJ0a5UKUvtoVu+65r3R+8qPdH7PDVWSYhPiaU4I9FQi7moOBEAG5LT8dcBAAA= MIME-Version: 1.0 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch avoids that sparse reports the following warning: drivers/target/target_core_configfs.c:2267:33: warning: symbol 'target_core_dev_item_ops' was not declared. Should it be static? Fixes: c17cd24959cd ("target/configfs: Kill se_device->dev_link_magic") Signed-off-by: Bart Van Assche Cc: Nicholas Bellinger Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Mike Christie Reviewed-by: Hannes Reinecke --- drivers/target/target_core_fabric_configfs.c | 2 -- drivers/target/target_core_internal.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/target/target_core_fabric_configfs.c b/drivers/target/target_core_fabric_configfs.c index e9e917cc6441..e1416b007aa4 100644 --- a/drivers/target/target_core_fabric_configfs.c +++ b/drivers/target/target_core_fabric_configfs.c @@ -623,8 +623,6 @@ static struct configfs_attribute *target_fabric_port_attrs[] = { NULL, }; -extern struct configfs_item_operations target_core_dev_item_ops; - static int target_fabric_port_link( struct config_item *lun_ci, struct config_item *se_dev_ci) diff --git a/drivers/target/target_core_internal.h b/drivers/target/target_core_internal.h index f30e8ac13386..2c5004ffb581 100644 --- a/drivers/target/target_core_internal.h +++ b/drivers/target/target_core_internal.h @@ -88,6 +88,7 @@ int target_for_each_device(int (*fn)(struct se_device *dev, void *data), void *data); /* target_core_configfs.c */ +extern struct configfs_item_operations target_core_dev_item_ops; void target_setup_backend_cits(struct target_backend *); /* target_core_fabric_configfs.c */