From patchwork Tue Jan 16 15:34:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis de Bethencourt X-Patchwork-Id: 10167463 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0CF466055D for ; Tue, 16 Jan 2018 15:35:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2CDE2808F for ; Tue, 16 Jan 2018 15:35:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E690828469; Tue, 16 Jan 2018 15:35:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8E1B128469 for ; Tue, 16 Jan 2018 15:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751611AbeAPPfI (ORCPT ); Tue, 16 Jan 2018 10:35:08 -0500 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:19139 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606AbeAPPfH (ORCPT ); Tue, 16 Jan 2018 10:35:07 -0500 X-IronPort-AV: E=Sophos;i="5.46,368,1511827200"; d="scan'208";a="715792276" Received: from sea3-co-svc-lb6-vlan2.sea.amazon.com (HELO email-inbound-relay-2c-168cbb73.us-west-2.amazon.com) ([10.47.22.34]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 16 Jan 2018 15:34:41 +0000 Received: from uecb1d7364e75593fe229.ant.amazon.com (pdx2-ws-svc-lb17-vlan3.amazon.com [10.247.140.70]) by email-inbound-relay-2c-168cbb73.us-west-2.amazon.com (8.14.7/8.14.7) with ESMTP id w0GFYbTJ071534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 16 Jan 2018 15:34:38 GMT Received: from uecb1d7364e75593fe229.ant.amazon.com (localhost [127.0.0.1]) by uecb1d7364e75593fe229.ant.amazon.com (8.15.2/8.15.2/Debian-3) with ESMTP id w0GFYaDD018002; Tue, 16 Jan 2018 15:34:36 GMT Received: (from luisbg@localhost) by uecb1d7364e75593fe229.ant.amazon.com (8.15.2/8.15.2/Submit) id w0GFYaAh017995; Tue, 16 Jan 2018 15:34:36 GMT From: Luis de Bethencourt To: linux-kernel@vger.kernel.org Cc: Joe Perches , "Nicholas A . Bellinger" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, Luis de Bethencourt Subject: [PATCH] tcmu: Fix trailing semicolon Date: Tue, 16 Jan 2018 15:34:32 +0000 Message-Id: <20180116153432.17927-1-luisbg@kernel.org> X-Mailer: git-send-email 2.15.1 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The trailing semicolon is an empty statement that does no operation. It is completely stripped out by the compiler. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt Acked-by: Mike Christie --- Hi, After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0]. Best regards Luis [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html drivers/target/target_core_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 60c8a87b7a88..f6164d294fb3 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -1564,7 +1564,7 @@ static int tcmu_wait_genl_cmd_reply(struct tcmu_dev *udev) wake_up_all(&udev->nl_cmd_wq); - return ret;; + return ret; } static int tcmu_netlink_event(struct tcmu_dev *udev, enum tcmu_genl_cmd cmd,