From patchwork Fri Jun 15 18:23:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhu Lingshan X-Patchwork-Id: 10467309 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C6633601C2 for ; Fri, 15 Jun 2018 18:25:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B6AB728E3B for ; Fri, 15 Jun 2018 18:25:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AB4B128E40; Fri, 15 Jun 2018 18:25:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 64AD928E3B for ; Fri, 15 Jun 2018 18:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756515AbeFOSZS (ORCPT ); Fri, 15 Jun 2018 14:25:18 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:41915 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756517AbeFOSZP (ORCPT ); Fri, 15 Jun 2018 14:25:15 -0400 Received: from vstart.localdomain (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Fri, 15 Jun 2018 12:25:10 -0600 From: Zhu Lingshan To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, nab@linux-iscsi.org, mchristi@redhat.com, martin.petersen@oracle.com Cc: hare@suse.de, lduncan@suse.com, ddiss@suse.de, lszhu@suse.de, Zhu Lingshan Subject: [PATCH 23/33] TCMU PR: func to handle PR read keys but no regs Date: Sat, 16 Jun 2018 02:23:32 +0800 Message-Id: <20180615182342.6239-23-lszhu@suse.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180615182342.6239-1-lszhu@suse.com> References: <20180615182342.6239-1-lszhu@suse.com> Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When try to execute Persistent Reservation Read Keys, but tcmu_pr_info_get() returns -ENODATA, this means there are no registrations, so we should generate a fake empty struct tcmu_pr_info, so that the code can keep running, but we don't want to store it in the TCMU device, this is different from tcmu_pr_info_init(). Signed-off-by: Zhu Lingshan --- drivers/target/target_core_user.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index c3adff826163..2fcdfc97ca75 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -2829,6 +2829,23 @@ tcmu_execute_pr_register(struct se_cmd *cmd, u64 old_key, return ret; } +static int tcmu_pr_info_mock_empty(struct tcmu_pr_info **_pr_info) +{ + struct tcmu_pr_info *pr_info; + + pr_info = kzalloc(sizeof(*pr_info), GFP_KERNEL); + if (!pr_info) + return -ENOMEM; + + pr_info->vers = TCMU_PR_INFO_XATTR_VERS; + INIT_LIST_HEAD(&pr_info->regs); + + *_pr_info = pr_info; + pr_debug("successfully initialized mock PR info\n"); + + return 0; +} + static int tcmu_configure_device(struct se_device *dev) { struct tcmu_dev *udev = TCMU_DEV(dev);