From patchwork Fri Jan 25 18:34:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10781895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CCF7214E5 for ; Fri, 25 Jan 2019 18:35:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BC812299B5 for ; Fri, 25 Jan 2019 18:35:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B0F792D40C; Fri, 25 Jan 2019 18:35:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 52786299B5 for ; Fri, 25 Jan 2019 18:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729210AbfAYSfv (ORCPT ); Fri, 25 Jan 2019 13:35:51 -0500 Received: from out002.mailprotect.be ([83.217.72.86]:50835 "EHLO out002.mailprotect.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726361AbfAYSfu (ORCPT ); Fri, 25 Jan 2019 13:35:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=Content-Transfer-Encoding:MIME-Version:References :In-Reply-To:Message-Id:Date:Subject:Cc:To:From:reply-to:sender:bcc: content-type; bh=krW+SZ+xafnEpilu58vDieUcGbHZjOVN2eQEnx0THe4=; b=I7XtgMRpQkJm RDkq/GHrzCUjdUMnTmio2eFoPLlTXv5Kk/ip72Nz6FhlOwgCez2/uQAMRq2yEw/K8MXxUB379OzR3 Br6WWSeO3OMYDgWaFn35hIdk6JGqpO1Byb43OOxqQkxnJyNiGSdT5LjVnCd9O0kgbNZEjI+7jpgyl HL1I1D51QS3eQ1l4dKKg80mSsZaBK9do9aVrgazwI8zMtG1UoFkBvnDAwDEQ8TFQxmuOR5uRbnuqq Lks0sYFTTF7SIUZEOGF+l9fzltJaEcLleVIS2mseL6ik176AwkB3SeY127DfZiaUZ2QlKW3uq3DTy XzO4HoQVT0P8+vxaVbw7bA==; Received: from smtp-auth.mailprotect.be ([178.208.39.155]) by com-mpt-out002.mailprotect.be with esmtp (Exim 4.89) (envelope-from ) id 1gn6K9-00041F-5x; Fri, 25 Jan 2019 19:35:29 +0100 Received: from desktop-bart.svl.corp.google.com (unknown [104.133.8.89]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id 04F66C07A1; Fri, 25 Jan 2019 19:35:24 +0100 (CET) From: Bart Van Assche To: "Martin K . Petersen" Cc: Christoph Hellwig , target-devel@vger.kernel.org, Bart Van Assche , Doug Ledford , Jason Gunthorpe , Nicholas Bellinger , Mike Christie , Hannes Reinecke Subject: [PATCH 09/16] RDMA/srpt: Fix a credit leak for aborted commands Date: Fri, 25 Jan 2019 10:34:51 -0800 Message-Id: <20190125183458.220477-10-bvanassche@acm.org> X-Mailer: git-send-email 2.20.1.495.gaa96b0ce6b-goog In-Reply-To: <20190125183458.220477-1-bvanassche@acm.org> References: <20190125183458.220477-1-bvanassche@acm.org> MIME-Version: 1.0 X-Originating-IP: 178.208.39.155 X-SpamExperts-Domain: mailprotect.be X-SpamExperts-Username: 178.208.39.128/27 Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.04) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5mv+aMKoozBnNLw2JYRkbLJ602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO1tLifGj39bI0bcPyaJsYTagCTS5H5Pie2sCQ3gGSzr06cM7U7xDGmYwNG93LVnxwxjk yGQYCd08t3lHobjxX/OigDGQOIiVUN5rGO3B5zfV6lLB7UkASj5+Q7Z1jo1wYoGcQZDc/NA+AYRc xIJwNJDswajEtdTx0z97RFosJ+0XX4J8p9+Z4Omt11SsRVhZc5O0+hI4m8XEgLG9kXesazurVxXh H80moATcJz9k4m0jSta6vzX6sWvOVdfPU9Q907I7wX4PVM8uRZ9JrPUGzdH8MohzY4snR3KaIji8 TCpeqwD+Ufwmnv2XpsoA/vlp5nL7bykX8cT9ReKnRim+apKC0G2y+Mr2ale9nnzXJ+o1UDSGW782 k6dpc2+siniZEaBBQD2I5QH2BdbXmK3rYa8ppXum6KZe4eMUTLjXn3BvjnQnhcJex8V1sw+C2xqM rAbZykneW87JZ7jdpAlXQVADDgYNo2L2ikikIJmXA+EJKJ9CDjyJqwMkv6BJB2lztCOV7QtxJNU+ igS6jZCzGqpJmuDNJ3/L9Q9wLc4aqLRUvPEObNwbSIpq9S/jgd899z3dKxLhoxcmaInYbR5vlqFZ JlLyK2ygHNTfy41Cttvo7sn//RcLEIwmfxtejjVQPRdR7J54uCh7y/cyXn4gNizEl4GT+izmPxps 5i3VIDAVOJYVhKWF91egvasFoFaoK60jiD6XqsJZtjQxlyCdseyHOMuZZG++RlG2AEFbDFHRYfQQ D0IVT5dlkCOLok5OEhHA/eZZmmYTy+sY/CHpKeGvXHVFggc0157Ysxlq5Z3dsksKeFRmKOHI/40C LjPihwIeoj9zwqNSJz8SHmCZ+bxCLHLD8M1AAidHW08kKeoFJwcvz6VMYEhUT3FsSRfv2/sMSIEg vIcW6VO3wxn7YUf2EDYZyEwli+6nIpmk0EVL0EenctfJrl/gfo+D0ODnoCG7X+t1TW39Ja77LGPp OwAj6IMP28aPMtl2u6Kx+4+Huxzv1d6/j7MDIN1SScQedH2YWYgPyAz1BkOLTUiGJowwNFwKBhAh 7NeKYzwwwYGp+p2okElJG6VbPeUnGhV3sd4rxYOjbs6j0mefY0b4ffxz8Ne0ck6P4ivKdWmRJx+g ZBY48FVjzYzwQJ8NPI1L8nQzI24Mi0RodUDIJ7TXkAZ8Lg3hgpwJj9Y7nkVKceR7 X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Make sure that the next time a response is sent to the initiator that the credit it had allocated for the aborted request gets freed. Cc: Doug Ledford Cc: Jason Gunthorpe Cc: Nicholas Bellinger Cc: Mike Christie Cc: Hannes Reinecke Cc: Christoph Hellwig Fixes: 131e6abc674e ("target: Add TFO->abort_task for aborted task resources release") # v3.15 Signed-off-by: Bart Van Assche --- drivers/infiniband/ulp/srpt/ib_srpt.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index d426e01905f9..1a039f16d315 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -2870,8 +2870,19 @@ static void srpt_queue_tm_rsp(struct se_cmd *cmd) srpt_queue_response(cmd); } +/* + * This function is called for aborted commands if no response is sent to the + * initiator. Make sure that the credits freed by aborting a command are + * returned to the initiator the next time a response is sent by incrementing + * ch->req_lim_delta. + */ static void srpt_aborted_task(struct se_cmd *cmd) { + struct srpt_send_ioctx *ioctx = container_of(cmd, + struct srpt_send_ioctx, cmd); + struct srpt_rdma_ch *ch = ioctx->ch; + + atomic_inc(&ch->req_lim_delta); } static int srpt_queue_status(struct se_cmd *cmd)