From patchwork Wed Apr 15 08:08:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hou Pu X-Patchwork-Id: 11490319 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2B338112C for ; Wed, 15 Apr 2020 08:08:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11F052051A for ; Wed, 15 Apr 2020 08:08:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="hll2Bosa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2635591AbgDOIIr (ORCPT ); Wed, 15 Apr 2020 04:08:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2635633AbgDOIIo (ORCPT ); Wed, 15 Apr 2020 04:08:44 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58998C061A41 for ; Wed, 15 Apr 2020 01:08:44 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id b7so6460139pju.0 for ; Wed, 15 Apr 2020 01:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yYNKGc07OYBmETnhmBnne+7qYMfErRLdStvSK9DZOKU=; b=hll2BosaDpQ2YBILUSls0SxNhUPedGmg+z2GUiazXTZEVBjrCKFc349OXg1zamniDP 6gcyaWW2eKk63cCC6WIPTsJRIagWWhB1grz4erRGUhVTd3ykcTtfLxTZPfJaFlHm0Vo+ 2WoPyQZGd6aGn0nPHJi3UQV9QdqQ5Tht/hFPuQnuEKSx2VNbYAq8VOyrmCbKA74CLWtX a3mcOZbTkvC+7ipVyj0rated/TjFY2E9JWUt3879F4zyzek0mniOEivJO2pg/KKyucv8 T8CG0Fyj8yISf+SPGk+XlKxRxMpOFFZmR81Pl6Avl+7zPNK/CIrfufAH/a9AreMqqfIC F2KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yYNKGc07OYBmETnhmBnne+7qYMfErRLdStvSK9DZOKU=; b=pBTHRLmRWVUtWwdz3vHM0OIj5bNCvQGGdPuk3UnkOjmuFPBU1pN6/BQIkqgm1nXViq M8x353TayjUCTGTvjdZLUQe9GgQ3SBR2bJ7O7hZrnL1JQ54tocqP+dfjrCGf381Msaki 5iNgQ7zd7E3kGjdxS5QFKH8rE0obwrDzOR57wKN9IhuCEx/p0xxOmmcN5d33CdKwUzNi F0fiWtkB9TxNODrEat1XOJwk4u+zl054cTfbuKhDbZafLp5UEvhvlmG+cVDQ9978jMF2 /KtGRiIXJH9UIumhM61fjx/bB/DomO/kYmHr11w45wQuLcBLlRI2wpruuBP9KHxEvlyP w6yg== X-Gm-Message-State: AGi0PuYgensJQE8UrxTcMoUtwjSaQWkrfA5ByQo25WhB7KYGs9Au8Q/t gYCfPMyJDMroxF3/LGIXVvYTKg== X-Google-Smtp-Source: APiQypIqWjVIHBTvcz+GZPt0ZG5iTVoEaLnDbeH0s39YM2GseBFUs9fjRg1OoJ0bqqmuQCJZ0bUAyA== X-Received: by 2002:a17:90a:bf84:: with SMTP id d4mr4908421pjs.82.1586938123963; Wed, 15 Apr 2020 01:08:43 -0700 (PDT) Received: from debian.bytedance.net ([61.120.150.75]) by smtp.gmail.com with ESMTPSA id c10sm10020576pfc.23.2020.04.15.01.08.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Apr 2020 01:08:43 -0700 (PDT) From: Pu Hou To: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Cc: mchristi@redhat.com, Pu Hou Subject: [PATCH 2/2] iscsi-target: Fix inconsistent debug message in __iscsi_target_sk_check_close Date: Wed, 15 Apr 2020 04:08:19 -0400 Message-Id: <20200415080819.27327-3-houpu@bytedance.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20200415080819.27327-1-houpu@bytedance.com> References: <20200415080819.27327-1-houpu@bytedance.com> Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org Following commit changed the return value of __iscsi_target_sk_check_close. But the pr_debug is still printing FALSE when returing TRUE which is a little confusing. commit 25cdda95fda78d22d44157da15aa7ea34be3c804 Author: Nicholas Bellinger Date: Wed May 24 21:47:09 2017 -0700 iscsi-target: Fix initial login PDU asynchronous socket close OOPs Signed-off-by: Pu Hou --- drivers/target/iscsi/iscsi_target_nego.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 950339655778..56686e880d23 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c @@ -481,7 +481,7 @@ static bool __iscsi_target_sk_check_close(struct sock *sk) { if (sk->sk_state == TCP_CLOSE_WAIT || sk->sk_state == TCP_CLOSE) { pr_debug("__iscsi_target_sk_check_close: TCP_CLOSE_WAIT|TCP_CLOSE," - "returning FALSE\n"); + "returning TRUE\n"); return true; } return false;