From patchwork Fri Apr 24 03:58:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hou Pu X-Patchwork-Id: 11507031 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BE8DD912 for ; Fri, 24 Apr 2020 03:59:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A77DB2075A for ; Fri, 24 Apr 2020 03:59:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bytedance-com.20150623.gappssmtp.com header.i=@bytedance-com.20150623.gappssmtp.com header.b="YBfsf5zr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726445AbgDXD70 (ORCPT ); Thu, 23 Apr 2020 23:59:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725922AbgDXD70 (ORCPT ); Thu, 23 Apr 2020 23:59:26 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C3A4C09B045 for ; Thu, 23 Apr 2020 20:59:25 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id v63so4147935pfb.10 for ; Thu, 23 Apr 2020 20:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gSwadPZDs7z0NR+Wq1n49zqNXXT9ZEwk3RHF436fbNg=; b=YBfsf5zrinXBhhxkJe2FBGyeiG8aGdMfpXPDcTabiAV/Ub7VR+7D1YB1FdmDi2YZEn rE8Mb1FXa0TraFnXU/+I/Z1thtdkvsRWKAPLxQTHMiPFy02QAYwDRF1XfqTXR8XZB9DT OfyMgGqhKH8AfT4/HKNPEkoYQVz5gw4uvFi+hYjQWV8ijLyrc8KnO0OmwURjUcpCEuJD DIlciQz3olugUYTeC8SNv+c+i30txNXAb+hJQp3ldNaRdb4eu2jt4LAJpiYIzvpYMEbE jKjWKIP8f6lnUzr7+kQ1Nv2PT1rMxdhblg5KUQ4NVGq/Ii7ve0NmgC3aWFyDYTU6bX1/ mUbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gSwadPZDs7z0NR+Wq1n49zqNXXT9ZEwk3RHF436fbNg=; b=mB8aVRY73yJA1+5WhxcFpiYuAgUiJpCtMEDDxMvxp2lSttsG2EwOp6u6fk9F348amt LpqIgHea3+7HJWf2171fkfsvxPantrtK2ckz9tG2FhurAGE9b+FtsRmM7M7Ho9bGsCBH UyW8Bx4FozW/iP+BkdmMzoWwQ86bSqPhi0aH9uZCYdBI6KWo6zlwYqJXrQsk/wQT8iQA 3jl3Qgn9POit0XE9SRBuZlIO0O+NH0XBlysCyAtsVAZRll0iHG6W7rYM5ZrE7LtbfGZa 0aN9wtEsf23ozNgD0X1cXGT0qJx2it8pe/xSmZn4KwMvwJQHGgGaZv+dIVbFqHxMSGTH +L1Q== X-Gm-Message-State: AGi0PuYegW/vjNtfv+PxPgc4+5c0Hh5ST6PVU2haC5iVLdcCse7gobgp JFdL+rgK+fJ8Xao9zzBfxLGf6A== X-Google-Smtp-Source: APiQypLrJpchRobxsJ+BHIFRvWHlvV/6Fp//6VzqyU3IlzGfRY9j/OKW8hU4O136v/0opyBsGZBeTQ== X-Received: by 2002:aa7:843a:: with SMTP id q26mr7007116pfn.240.1587700764827; Thu, 23 Apr 2020 20:59:24 -0700 (PDT) Received: from debian.bytedance.net ([61.120.150.75]) by smtp.gmail.com with ESMTPSA id h14sm3624577pjc.46.2020.04.23.20.59.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2020 20:59:24 -0700 (PDT) From: Hou Pu To: martin.petersen@oracle.com, mchristi@redhat.com Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, Hou Pu Subject: [PATCH v2 2/2] iscsi-target: Fix inconsistent debug message in __iscsi_target_sk_check_close Date: Thu, 23 Apr 2020 23:58:43 -0400 Message-Id: <20200424035843.5914-3-houpu@bytedance.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20200424035843.5914-1-houpu@bytedance.com> References: <20200424035843.5914-1-houpu@bytedance.com> Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org Following commit changed the return value of __iscsi_target_sk_check_close. But the pr_debug is still printing FALSE when returing TRUE which is a little confusing. commit 25cdda95fda78d22d44157da15aa7ea34be3c804 Author: Nicholas Bellinger Date: Wed May 24 21:47:09 2017 -0700 iscsi-target: Fix initial login PDU asynchronous socket close OOPs Signed-off-by: Hou Pu --- drivers/target/iscsi/iscsi_target_nego.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 5292b6c51b4e..2fee1946fb7a 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c @@ -481,7 +481,7 @@ static bool __iscsi_target_sk_check_close(struct sock *sk) { if (sk->sk_state == TCP_CLOSE_WAIT || sk->sk_state == TCP_CLOSE) { pr_debug("__iscsi_target_sk_check_close: TCP_CLOSE_WAIT|TCP_CLOSE," - "returning FALSE\n"); + "returning TRUE\n"); return true; } return false;