| Message ID | 20210617061721.2405511-1-nathan@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a25503617834920e772b9abda608d902dbf26b5c |
| Headers | show |
| Series | scsi: elx: efct: Do not use id uninitialized in efct_lio_setup_session() | expand |
On 6/16/2021 11:17 PM, Nathan Chancellor wrote: > clang warns: > > drivers/scsi/elx/efct/efct_lio.c:1216:24: warning: variable 'id' is > uninitialized when used here [-Wuninitialized] > se_sess, node, id); > ^~ > > Shuffle the debug print after id's initialization so that the actual > value is printed. > > Fixes: 692e5d73a811 ("scsi: elx: efct: LIO backend interface routines") > Link: https://github.com/ClangBuiltLinux/linux/issues/1397 > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/scsi/elx/efct/efct_lio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Thanks Reviewed-by: James Smart <jsmart2021@gmail.com> -- james
Nathan, > clang warns: > > drivers/scsi/elx/efct/efct_lio.c:1216:24: warning: variable 'id' is > uninitialized when used here [-Wuninitialized] > se_sess, node, id); > ^~ > > Shuffle the debug print after id's initialization so that the actual > value is printed. Applied to 5.14/scsi-staging, thanks!
diff --git a/drivers/scsi/elx/efct/efct_lio.c b/drivers/scsi/elx/efct/efct_lio.c index e1bab2b17e4d..b7d69ff29c09 100644 --- a/drivers/scsi/elx/efct/efct_lio.c +++ b/drivers/scsi/elx/efct/efct_lio.c @@ -1212,12 +1212,12 @@ static void efct_lio_setup_session(struct work_struct *work) return; } - efc_log_debug(efct, "new initiator sess=%p node=%p id: %llx\n", - se_sess, node, id); - tgt_node = node->tgt_node; id = (u64) tgt_node->port_fc_id << 32 | tgt_node->node_fc_id; + efc_log_debug(efct, "new initiator sess=%p node=%p id: %llx\n", + se_sess, node, id); + if (xa_err(xa_store(&efct->lookup, id, tgt_node, GFP_KERNEL))) efc_log_err(efct, "Node lookup store failed\n");
clang warns: drivers/scsi/elx/efct/efct_lio.c:1216:24: warning: variable 'id' is uninitialized when used here [-Wuninitialized] se_sess, node, id); ^~ Shuffle the debug print after id's initialization so that the actual value is printed. Fixes: 692e5d73a811 ("scsi: elx: efct: LIO backend interface routines") Link: https://github.com/ClangBuiltLinux/linux/issues/1397 Signed-off-by: Nathan Chancellor <nathan@kernel.org> --- drivers/scsi/elx/efct/efct_lio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) base-commit: ebc076b3eddc807729bd81f7bc48e798a3ddc477