diff mbox series

target: core: fix warning on RT kernels

Message ID 20230110125310.55884-1-mlombard@redhat.com (mailing list archive)
State Accepted
Commit 84ed64b1a7a7fcd507598dee7708c1f225123711
Headers show
Series target: core: fix warning on RT kernels | expand

Commit Message

Maurizio Lombardi Jan. 10, 2023, 12:53 p.m. UTC
calling spin_lock_irqsave() does not disable the interrupts
on realtime kernels, remove the warning and replace assert_spin_locked()
with lockdep_assert_held()

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
 drivers/target/target_core_tmr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Christoph Hellwig Jan. 11, 2023, 7:07 a.m. UTC | #1
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c
index bac111456fa1..2b95b4550a63 100644
--- a/drivers/target/target_core_tmr.c
+++ b/drivers/target/target_core_tmr.c
@@ -73,8 +73,8 @@  static bool __target_check_io_state(struct se_cmd *se_cmd,
 {
 	struct se_session *sess = se_cmd->se_sess;
 
-	assert_spin_locked(&sess->sess_cmd_lock);
-	WARN_ON_ONCE(!irqs_disabled());
+	lockdep_assert_held(&sess->sess_cmd_lock);
+
 	/*
 	 * If command already reached CMD_T_COMPLETE state within
 	 * target_complete_cmd() or CMD_T_FABRIC_STOP due to shutdown,