From patchwork Tue Jan 24 17:24:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9535589 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B887C60434 for ; Tue, 24 Jan 2017 17:24:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A75152022B for ; Tue, 24 Jan 2017 17:24:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9B8DC205AF; Tue, 24 Jan 2017 17:24:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 169FA2041F for ; Tue, 24 Jan 2017 17:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750789AbdAXRYq (ORCPT ); Tue, 24 Jan 2017 12:24:46 -0500 Received: from mail-co1nam03on0081.outbound.protection.outlook.com ([104.47.40.81]:34352 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750782AbdAXRYo (ORCPT ); Tue, 24 Jan 2017 12:24:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandiskcorp.onmicrosoft.com; s=selector1-sandisk-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=PZ2aVV9WyxKRl3bEfDbburFgLEzmUGmi1HCQHsiUCQI=; b=wAlG68FJsdJcTUVzf4BZT1sCgBivSxTh6GTIpWuJAhZbHCsCgzsph4Phmovwkox1zs7trz4jRk+ZB4VGilm5TBmUEIQLkaVUcpvPd7pt0KGnEt+/I2BY7dg/1zK4t2GmVD1j30ZYZEqDT0MYkRDTLazr0rV9Zz7PPz+9v/qvnmE= Received: from CY1PR0201CA0020.namprd02.prod.outlook.com (10.163.30.158) by BY2PR02MB1281.namprd02.prod.outlook.com (10.162.79.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Tue, 24 Jan 2017 17:24:23 +0000 Received: from BN1BFFO11FD032.protection.gbl (2a01:111:f400:7c10::1:113) by CY1PR0201CA0020.outlook.office365.com (2a01:111:e400:58b9::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13 via Frontend Transport; Tue, 24 Jan 2017 17:24:22 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.21 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.21; helo=milsmgep15.sandisk.com; Received: from milsmgep15.sandisk.com (63.163.107.21) by BN1BFFO11FD032.mail.protection.outlook.com (10.58.144.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.803.8 via Frontend Transport; Tue, 24 Jan 2017 17:24:17 +0000 Received: from MILHUBIP03.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id EC.B4.65426.2FA87885; Tue, 24 Jan 2017 09:12:20 -0800 (PST) Received: from milsmgip12.sandisk.com (10.177.8.100) by MILHUBIP03.sdcorp.global.sandisk.com (10.177.9.96) with Microsoft SMTP Server id 14.3.319.2; Tue, 24 Jan 2017 09:24:13 -0800 X-AuditID: 0ac94369-7f3ff7000001ff92-78-58878af25a77 Received: from exp-402881.sandisk.com ( [10.177.9.6]) by (Symantec Messaging Gateway) with SMTP id 83.8F.09762.ABD87885; Tue, 24 Jan 2017 09:24:13 -0800 (PST) Subject: Re: [PATCH v4 00/12] qla2xxx: Feature updates for target. To: Himanshu Madhani , "target-devel@vger.kernel.org" , "hch@infradead.org" , "nab@linux-iscsi.org" References: <1484893684-1255-1-git-send-email-himanshu.madhani@cavium.com> CC: "giridhar.malavali@cavium.com" , "linux-scsi@vger.kernel.org" From: Bart Van Assche Message-ID: <490b1911-11be-5390-9776-ffbeec94254f@sandisk.com> Date: Tue, 24 Jan 2017 09:24:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484893684-1255-1-git-send-email-himanshu.madhani@cavium.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRmVeSWpSXmKPExsXCddJ5ke6XrvYIg3vnzCz2PDjHZnF6wiIm iwt7uhktuq/vYLNoW32G0aJ16VsmBzaPGb8XsXhsXqHlcX/7ESaPz5vkAliiuGxSUnMyy1KL 9O0SuDIW3tvDXvBYoGLjkcdMDYzPeLsYOTkkBEwkXi35wdzFyMUhJLCUSWJqz0d2CGcHo8Su 7f8YYap+LmxngkgsZpR4vOI2E0hCWMBJovP/PBaQhIjAWUaJzzPmMIMkhAS8JK49ng3WzSxQ J3F9/VEwm03ASOLb+5ksIDavgJ3E9SOz2UFsFgFViZ6JE4B6OThEBSIkPm01gigRlDg58wkL SJhTwFuiZZ4/iMksoCmxfpc+xHB5ie1v54A9ICGwjVVi9+ffbBAXqEucXDKfaQKj8Cwkk2Yh tM9C0r6AkXkVo1huZk5xbnpqgaGpXnFiXkpmcbZecn7uJkZIZGTuYLz7xPsQowAHoxIPr0VC e4QQa2JZcWXuIUYJDmYlEd6VlUAh3pTEyqrUovz4otKc1OJDjNIcLErivG73voQJCaQnlqRm p6YWpBbBZJk4OKUaGL3y7/53SDwfGn/HZ0eRpEhmstq/bZOKHhqJHq6pXWjWuttoxaVlOdM2 +q6wrHiqzh9pmpl6w3/rb3v9lvO37AV//55imvppdZy429knP98K9f+1eVWcOGOn/4+VVls2 Ou7wt5O5FnP3Wey7y296dl1n1LR4vV7Yv5T3KLO715TaGHZmk0LFWUosxRmJhlrMRcWJALLm 65qIAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDJMWRmVeSWpSXmKPExsXCtZGTTXdvb3uEwc6bUhZ7Hpxjszg9YRGT xYU93YwW3dd3sFm0rT7DaNG69C2TA5vHjN+LWDw2r9DyuL/9CJPH501yASxRXDYpqTmZZalF +nYJXBkL7+1hL3gsULHxyGOmBsZnvF2MnBwSAiYSPxe2M3UxcnEICSxklGj5+4wZJCEs4CTR +X8eC0hCROAso8SPu7/ZQRJCAl4S1x7PZgSxmQXqJA7fecoCYrMJGEl8ez8TzOYVsJO4fmQ2 WD2LgKpEz8QJQEM5OEQFIiQ+bTWCKBGUODnzCQtImFPAW6Jlnj/ERHWJP/MuMUPY8hLb385h nsDINwtJxywkZbOQlC1gZF7FKJabmVOcm55ZYGikV5yYl5JZnK2XnJ+7iRESnlE7GK9PND/E yMTBKdXAKLXARmS5zpknh1r7/2xQm+pksOLLzLX7vy63mx/7MNb4kbz787msSt7ZX21udh+K O6ErcFv6RrtI+raFHCcb7zUufhi9r8M7RXOvlFuiMXdIsdSSErtHx5e7+ttpKx1VST2ZkLbM YC63jftjZqnTrnPDfOcF8+gzbOw7pu+99sSSF31Lp66/rcRSnJFoqMVcVJwIAOesqMv/AQAA X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.21; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(39410400002)(39450400003)(39850400002)(39860400002)(39840400002)(2980300002)(438002)(189002)(199003)(52544003)(377454003)(24454002)(2201001)(23676002)(305945005)(69596002)(92566002)(33646002)(68736007)(76176999)(2270400002)(15650500001)(31686004)(2950100002)(53936002)(106466001)(4001350100001)(50986999)(54356999)(229853002)(64126003)(8676002)(83506001)(5660300001)(54906002)(65826007)(36756003)(77096006)(81156014)(189998001)(38730400001)(81166006)(97736004)(5001770100001)(2906002)(65806001)(65956001)(47776003)(31696002)(356003)(53416004)(230700001)(2501003)(86362001)(50466002)(8936002)(4326007)(626004); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR02MB1281; H:milsmgep15.sandisk.com; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD032; 1:3wN+ykFfX2KehJhknqo2lfMg/g3/SBYYNR10zfIWO5PDBUa0rSASXd5lTmtw3i7cDaxLINJUUav4qo5nk9ofMdTHDysYmDMnjbieRqmtnZOS7DXIIcF1Pcy4ceRF74rcgDfXZQ0fd7w6C0avYeFLH/cnw8fIGZX2LMcZk1LWw67AQuNGXYbJ5YP6NfYTk4206J6+rbw2CTKxTupr+BC9SkstO/lj55ahZ/B8ckkrMNiIkreNLKNdeeGvrTH3He9X0Qi9GUoguILLR2RDd7WGgW+qaGk/fTuUblhfB9ZP1AYdHhoOfUInoSOGj0DJvbWaAlTj9MquO8iwfLNjLVl5Ve7EUD1wueIegwIxgYBjnUUlI1dX9k91gLh36w/IIAsm9UT3S0mKq+1+HbROLPQCta65ucqIO0VaTAYxlbIzoqNfnBwfXJEQ19dFolkp4VkVMtgY6A6Hve8n6ICjjATLWeHn/zJ+p94wcMRiUYiPmaVwiIF88fBw5JWHV5km9idF X-MS-Office365-Filtering-Correlation-Id: 83dcf8b2-50a3-4116-80f3-08d4447dd3c2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002); SRVR:BY2PR02MB1281; X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB1281; 3:+8B/HbbFds8vbakUuEUBVblzXyCdYkOzQ/M99DR/JohTGySarapKFtl2I21yBZPjYlaliumzgjcrTDx6L0rYJxwNaN5XYEzNGONcsQGYBwHuTn2V1uBp1o1kSr21J9c0cpCJD/bzoImgyyUY3l0obRd0v4QMlm5xnxC6MsZ8T0DD09outSCtvmFbB1UHzpTby/S12HOvw/bw4g8ccSeXyy3GkiBH0FpdWk3L4Xoh92tDn0OpVpeHxf3LEo9A0fVH6b2fCzIqM6FNtLDO/WqukXxtuA/LZbWgim4RC7n+a24C7kSsOIoTe+fjZFx7du2suOAiya9PSDJcNC9KOUe4vJXWiV7oSG0O/OxTMlfwKhTJeZMJjyvySS8yaYBRvDDQFg2kx42tUAciMOAHTDbWXA==; 25:V33w8v9wg2YY/xh4kYUYXNEf2jZzrm5aNpPyyQbYaGso5Q4ppaDUIXK65lLR1EgKbH3Rg/GowhhoB52MrZLcDMjWxRWUiunx+v0SYc89aFx/XblyhrpwQf9Cw1nPNJTUvbVJwzSbxXaqwJKuFV/HAGbcAimu3HKLO1HeTz+peKfNQz8o5fenaFG3f5egjnZbn7KwWcYAhSS88r10S1RWYecoJiamaC8KiCm3yQCqv6XsH8sCmiedxdbS4NDvTf5XKPwko/LA9NFLQ0Z6mO9I8icZbyukyO8LWMVdyUwGLn1WVBVpjyLFSbZjKRDa/uk+N1tyFtXb1TH458lCCuwHWkTx2aNzF2nrflXCrzqkWjfxlYtiIIZgHlSSdg1TGFa/s9vWOFDKK+TOIciKF2iJhOd4bxrzwSn6CkGdmpN0Ump9dw0MA+B0ALoXcSMy3OtEizEmG58Kdw6qHpz2muPGZQ== X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB1281; 31:ofD9ecmv63g3UXkHUCwxvylPkGaWZgGu7VjNd3BwojJw5SSUOiMcjIKehfORuHwZJ/i2/5FNG2xZrUtD14o+GXj4XIg7b7iaDc46MV9H0poYMlMeFUY2oKtUpIzYQjc6xiVC6CoraQSp/l3ypbSt/5s+N0DfvT/ET4OPHDlonO9bUFlPf0mH4kmWh8mVp9aPoOSlhl5lVH6ZJkqfq96e2UP+zi8a15abtoPwANDdyhHsthqgA45PNlP8hGln7w8zjiFvbRl0QiCjg2LcBAXtPfG14wIllyqqLyy9z3X8I5M=; 20:BfygJTRJ8eopPicsMCCHIETcjIk+sNQR24K3msfrhmMbybkRFUdHhR3GHiWb6YI4hXGNBQeWy7WBgyIehE3mDwwP0aAfIJbrQR3vPm5QqFYqt44dsJJybWlmfiaLcktBkJBCfRSbdIcwg04PYlyaSuXxEX2UtVDiosvVYHyAZWhMfjQ0kCewutZKbZ0jJkPpSIlkgSkrkulEd/b6OK33m/45Bpplc2Z2KhdrKU6NeHP38L1TiaptvlIgdvHvjBRza638vpXukhwL3Pxi1AVpllWREHsVncSq6gqqsZAHgMZYZ0I5pRpJyVJrlORIOFYlEF8ZGtMDFxenuUcsAtD4D4dq0hTzv/VvHd628UE4cylLg6jzuW7SubRC2KOhqnznU9ecZgjk1R4GcqOUkU29OXtNbe/OMMvTJhUNFCQ+Y5KvBsqkZg2xLXR26jCurvpeyyE+MjNQLN/k7Rk0LLy5rirkmRj2DOPuDiIoU+xsFCuLAdrGL8zb5HKL3aWw6Vtv X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(13016025)(13018025)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(6072148); SRVR:BY2PR02MB1281; BCL:0; PCL:0; RULEID:; SRVR:BY2PR02MB1281; X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB1281; 4:P/snTiU8DKbF6LHkB1k/gCQs9V3WBwLA89zNHnoXDiHvfD6Y6UtDdLzT0foWWhJ3qdWGl7Lsgf9wMaYaUOTfICyE8/dLDhKlHeCa55Y+KpDeCfbpy+ouXbggkLjbLSGnoA9gD8HrIa/0wk7mCXuZgvHSaciLufdZBQ46/0COTkNG9hks+60O+cbV/R9TvaspvcyqpfUWM86G4IbdDLjwkmfSWDRzgfcJfMYZ2TGgY8EVd+o7Ez8ue7LATbXh9qFpfh6ogwVAx9ehv2pQuy/qCjScg0kUM8Nz6Aryd/gYl/062Bshs505zey0QegBEXURlsZ7DsupVjqqr4kBVIVgcaXWd+ZuHiSem+Ndjg0binZMIsz9dunfP6Fh0mooKaj1ribRYhamgLHl2KX0uhR3SUuk5d6YmYLeqQ4buPCvf8kuQ5dNrmniZdEHs15r0rCxXoK6gHrPE9Bspq/458E9rxs0QCIhANtdAVxWjDCz6DqfFnBP00b3gaF2lnk0DVwYa1erhZZBQu1raxmz0WSXiLMni06Chn4z6vY6GhZpv01B/xue3Z4TqIz+u+hVK8lw9mSLm5Of3zozrDJuCaf6FLwyX3ekBRJcqyWDjYMdmJysOkrKtcmGCjDCBY/J0U5KbtC/zoRJG7hWg+s9PzyfYN6h7P6dVGWPSN6+WMIAX9U= X-Forefront-PRVS: 0197AFBD92 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjAyTUIxMjgxOzIzOjNtbis1empRWHlibHVzNjZ1RGd3TSt0OG9K?= =?utf-8?B?Rk5velRNeEp3d3lVSzBHTXVBdHdsZURxYjlMaWhFeTl0WWZKUER5QXdjd0Zi?= =?utf-8?B?WCtlTUlZd1hKT2RWaG1Zb2R5REdjTkwzQnNpRG1jOTNMMk9rcm9QSEVQaGtm?= =?utf-8?B?RDZsQTJ4c2ZZY2lLUmwwN004VTFDRVhDMzJwYXhZWXZNRkprRnRvTjhnOHhF?= =?utf-8?B?MzAzOU1raVFlNHNBeUthSk85WFg3dUczRjdFbjNlVmVNd1VKb3FGREozNEY2?= =?utf-8?B?emk5emQrTXNRdHkzR1hud1Vha01tZndEUUFLNnp3YmJvZUtDa0FJY3kyRUhK?= =?utf-8?B?QzByWjU1U0lOU0M1aUhLczJhMTloK2xabVFaRkNtODRRcUFPeXYvMWdwZFBT?= =?utf-8?B?anphY1NISUNEbEE4TUZQbmtTOXRvS0IrWm5ZNGhRdjR3VnYzYXFZOU81WkZ3?= =?utf-8?B?NXZVRld2YzBHeUR2dnNBYStENFNQZDhJT1oyZDZFUEkxMVRhRndUZzR6T2cv?= =?utf-8?B?alp2ZUZhU3EzblgrNkxsWFdBem5ZUXNOSjM3UUJwN2tndUd1c0ZoNVJWQktV?= =?utf-8?B?OE1HQTNiUStJRGhxWEk1cUFFSGF5Y0lMTVBSMmY5ZEl4RGM0a1hmRDR1QWVT?= =?utf-8?B?OHk4aG4zeCt2eDVhY3I1ZTZpV1NYTXJ5ZUpUeXNXM1FrVWh0cmJmZ3N0S2h6?= =?utf-8?B?NHd0U2lzdUwxMzViWG9UZVRTcklNc0kwcXlOU3c2OHNSck1MMC8yOStXN2Zz?= =?utf-8?B?QThzRTJWRjl6eDFIS29tMENIYVZQdklnRXBKWStybGNOYUV6Mys2Q1lHdUhu?= =?utf-8?B?U0lTL2xWU2JaalFjQmtSQWhOOGozemFPaS9LY0FFcmtVRlN0VWtCRU5UcEZY?= =?utf-8?B?SjJNVy8xSXphZFZaajFqZzEwVHpmdTVwdUN3TTQxM0hZbDkrVTFNVDFlYTBI?= =?utf-8?B?ZFVUTHFmdWtPelp2VjltVUN2a0d3aWx0WWdZMHdqdUdoNE5GQVhUSkR1MWlB?= =?utf-8?B?VWJ5R3l1OFd6RGxidThqRUVxQnZKZjlwL3VhNnM0eFNtNitERS9TQlIrWnA4?= =?utf-8?B?UkROQjh5b1Z5ZmJmTUdGRjFnZFp3b0NBNis2R2huZ0xWaFNwRTNIZFhCNmNm?= =?utf-8?B?akEyZkRJNUlFQnBVSkhEVEhHMDJqSURzK0QxTFJ0eEJNL3hKNnBuMUtLOWJF?= =?utf-8?B?ZFV3V25PeUJUNXk5V25uRzBRSlUxUnoyWUc1VlFsdzJBZVo4SUhXTU12eWJl?= =?utf-8?B?bVcvemRFTFBSQ2N6eEJWVC9wTG84OHk2VFIzVmVVd1hFTE5DdDBEZ0JRNDVB?= =?utf-8?B?dUIrTWcwMkFSeHUvWXFaVFQwWG5sWWQzN2Z3T2ljU21TckVxYUUxclBaOXVj?= =?utf-8?B?MUpCZGFaLzJvRGhGSkkwVXZGRTFJR1B1bmM1RzBXdG9OSThhOUNFaFdScjlx?= =?utf-8?B?cHRVUnVrN3JYN3FQWTlDRjN5K0dpa0k3UWJGeldSbU9PbnJMbDdHa1VqQkNM?= =?utf-8?B?bXRueUJMWGF1djlENFJ2S2F5ZytXNmQ0WUdYemJZTEc3cEVwMmRFZ2VmRVFm?= =?utf-8?B?WDR0bE9VRU5XMHVQZXVQaDNnbzJMVElrZEczWm84WTJ3SzkrREkzbHlKQkJv?= =?utf-8?B?NzlZZUsvaWlQb1hVTVNLamVtME9FTXpqcUozTDVoazFXN2g4blBRSTVHaFBI?= =?utf-8?B?Z1o1TW5LbkFMRDV6WGxETXN4N0lzOWdtRjdNUU1pUTNHdjR6WUw5d1NrUzFZ?= =?utf-8?B?N1ZvNURyeEN6bFVNbGFPUzdoT1FCR214b1lGV2FDbjRkRWtlMThDRXlvNDNR?= =?utf-8?B?eEtRcWZ3QjB4Tno4SXpxaWp1VDA0TDBiMTZ6azVNbjlSTko2VU9FV2tkNW54?= =?utf-8?B?eHYxR2d4ZXgrMVB1VGJFY1NETDYvNEwwNFh5YThjczVORGkzRWdGbjVYWVFm?= =?utf-8?B?cEY4eG44c3hOQ1RwTjRqVmtqQWwxK1EvcDFjVjg0SWVMVnVydTBscXNtWWV1?= =?utf-8?Q?cXag18?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB1281; 6:jpXd5QboPelUBzcSxZVzGgz6ryBuM5YUWfzzveQqJg0ua4xyqj5EYw69JNwPyLGfS4vKP7cs3iDvEqtU5VssZTPBS9qzfRfRLNRhcUXyG9+gP87K+FFkMOU81MFGJZWiHDQBr7/m+5Yklrf9vCzifEn+zpJrR2NlrVcckEGzx+vMXFmYj1/h4AWHS0+qLvXZWOnd5uoqafgesM21PWgH0wU5gJWoNrNsM3l8FmH7i28pY90Lgq3oNtj4m064XGZn9Zf0i0bLSs/v/T8czpqNV9a/J5bIFr0Ng3WdtjXq1S1uZTGQePBJ66k6gPP49pWRTULvqPBAS4acvqol3Ai6kmw4D8rGM515CHMy73o3K4zUtps3nDm2xgmeNUV2pTATCdqXqAn5QQIEUAYm1wj007MFSoD2i6qtNrZtf832194WxL8JQCLdPxJuHPW1GzMxCEUh5BD6Af8S+JNC0Lmfcw==; 5:8Tk/Fkp7xyCCkaxwWi6BIe3f/aW9YHpDy8A2eycyiGG5Rn7z2aCleFJbselIIOkwxzPuo6McdzEbvOFDyBZQUn92fKaDTMm3S/MUN2Uq7dywffKd5NrCaVSbojb8aXSrhlVhHKtrFHvhC3KAnROW+w==; 24:taEMj/8FaoMemKNOzChC7xiqbur7wZRqariwyO3jmcBDpv877hYE1dsXmZoKWcPkrXQ5xf+pUvbXvun/WoQ0/CkpozhHeMoc2m6aRo7lb1E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR02MB1281; 7:t3dEzrM5TIonZD6+Tug5OjS3+lg4C9pQwWqZkRtH+V0lFc9lvt5rXfRYBjWyclGqlgpdoyX+/+P43k0Q9zAgXGo4x4ulLBDX0GGNXOXUVXFyIwCz6Xm4dpMRA0I7wVf5ySqLfM8ERhFXBaaYe0GvnfWdz4X74K34jFUY2W65YAkBIo0k4mCoGK7nhwRslVA2348qy19lAY8yHGK3TQD1FuqRJKCLX4SS3kFfJUP0qT2lbYUmddpCmOvukoaipiRZGZC/67IHeYJbWTV1xTJJuUqnI6b0meWvHTN5LDK/nGXBzLXhh23AJuPYWDjgGg8G5umTdfM1HrIHRJa0VbDKDBW4ICQCfYXqYh9xrUcwqe4Yau33CCqJMlwPibKGqC5BtcVpWIn10kYc0Ef8iShK41GBszuRz51tYHUmI9wviY3H8j9j0rpkYp+QeTmjNosnD7mEsEoVRvg0m11HoAvnHw== X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2017 17:24:17.3871 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d; Ip=[63.163.107.21]; Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB1281 Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 01/19/2017 10:29 PM, Himanshu Madhani wrote: > Please consider this updated series for inclusion in target-pending. > > Changes from v3 --> v4 > > o Fixed warnings reported by smatch tool. > o Fixed indentatation warnings reported by smatch tool. > > Changes from v2 --> v3 > > o Cleaned up sparse warnings reported by you. > > Changes from v1 --> v2 > > o Updated review comments and added Reviewed-by tags for necessary patches. > o We left the one particular review comment to add helper routine to > be addressed at later time in the follow up bug fixes pathes which we > will be sending in few weeks. > o Added patch to simplify SRB usage in driver. > o Cleaned up warnings reported by sparse option w=1. Hello Himanshu, One newly introduced sparse warning has not yet been addressed. The patch below addresses that warning. I would appreciate it if someone from the qla2xxx team could review this patch. Thanks, Bart. From: Bart Van Assche Subject: [PATCH] qla2xxx: Avoid using variable-length arrays This patch does not change any functionality but avoids that sparse complains about using variable-length arrays. Signed-off-by: Bart Van Assche Cc: Himanshu Madhani Cc: Quinn Tran Acked-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_os.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 817c5940df76..ec7e36c33e26 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -4272,8 +4272,8 @@ struct scsi_qla_host *qla2x00_create_host(struct scsi_host_template *sht, spin_lock_init(&vha->cmd_list_lock); init_waitqueue_head(&vha->fcport_waitQ); - vha->gnl.size = - sizeof(struct get_name_list_extended[ha->max_loop_id+1]); + vha->gnl.size = sizeof(struct get_name_list_extended) * + (ha->max_loop_id + 1); vha->gnl.l = dma_alloc_coherent(&ha->pdev->dev, vha->gnl.size, &vha->gnl.ldma, GFP_KERNEL); if (!vha->gnl.l) {