From patchwork Tue Dec 12 21:50:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10108337 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7DAD7602C2 for ; Tue, 12 Dec 2017 21:52:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6FA5F27FA9 for ; Tue, 12 Dec 2017 21:52:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 63DE3296BB; Tue, 12 Dec 2017 21:52:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 174CD27FA9 for ; Tue, 12 Dec 2017 21:52:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752719AbdLLVwe (ORCPT ); Tue, 12 Dec 2017 16:52:34 -0500 Received: from mout.web.de ([212.227.15.3]:51660 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752570AbdLLVwa (ORCPT ); Tue, 12 Dec 2017 16:52:30 -0500 Received: from [192.168.1.3] ([77.181.137.123]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M7Eb0-1fD0JC1Hhm-00x4tE; Tue, 12 Dec 2017 22:51:52 +0100 Subject: [PATCH 7/8] target/iscsi: Delete an unnecessary variable initialisation in iscsi_set_default_param() From: SF Markus Elfring To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, Al Viro , Arun Easi , Bart Van Assche , Dan Carpenter , David Disseldorp , Hannes Reinecke , Ingo Molnar , "Jason A. Donenfeld" , Jiang Yi , Kees Cook , "Nicholas A. Bellinger" , Russell King , Tang Wenji , Theodore Ts'o , Varun Prakash Cc: LKML , kernel-janitors@vger.kernel.org References: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net> Message-ID: Date: Tue, 12 Dec 2017 22:50:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:I3INywhemaiKyQg04VwgQBU1zL+siIo5oqSTmP2yAeH5y42ffBj W/ibWGdUTBLjBwvkqtVyTYZDGxO7yu6znjubqOxzl59iowGLyeyMKTL/hZc1GAPoB6mCEyo PSy043jAZBU31CYGpAdvIrU5xukKAxh+D3jgGJMIfQHE75kH/xt6B63XvuLcbRflfQE5PJd 3sZa/FqFZFr7h8IS6QoAg== X-UI-Out-Filterresults: notjunk:1; V01:K0:dIuIL4Ka3HM=:MRyMO1VMgclwq2Ym1iWE8G gAHoHkL53w4lsi/84XZ32OwUv9tXe98HGKm75lQjjkCrULIWjNVVBRPTjYhgCMUYc0qB/vSaz GxQuPZVZB4NXt0SGEy43UPoL3PDv3cP9a+22OwpamaVmoHpFdjjeFEhQ6jmWDHBkdOzT3eEzv lGpKgzwR8iXaABM197iZxdtQQpzaaeIgyU6G3wZ9LYRTS6WZnU8ZQE2J1fQMjzjDASJAO2zLa bbEH/8oZ5btmMN3CV6nS6lkawY/f4n3BEtmq+lerFhbbhIulDJZk2TTQSKxMsXATkyqwUJ3+R 0tfFmWQrobPgACO9WFrC470UARmXrPiFLfGQl8+vOeOLh/RhbmKXVHauAm5vLogqxHpzzopEh 2DTztmVsZAmlaTZk2a3TsggG2fKvcNA9rjglPeugskG36uxp02CSEqkIthE/XPPSOmCLBKuvi RhcooCgW0LzjQFfhdF8DEEBxFad0ttI8LFv9/eh/tYR2MMrzab/XsimbNb9mtIL3xJEblLOHN dL1Wf5AzHSexaALVmEB6OvXiCTOcT3poqk3iT8GhQlrhS34hroSxNUdnBiZb3xU3Zmwzk2qd4 MKcI1klXhqn+3lip2k56Qfa/6b0IKNPk39p0Rg/k0j/ljQ9O2h8aKkb6vK7h7FXm/J8q5eNxA uvQ9vacGXUVdG1TfCQO8CnuBu1VR0BDvXtIAWxRkPYeHL2qw4fwMLqWt9FLnmGtF1vC/9l+nQ Q3gsx1m9my8VoNIoR+0K2n2Lr+YZjyzcEHokyewbF0URfADf6XRjFgeUr9azRUHhW1xXKjhRV 5WK5oYZyRGjC/SU00kfTb93me7vREx16YdeZ8G+1R7NlNzrs4A6Tg6a7iaAYG9P5njQm1kz Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Tue, 12 Dec 2017 21:21:31 +0100 The local variable "param" will be reassigned by a following statement. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/target/iscsi/iscsi_target_parameters.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c index 151269b8816d..a49b0b2a4f6c 100644 --- a/drivers/target/iscsi/iscsi_target_parameters.c +++ b/drivers/target/iscsi/iscsi_target_parameters.c @@ -127,7 +127,7 @@ static struct iscsi_param *iscsi_set_default_param(struct iscsi_param_list *para char *name, char *value, u8 phase, u8 scope, u8 sender, u16 type_range, u8 use) { - struct iscsi_param *param = NULL; + struct iscsi_param *param; param = kzalloc(sizeof(struct iscsi_param), GFP_KERNEL); if (!param)