| Message ID | b666ab26-6581-4213-9a3d-32a9147f0399@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2e4b02fad094976763af08fec2c620f4f8edd9ae |
| Headers | show |
| Series | scsi: elx: libefc: potential use after free in efc_nport_vport_del() | expand |
On Thu, Aug 15, 2024 at 02:29:05PM GMT, Dan Carpenter wrote: > The kref_put() function will call nport->release if the refcount drops > to zero. The nport->release release function is _efc_nport_free() which > frees "nport". But then we dereference "nport" on the next line which > is a use after free. Re-order these lines to avoid the use after free. > > Fixes: fcd427303eb9 ("scsi: elx: libefc: SLI and FC PORT state machine interfaces") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > From static analysis. Untested. But it seems low risk. Look reasonable. Reviewed-by: Daniel Wagner <dwagner@suse.de>
Dan, > The kref_put() function will call nport->release if the refcount drops > to zero. The nport->release release function is _efc_nport_free() > which frees "nport". But then we dereference "nport" on the next line > which is a use after free. Re-order these lines to avoid the use after > free. Applied to 6.12/scsi-staging, thanks!
On Thu, 15 Aug 2024 14:29:05 +0300, Dan Carpenter wrote: > The kref_put() function will call nport->release if the refcount drops > to zero. The nport->release release function is _efc_nport_free() which > frees "nport". But then we dereference "nport" on the next line which > is a use after free. Re-order these lines to avoid the use after free. > > Applied to 6.12/scsi-queue, thanks! [1/1] scsi: elx: libefc: potential use after free in efc_nport_vport_del() https://git.kernel.org/mkp/scsi/c/2e4b02fad094
diff --git a/drivers/scsi/elx/libefc/efc_nport.c b/drivers/scsi/elx/libefc/efc_nport.c index 2e83a667901f..1a7437f4328e 100644 --- a/drivers/scsi/elx/libefc/efc_nport.c +++ b/drivers/scsi/elx/libefc/efc_nport.c @@ -705,9 +705,9 @@ efc_nport_vport_del(struct efc *efc, struct efc_domain *domain, spin_lock_irqsave(&efc->lock, flags); list_for_each_entry(nport, &domain->nport_list, list_entry) { if (nport->wwpn == wwpn && nport->wwnn == wwnn) { - kref_put(&nport->ref, nport->release); /* Shutdown this NPORT */ efc_sm_post_event(&nport->sm, EFC_EVT_SHUTDOWN, NULL); + kref_put(&nport->ref, nport->release); break; } }
The kref_put() function will call nport->release if the refcount drops to zero. The nport->release release function is _efc_nport_free() which frees "nport". But then we dereference "nport" on the next line which is a use after free. Re-order these lines to avoid the use after free. Fixes: fcd427303eb9 ("scsi: elx: libefc: SLI and FC PORT state machine interfaces") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- From static analysis. Untested. But it seems low risk. --- drivers/scsi/elx/libefc/efc_nport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)