From patchwork Mon Dec 11 10:45:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 10104715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 963F7602D8 for ; Mon, 11 Dec 2017 10:45:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9AB8128EAD for ; Mon, 11 Dec 2017 10:45:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8F7952953E; Mon, 11 Dec 2017 10:45:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3F3F628EAD for ; Mon, 11 Dec 2017 10:45:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbdLKKpc (ORCPT ); Mon, 11 Dec 2017 05:45:32 -0500 Received: from mout.web.de ([212.227.17.12]:63996 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403AbdLKKp2 (ORCPT ); Mon, 11 Dec 2017 05:45:28 -0500 Received: from [192.168.1.3] ([92.227.98.61]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MPHKO-1eSlRD2k5o-004Qjr; Mon, 11 Dec 2017 11:45:23 +0100 Subject: [PATCH 4/6] target: tcm_loop: Delete two unnecessary variable initialisations in tcm_loop_issue_tmr() From: SF Markus Elfring To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, Bart Van Assche , "Nicholas A. Bellinger" Cc: LKML , kernel-janitors@vger.kernel.org References: <42f13f0c-ae1d-ec1e-fd9d-62dd15aeba8c@users.sourceforge.net> Message-ID: Date: Mon, 11 Dec 2017 11:45:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <42f13f0c-ae1d-ec1e-fd9d-62dd15aeba8c@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:HknCNOM7mnJuw3G2zBkMGL9WRNcYOc1IuOiQuUzjgoIowSmwQHz xqHlXWmk022CWYKYo16Z6J6sA+7gJ7VgYv8R7iMgc+ROh4ztAueWvtCvbURMEJ3NaDSjMnv QqJf2bP+BVuN5kGj1QERknkrPDUb38QFoBQcWpldiQNKBq3lJygas08G8G37u5YrXb6T0a/ QgNkSViOMXe6JVv//tpkQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:sVlGkpUuh7g=:FZkAfxCOmIwi4UKr0DQnxS eHwORSTV+84ji8OldyDXGIWlAz9vgAzjir6exZ1fro/fBWedsQVpYdgfbKvxbJZFGy6uXz3Uu dhT1A9JkvFu6BkbAOA46luykegFMmHtvlk2jd4nFNf6MJcRFSpYz/fV6FyUapaUsWapRMGswj lGKSHIroQh2/C4o2UpoaKkuG1s8VEYsxKVbNdrBgSzt1fd5D+Yvz1ab9Py2SGpPmR9LZ5SW16 +w+Ofk2RaGPE7Aj6DQULfuOcrfw7/TT8HuraYIAqHhDaJWaDzcjOPfEfHdGfYA7v0YQlvZHGh Iq3yVCubwydrQIjB3X23Yqv1RUcA23OeX746toORdxcAgCA1Kc+XhDjxMJVfMZk3I9uz32iY9 u8VMLby88MGCpxC+pS5LtYbn3qPUjErv3qnKk7VSlB22MzKMjtMKd1/i6+H7pDQ1RyaCEOOQF B8PS7Mszn9+blscrcAYijZe0xRd1EQ8JJjZTEueQoJnsuXmF/atgmihjZYnTbvYcxmrD5ADma if1oGGPeIZ4vgzTpn87J8wr8r4HPM2ks4zyu0VVImXiKkgh0Pjm4dsINXwCi+mJ280wv/WjVB Rc7fJNU+LO6RqmPZYo6gRBvsTN8UAdv4FeF+aCb3f0wyD+Nyu5xN3lhY7RUCGj4q96O2L4p1b 2dTZtRONVHspWdx0sm0uxbn91Z7BdbOjUBfLcx8r6yw4gPF4HCcR4suUV6EDupsPRBSKu00Dh vb3xIQMVJxGDv4a7G9m/WA3ePer+X/ZnmvQg9FiIRuQEWSvLzg4jepxXrT1Wz/8dWmuVySbly Wapce0igZDNBiU5ki2A4yI4s7Xyid706xNbi+j+tYeF+PBvCMQ= Sender: target-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Mon, 11 Dec 2017 10:56:42 +0100 The variables "se_cmd" and "tl_cmd" will eventually be set to appropriate pointers a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/target/loopback/tcm_loop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index d91109c1c4ae..08dbf5b4ff15 100644 --- a/drivers/target/loopback/tcm_loop.c +++ b/drivers/target/loopback/tcm_loop.c @@ -203,10 +203,10 @@ static int tcm_loop_queuecommand(struct Scsi_Host *sh, struct scsi_cmnd *sc) static int tcm_loop_issue_tmr(struct tcm_loop_tpg *tl_tpg, u64 lun, int task, enum tcm_tmreq_table tmr) { - struct se_cmd *se_cmd = NULL; + struct se_cmd *se_cmd; struct se_session *se_sess; struct tcm_loop_nexus *tl_nexus; - struct tcm_loop_cmd *tl_cmd = NULL; + struct tcm_loop_cmd *tl_cmd; int ret = TMR_FUNCTION_FAILED, rc; /*