| Message ID | 20240521-fix-check-deps-v1-0-d149bf40e7ee@bootlin.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | get_info and check_deps fixes | expand |
On Tue, 21 May 2024 16:41:36 +0200, Louis Chauvet wrote: > The dictionary returned by get_info() does not contain all the keys (for > example, "needs-checking" is only defined if there are some check commands > AND b4 prep --check was executed). Instead of adding to the complexity of > this function, I rewrote it using literal dictionary declaration, making > it impossible to miss a member and easier to read. > > The second issue is with check-deps, when using the cover-letter strategy, > as the cover letter is an empty commit, the git am command was failing. I > simply skipped this empty commit to avoid errors in git am. > > [...] Applied, thanks! [1/2] ez: Ensure that all the info dict keys are defined commit: a7db8293793cc960482bb5a8093deed04498e0c7 [2/2] ez: Fix check-deps when strategy is commit commit: 8a47064cfdfac42d9f172f4163ff8fdc1b9fb970 Best regards,
The dictionary returned by get_info() does not contain all the keys (for example, "needs-checking" is only defined if there are some check commands AND b4 prep --check was executed). Instead of adding to the complexity of this function, I rewrote it using literal dictionary declaration, making it impossible to miss a member and easier to read. The second issue is with check-deps, when using the cover-letter strategy, as the cover letter is an empty commit, the git am command was failing. I simply skipped this empty commit to avoid errors in git am. Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> --- Louis Chauvet (2): ez: Ensure that all the info dict keys are defined ez: Fix check-deps when strategy is commit src/b4/ez.py | 82 +++++++++++++++++++++++++++++------------------------------- 1 file changed, 39 insertions(+), 43 deletions(-) --- base-commit: f3d47b4f92dfbd09106b06ade5020458a339d960 change-id: 20240520-fix-check-deps-517bd144daf9 Best regards,