From patchwork Fri Jan 17 11:35:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 13943228 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2EC61D8E12 for ; Fri, 17 Jan 2025 11:35:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=10.30.226.201 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737113725; cv=fail; b=C4ZRJPZ82yv9VXnHLacedcJ53iDaRSPF2ZWaxV/VGmw8T+UIBxGPVaUYIdh9cIDWcYd2g6rHcK3LrafPwOKwIK/nZIH7AxNMcSiuiMhg0GFO76Am1iVLzpV7We6fbseAM8ZoF9kXuyizXT53JMufoXuY2sLx1AXfHVXKGFherj0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737113725; c=relaxed/simple; bh=3XASuc+9O/iGzCnkzVe2Twn0OvlpTRhpfHrlVMIB1BY=; h=Message-ID:Date:To:From:Subject:Content-Type:MIME-Version; b=GihrlqcBRyGD2exuwL7Yd9fR8bSsTGpTJMwGa+C7BFlDEG0/kWGarm7h4VFZCn3xIcSos/om4uw/d41huwVUWaCWQVGVA2VFvfcc7gVGo3GnGklwhjRv1m1KMn5kqtBfFv/KfwQF6Bqpj3zkYfcGBRoFl+b1E4UXjncXTx8s5ZA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=cherry.de header.i=@cherry.de header.b=GiBbXCcL; arc=fail smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=cherry.de header.i=@cherry.de header.b="GiBbXCcL" Received: by smtp.kernel.org (Postfix) id C9025C4CEDF; Fri, 17 Jan 2025 11:35:24 +0000 (UTC) Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011063.outbound.protection.outlook.com [52.101.70.63]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 7B7D8C4CEDD for ; Fri, 17 Jan 2025 11:35:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 7B7D8C4CEDD Authentication-Results: smtp.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cherry.de Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=cherry.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bKEJL1R2s+4+3IOTG5tJN33AVUzBDb4OSkxG/YZInUR6zPu99U1tkDl1f9qncDVtXN3hnmdx8F6W9b8P7z6t7HWXXkwRH/nDM8VqFIBSTYyY2U9IU0G888a6N+1WqaGwTj+lsydSSiD67VYQ4QdmkA+hSyOAG3fzSVz3amtKXvv06DpIDBMlYLLAnZFTIZOlnng+qsJaCfrh4aSajMAxjyWfOYnCn7sfvi9mBRpL/WK6YRMAcVePIkYEIpdWTYJkIPsBKdpl5O6wvva8kv6pzucU/ngpMjJAVzJpQRfUkSGMlOXDbLPk/K/EBeB/MUwICTSehfiA0AD09CN+0TZ2dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BaMdS02cuoj8c554b0auTqLsQb0kOQuEEAYwkv2MvCk=; b=rsqXFkARWEJKjyHitI60w1HgyZKg8D4iFZttitFk7hg6gMxHmlvMbpwbbCWeiPtipu8AHemfgNXVfCBgukJDwNxdW3JKIkBtGG5WZbBvAx3+KLbxkHTdf9II+2Da0J0m6La4FNnyxUy2sY6zI6ZJGa6LzrV5VDP99CZJF/4X3BBck/qdi9cazHrXG+wdMyjT9Zr/P6fGCSP9j0yvCvx/nHzJSloD4wQmCRTTn1llITyMUFbgi5zmfTGfQrVCUngy+hqJBcVGTK3hc7eZGJSY0PutvlElc1KD223oA7u0kmy7zZ60FDe4prkxosZDNQk8BZGzuDtebmislUBOYas8wA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cherry.de; dmarc=pass action=none header.from=cherry.de; dkim=pass header.d=cherry.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cherry.de; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BaMdS02cuoj8c554b0auTqLsQb0kOQuEEAYwkv2MvCk=; b=GiBbXCcL4TQe6fBbQsyTwN5ZJw4Sxb0hiJyCnnaxZXUJOOR/XFFAkzJ0mlEEJsk//fsbtfhFHbdNVBb2YLJKGWbdeuik9gdxsPoZidgZwATuQuWxCy7m1EJ0sWPHCisjysuinkH7OPpLocPVLHVOm0WZlqjxXlMMRcIHwvH3dlo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cherry.de; Received: from AS8PR04MB8897.eurprd04.prod.outlook.com (2603:10a6:20b:42c::20) by DU2PR04MB9522.eurprd04.prod.outlook.com (2603:10a6:10:2f5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.16; Fri, 17 Jan 2025 11:35:17 +0000 Received: from AS8PR04MB8897.eurprd04.prod.outlook.com ([fe80::35f6:bc7d:633:369a]) by AS8PR04MB8897.eurprd04.prod.outlook.com ([fe80::35f6:bc7d:633:369a%3]) with mapi id 15.20.8335.015; Fri, 17 Jan 2025 11:35:16 +0000 Message-ID: Date: Fri, 17 Jan 2025 12:35:16 +0100 User-Agent: Mozilla Thunderbird Content-Language: en-US To: "Kernel.org Tools" From: Quentin Schulz Subject: [b4] prep-pre-flight-checks doesn't seem to work X-ClientProxiedBy: FR0P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::14) To AS8PR04MB8897.eurprd04.prod.outlook.com (2603:10a6:20b:42c::20) Precedence: bulk X-Mailing-List: tools@linux.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8897:EE_|DU2PR04MB9522:EE_ X-MS-Office365-Filtering-Correlation-Id: b388193d-d734-4221-854a-08dd36eb03ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?GW1/O7XllqlUxznD7wYRuZHU724BKA/?= =?utf-8?q?3wZHfAWiVAzhpC/iUzQTQekt9L//Gyru/8WXnb2SJYp8nnqvp4fY27onIFgbXuzVR?= =?utf-8?q?r63sHLaEyG31BiOEtKF6NA8xd3CSuf1CFtC8fYyiH4ijbCJEJvKX1cmp3jUk0VNME?= =?utf-8?q?8Z/CaXV8hc2YWsQt9VTJ5epnsGNijRrgXm7ObhJu2MUFX0tGaVesFaL+doCF8ajB2?= =?utf-8?q?6hyIGJQJn6b+ssFx4dQfyX0R2OdqoTFLxotlEcuRDe5mdo9NvKWZZFW9e93uJWjR/?= =?utf-8?q?p0m+wsCMfePqVjzR/pFhprYy9TViaQfqFUBE92kS6KljqLPcV8qA7CdYSSYK7Qfu4?= =?utf-8?q?Y2+ZR8V93BTl6UHKdGDR61SlHRw8jx9aXg2/yIK6wOA0jPYvZCnOw3K6mVTt9gAlr?= =?utf-8?q?V7euqA8UDkuIlopfcXGZQtPjC6BJ9apdSujMuGKC1Tq/cB3UdBhPtpqnklJJiiF4S?= =?utf-8?q?fvlO4ttKBp/2JEoupxcmQ9byYsIi7rDqmpg4mhSJpmvXPz8UpAvb6Os8bf5QmR3Qr?= =?utf-8?q?8G2R/2LdfxOFNfGyE9gSLHeBOSxrkXdWFkcxonbzrnsmN/li+aebUbMLqGD6s59Xj?= =?utf-8?q?+bar2cPWJYEmODaubNeSQ/mPyGDnrO6iexLDwM6VrJySjvSAkpYk1mAqYRolnVAqx?= =?utf-8?q?iSUl8Rl2QhGUwdCpZAnnWbytkMMejNlwal2W5swzIM2rX06/MNr4tMUSj/zJZoy/v?= =?utf-8?q?HYlj4ojT6zDjStDFn8dxlqwFTdiBmr070qzJD5fqKTFM4cVsGDdYNTvD3NxlysyH9?= =?utf-8?q?NtMUFFPlo+mBj5+iW4y3twtoypRWz9VJWo9ye6Ll3RGkAkUJEhrVVkeRlVGJFGP7A?= =?utf-8?q?pK2LZsq52tzyLGvl3h3uY69sttyxHw6zqNiYLZYjAXasrF5/8eEg8LlhxIk/y7FjY?= =?utf-8?q?JnyRDZ09B72RHWoPAMGTBKXyHHN3DuS9Q1yerAncxU/UpTyOR75KCxdpnWIJKA+OT?= =?utf-8?q?1D2y9m3VRhFeX5wJQOqGj86O9/8Y+T1+/SDMI3gDKmkP0udFm65gRyw3nRk62yQgb?= =?utf-8?q?mKlyOahZRNZ6325bGMq8djA7KVusrkhSJtPoxXKNalHWtB1gTrCrKnCGpe/luc9jq?= =?utf-8?q?uT8iGWKwTRMa8+qMMbtjHpZFl/X3p/GQrqZZHuI8DkDt5vIY0IBZjmuQjsoSJmsg1?= =?utf-8?q?jWan0kFOdKZI/+arJNQJz/WTlxoLhayBdaUqKuU6t1EKoOR4AParK7mgUHSXF1L1X?= =?utf-8?q?sO1u9VSVYLbdNXZpCmYXGdmrrCRCrQDVAuExLseNbTSp42jGgWqyzzMRKunfvI824?= =?utf-8?q?jTwPd64ivxmEXbTDK5t/gjIsnfWsXYSIrwA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8897.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?XcTpqaGtUST1ASvz1DwWHhgJqH9W?= =?utf-8?q?ZfNCtY/dCP+EVj/NMHTmj6FiWPm0zDHYeiA5KNw0Lzpkx4b/FWu2kGl4ZfqSgVxOh?= =?utf-8?q?l7RFnYOrBkWkeiAMpVQ1ibaYglyKOGpwYfurDhoegGePqGpbT+3GzCHfBKXEavCLG?= =?utf-8?q?FjWarp/rnkEWZE0rtd30YE+vkUzoX4qQogs8IT3H9B20NqFDh/ltlwIH6bOZ9A3BJ?= =?utf-8?q?ikvXW1tfG13J8fPLj0iAfb7mUlJQTycYgtOrr0e3d7Vu5vsgj8cUJ8kD5Ssh69HAw?= =?utf-8?q?88EyuBDiyU7UlVzqt0BplpZsGYSpC/4Cs0BaVZKZXXTpivCY4mE/pEfhqyxhE8kAO?= =?utf-8?q?1NK7K6WFo7+40qM2uXAUD+q9a6nDy3FOdvpagMR+YwaQcsYpv+5Anu2PCwXR006AR?= =?utf-8?q?vkgrk/8owgI13V/R1oiXu0AJYCbVt51/uDByLQwxVHAjMob0Am213q2W3sqzKq0ja?= =?utf-8?q?IN0+Ep3rAMG3UZ1AP5xkAjTrOChCKPYFVQ0B157fZmUC2Kr9YCTYJbB5zc0vqZYtd?= =?utf-8?q?8C8wCzjrJKM4LR14uRctHenVw2dvIa3vrpFu8cg7w2rBIBrbaojXBLXoloKWZOzft?= =?utf-8?q?DEvuxb7uGPtVq5RclF3byqej6GqoL/r3DOxk21saSih6cxU3cInxKj7LVNOJfmRsC?= =?utf-8?q?bvb/C62HhOyjRgVozo2DRRV5nrhmDxJ3E4LDV8SHaE7ruTVyL55HH69VcUo9OyJdb?= =?utf-8?q?8UXM+darmw09tCpXfD/Ra7dUn1eQUxoyzdiLGAeKF9zw0bK3lxEuCLdlaEzPLvoo/?= =?utf-8?q?QvUezr1Q9Wa7ujAgoqpylfumkoI2lAyAGJ93xjSfgtWV/angLM92UoC42IxdlEd0Y?= =?utf-8?q?G0uGtDS37v8QA7UGnlrXHbfDsrtFMZHjlXo8qjgAfrPJnSuOtaYIn1TmN9IbVfSS9?= =?utf-8?q?lgW2B3Gc4vnO4UiCuQLaMWaERBrdIhEmPBNa1oUm83CADxt0x+fXNTn33M4Z5uCm+?= =?utf-8?q?owdC4tD3ftWS34zPhqQGdnmMHU5Pha+s+egNZY7ic9bZsDQXAxdNQA8OF5PZgg15O?= =?utf-8?q?laC/KuwcQAjIA94FEAt4MYRNTx7WM7rmFZzXmyTK35WHTPuMfwZrx+Svtf9EI1xIM?= =?utf-8?q?dFwlxGXnlx+iHKgBAlwbRV2FLz0tiOmkXSg6wv6ZolQY6qRY/74nbpfol0CsV4HaA?= =?utf-8?q?mSSFpUIWJRRBXgDal7CYbkHcJVaDltyDgkEE2oGHTsAhq2P9Jnm/qZSBycMaBAO5t?= =?utf-8?q?51Fbg9vVhd2vnNv59b9osqPH7ja0vfDOSBeUD4G/yvsDjEpKFxEQdQ0093lMMV/lh?= =?utf-8?q?QWq+ki2S3MzDbkY78JvVdS/bFfUGZG/CbYqjzybknR9uDbHdzZCmPCdgBgjcJlWCF?= =?utf-8?q?VLCpYv+DY2HfihfKUKLQU8m4AF8NtFZC8m5sOVtPwpfZ9zP3ZG1Hus+8Hd9/tCeE5?= =?utf-8?q?rN2xyKnMYd4q4EQa+gKowbSF/0nKNmC4TzVCsQXHsa2x67ny5XJDHpx5NbqbVGSCf?= =?utf-8?q?Kc2Tya5GlWJWlbvoocyW9cSukPVuXPTpBziyRynn0x+TxWWKUMcAN+LbcdQ6xQ5N4?= =?utf-8?q?Jena93TVcp3DdnjLvWDDRrCzf2uQnc74Jg=3D=3D?= X-OriginatorOrg: cherry.de X-MS-Exchange-CrossTenant-Network-Message-Id: b388193d-d734-4221-854a-08dd36eb03ee X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8897.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 11:35:16.9297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gmA8aODJ8triI9eWv9VArVevDCw7lHcn10lGw/2t8RP3ApHt/K3+rib4OdWYnN8doS+kbpUWj6VmJfzw2swtXB2ZVsjrhVGrRXuSUT+fK1M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9522 Hi all, I believe prep-pre-flight-checks doesn't work. I've added [b4] prep-pre-flight-checks = disable-all in my local git repo .b4-config, but b4 send still complains. Adding --debug to b4 shows the following (stripped down to what I believe is important): Loading worktree configs from /home/qschulz/work/upstream/yocto/yocto-docs/.b4-config Running git --no-pager config --file /home/qschulz/work/upstream/yocto/yocto-docs/.b4-config -z --get-regexp b4\..* wtcfg={'send-series-cc': 'yocto-docs@lists.yoctoproject.org', 'prep-pre-flight-checks': 'disable-all'} wtcfg: send-series-cc=yocto-docs@lists.yoctoproject.org Now if I dump cfg_checks from https://git.kernel.org/pub/scm/utils/b4/b4.git/tree/src/b4/ez.py?id=33ea697cc3d0bc77d2f3fb58176116608a0f1332#n1923 I only get "enable-all" the default value if the prep-pre-flight-checks key is missing from the config dict. """ multivals = ['keyringsrc', 'am-perpatch-check-cmd', 'prep-perpatch-check-cmd'] if topdir: wtcfg = os.path.join(topdir, '.b4-config') """ patching b4 with the above makes the property persist. No clue if that is the proper way to fix it nor what makes a setting worthy of being in that list. Have I missed/misconfigured something somehow and this should work? If it helps in anyway, running Fedora 41, Python 3.13.1. b4 tested from master (33ea697cc3d0 ("b4: stop generating full object IDs for non-binary diffs")) with b4.sh and also from v0.14.2 from pypi. Let me know if there's anything I can do. Cheers, Quentin diff --git a/src/b4/__init__.py b/src/b4/__init__.py index 814413e..b514556 100644 --- a/src/b4/__init__.py +++ b/src/b4/__init__.py @@ -2883,7 +2883,7 @@ def _setup_main_config(cmdargs: Optional[argparse.Namespace] = None) -> None: # some options can be provided via the toplevel .b4-config file, # so load them up and use as defaults topdir = git_get_toplevel() - wtglobs = ['prep-*-check-cmd', 'send-*', '*mask', '*template*', 'trailer*', 'pw-*'] + wtglobs = ['prep-*-check-cmd', 'send-*', '*mask', '*template*', 'trailer*', 'pw-*', 'prep-pre-flight-checks']