From patchwork Tue Jun 21 01:54:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ed Swierk X-Patchwork-Id: 9189165 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1167D6075F for ; Tue, 21 Jun 2016 01:54:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F292E27E66 for ; Tue, 21 Jun 2016 01:54:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E735327E78; Tue, 21 Jun 2016 01:54:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8031827F10 for ; Tue, 21 Jun 2016 01:54:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1bFAta-0007IK-9R; Tue, 21 Jun 2016 01:54:30 +0000 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1bFAtZ-0007ID-C8 for tpmdd-devel@lists.sourceforge.net; Tue, 21 Jun 2016 01:54:29 +0000 Received-SPF: pass (sog-mx-4.v43.ch3.sourceforge.com: domain of skyportsystems.com designates 209.85.192.181 as permitted sender) client-ip=209.85.192.181; envelope-from=eswierk@skyportsystems.com; helo=mail-pf0-f181.google.com; Received: from mail-pf0-f181.google.com ([209.85.192.181]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:AES128-SHA:128) (Exim 4.76) id 1bFAtX-0000VW-MR for tpmdd-devel@lists.sourceforge.net; Tue, 21 Jun 2016 01:54:29 +0000 Received: by mail-pf0-f181.google.com with SMTP id c2so939763pfa.2 for ; Mon, 20 Jun 2016 18:54:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ig9ekGxkvVZtu9wHTzm2GoJGAOmJ9EM7sQUIP1fCVDE=; b=TVyqjcjCTr9qwROAuSplHLeSN4xkMztc6WDoIBSfHKWwCDdfgWFnvdCldgjCpfVHF6 mSni/9amKRMa39WPXoKOcMugUGzwCrLd8itklH17eqvRXjdQ4GUsDx1kO58/LtnaeJsE ZUFAnmvApehpT67xPywIUBPkv6HinVzgTqHWcHSuGUH0KuwIALyCDk5U/IxqCcrH/fzv 9QgoIWSk4QkSsKtTpdh5QikyhTkJbpeZaOUlxMqpMu7DnPtvsxDQL5gBpSUMaFH295EX Nyp1PMfBiNBwa60Oxrx9SEWOmNpc/WKOdJycxAg/QfmEzeZU6eL+B9e2ZfudQwFXLX6L 90fQ== X-Gm-Message-State: ALyK8tIXW5WJ7dpmMWiBmCIn0jDP+b4DJhC9JsWST36NsNVKcPBUrnF4A8HStPFKWhWQeBbE X-Received: by 10.98.31.140 with SMTP id l12mr25056350pfj.51.1466474061945; Mon, 20 Jun 2016 18:54:21 -0700 (PDT) Received: from eswierk-sc.localdomain (67-207-112-138.static.wiline.com. [67.207.112.138]) by smtp.gmail.com with ESMTPSA id i8sm91219159pao.26.2016.06.20.18.54.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 20 Jun 2016 18:54:21 -0700 (PDT) From: Ed Swierk To: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Date: Mon, 20 Jun 2016 18:54:02 -0700 Message-Id: <1466474042-110773-6-git-send-email-eswierk@skyportsystems.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1466474042-110773-1-git-send-email-eswierk@skyportsystems.com> References: <1465610107-87762-1-git-send-email-eswierk@skyportsystems.com> <1466474042-110773-1-git-send-email-eswierk@skyportsystems.com> X-Headers-End: 1bFAtX-0000VW-MR Subject: [tpmdd-devel] [PATCH v7 5/5] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup X-BeenThere: tpmdd-devel@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: Tpm Device Driver maintainance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: tpmdd-devel-bounces@lists.sourceforge.net X-Virus-Scanned: ClamAV using ClamSMTP The STMicro ST19NP18-TPM sometimes takes much longer to execute commands than it reports in its capabilities. For example, command 186 (TPM_FlushSpecific) has been observed to take 14560 msec to complete, far longer than the 3000 msec limit for "short" commands reported by the chip. The behavior has also been seen with command 101 (TPM_GetCapability). Worse, when the tpm_tis driver attempts to cancel the current command (by writing commandReady = 1 to TPM_STS_x), the chip locks up completely, returning all-1s from all memory-mapped register reads. The lockup can be cleared only by resetting the system. The occurrence of this excessive command duration depends on the sequence of commands preceding it. One sequence is creating at least 2 new keys via TPM_CreateWrapKey, then letting the TPM idle for at least 30 seconds, then loading a key via TPM_LoadKey2. The next TPM_FlushSpecific occasionally takes tens of seconds to complete. Another sequence is creating many keys in a row without pause. The TPM_CreateWrapKey operation gets much slower after the first few iterations, as one would expect when the pool of precomputed keys is exhausted. Then after a 35-second pause, the same TPM_LoadKey2 followed by TPM_FlushSpecific sequence triggers the behavior. Our working theory is that this older TPM sometimes pauses to precompute keys, which modern chips implement as a background process. Without access to the chip's implementation details it's impossible to know whether any commands are immune to being blocked by this process. So it seems safest to ignore the chip's reported command durations, and use a value much higher than any observed duration, like 180 sec (which is the duration this chip reports for "long" commands). Signed-off-by: Ed Swierk --- drivers/char/tpm/tpm_tis.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index caf7278..8355b45 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -485,6 +485,12 @@ static void tpm_tis_update_timeouts(struct tpm_chip *chip) chip->vendor.timeout_d = msecs_to_jiffies(TIS_SHORT_TIMEOUT); chip->vendor.timeout_adjusted = true; break; + case 0x0000104a: /* STMicro ST19NP18-TPM */ + chip->vendor.duration[TPM_SHORT] = 180 * HZ; + chip->vendor.duration[TPM_MEDIUM] = 180 * HZ; + chip->vendor.duration[TPM_LONG] = 180 * HZ; + chip->vendor.duration_adjusted = true; + break; } }