| Message ID | 1473289262-9395-1-git-send-email-tomas.winkler@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 08, 2016 at 02:01:02AM +0300, Tomas Winkler wrote: > Fixes the warning: > drivers/char/tpm/tpm_tis_core.c:443:7: warning: variable ‘itpm’ set but > not used [-Wunused-but-set-variable] > bool itpm; > ^~~~ > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko ------------------------------------------------------------------------------
On Thu, Sep 08, 2016 at 01:15:04PM +0300, Jarkko Sakkinen wrote: > On Thu, Sep 08, 2016 at 02:01:02AM +0300, Tomas Winkler wrote: > > Fixes the warning: > > drivers/char/tpm/tpm_tis_core.c:443:7: warning: variable ‘itpm’ set but > > not used [-Wunused-but-set-variable] > > bool itpm; > > ^~~~ > > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > > Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Applied to master. I will include this to my 4.9 pull. /Jarkko ------------------------------------------------------------------------------
diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index 236015103164..cf6fd13cd1d1 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -440,7 +440,6 @@ static int probe_itpm(struct tpm_chip *chip) 0x00, 0x00, 0x00, 0xf1 }; size_t len = sizeof(cmd_getticks); - bool itpm; u16 vendor; rc = tpm_tis_read16(priv, TPM_DID_VID(0), &vendor); @@ -451,8 +450,6 @@ static int probe_itpm(struct tpm_chip *chip) if (vendor != TPM_VID_INTEL) return 0; - itpm = false; - rc = tpm_tis_send_data(chip, cmd_getticks, len); if (rc == 0) goto out; @@ -460,8 +457,6 @@ static int probe_itpm(struct tpm_chip *chip) tpm_tis_ready(chip); release_locality(chip, priv->locality, 0); - itpm = true; - rc = tpm_tis_send_data(chip, cmd_getticks, len); if (rc == 0) { dev_info(&chip->dev, "Detected an iTPM.\n");
Fixes the warning: drivers/char/tpm/tpm_tis_core.c:443:7: warning: variable ‘itpm’ set but not used [-Wunused-but-set-variable] bool itpm; ^~~~ Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> --- V2: fix typos in the subject drivers/char/tpm/tpm_tis_core.c | 5 ----- 1 file changed, 5 deletions(-)