| Message ID | 1479117656-12403-3-git-send-email-nayna@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Nov 14, 2016 at 05:00:49AM -0500, Nayna Jain wrote: > checkpatch.pl flags warning for symbolic permissions and suggests > to replace with octal value. > > This patch changes securityfs pseudo files permission > to octal values in tpm_bios_log_setup(). > > Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko > --- > drivers/char/tpm/tpm_eventlog.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_eventlog.c b/drivers/char/tpm/tpm_eventlog.c > index 42b49c4..9467e31 100644 > --- a/drivers/char/tpm/tpm_eventlog.c > +++ b/drivers/char/tpm/tpm_eventlog.c > @@ -378,7 +378,7 @@ struct dentry **tpm_bios_log_setup(const char *name) > > bin_file = > securityfs_create_file("binary_bios_measurements", > - S_IRUSR | S_IRGRP, tpm_dir, > + 0440, tpm_dir, > (void *)&tpm_binary_b_measurements_seqops, > &tpm_bios_measurements_ops); > if (is_bad(bin_file)) > @@ -386,7 +386,7 @@ struct dentry **tpm_bios_log_setup(const char *name) > > ascii_file = > securityfs_create_file("ascii_bios_measurements", > - S_IRUSR | S_IRGRP, tpm_dir, > + 0440, tpm_dir, > (void *)&tpm_ascii_b_measurements_seqops, > &tpm_bios_measurements_ops); > if (is_bad(ascii_file)) > -- > 2.5.0 > ------------------------------------------------------------------------------
On Mon, Nov 14, 2016 at 05:00:49AM -0500, Nayna Jain wrote: > checkpatch.pl flags warning for symbolic permissions and suggests > to replace with octal value. > > This patch changes securityfs pseudo files permission > to octal values in tpm_bios_log_setup(). > > Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko > --- > drivers/char/tpm/tpm_eventlog.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_eventlog.c b/drivers/char/tpm/tpm_eventlog.c > index 42b49c4..9467e31 100644 > --- a/drivers/char/tpm/tpm_eventlog.c > +++ b/drivers/char/tpm/tpm_eventlog.c > @@ -378,7 +378,7 @@ struct dentry **tpm_bios_log_setup(const char *name) > > bin_file = > securityfs_create_file("binary_bios_measurements", > - S_IRUSR | S_IRGRP, tpm_dir, > + 0440, tpm_dir, > (void *)&tpm_binary_b_measurements_seqops, > &tpm_bios_measurements_ops); > if (is_bad(bin_file)) > @@ -386,7 +386,7 @@ struct dentry **tpm_bios_log_setup(const char *name) > > ascii_file = > securityfs_create_file("ascii_bios_measurements", > - S_IRUSR | S_IRGRP, tpm_dir, > + 0440, tpm_dir, > (void *)&tpm_ascii_b_measurements_seqops, > &tpm_bios_measurements_ops); > if (is_bad(ascii_file)) > -- > 2.5.0 > ------------------------------------------------------------------------------
On Mon, Nov 14, 2016 at 02:21:14PM -0800, Jarkko Sakkinen wrote: > On Mon, Nov 14, 2016 at 05:00:49AM -0500, Nayna Jain wrote: > > checkpatch.pl flags warning for symbolic permissions and suggests > > to replace with octal value. > > > > This patch changes securityfs pseudo files permission > > to octal values in tpm_bios_log_setup(). > > > > Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> /Jarkko ------------------------------------------------------------------------------
diff --git a/drivers/char/tpm/tpm_eventlog.c b/drivers/char/tpm/tpm_eventlog.c index 42b49c4..9467e31 100644 --- a/drivers/char/tpm/tpm_eventlog.c +++ b/drivers/char/tpm/tpm_eventlog.c @@ -378,7 +378,7 @@ struct dentry **tpm_bios_log_setup(const char *name) bin_file = securityfs_create_file("binary_bios_measurements", - S_IRUSR | S_IRGRP, tpm_dir, + 0440, tpm_dir, (void *)&tpm_binary_b_measurements_seqops, &tpm_bios_measurements_ops); if (is_bad(bin_file)) @@ -386,7 +386,7 @@ struct dentry **tpm_bios_log_setup(const char *name) ascii_file = securityfs_create_file("ascii_bios_measurements", - S_IRUSR | S_IRGRP, tpm_dir, + 0440, tpm_dir, (void *)&tpm_ascii_b_measurements_seqops, &tpm_bios_measurements_ops); if (is_bad(ascii_file))
checkpatch.pl flags warning for symbolic permissions and suggests to replace with octal value. This patch changes securityfs pseudo files permission to octal values in tpm_bios_log_setup(). Signed-off-by: Nayna Jain <nayna@linux.vnet.ibm.com> --- drivers/char/tpm/tpm_eventlog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)