diff mbox

[V9fs-developer,3/3,net/9p] VirtIO can transfer VIRTQUEUE_NUM of pages.

Message ID 1309475921-12171-3-git-send-email-jvrao@linux.vnet.ibm.com (mailing list archive)
State Accepted, archived
Delegated to: Eric Van Hensbergen
Headers show

Commit Message

jvrao June 30, 2011, 11:18 p.m. UTC
Signed-off-by: Venkateswararao Jujjuri "<jvrao@linux.vnet.ibm.com>
---
 net/9p/trans_virtio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Aneesh Kumar K.V July 1, 2011, 11:24 a.m. UTC | #1
On Thu, 30 Jun 2011 16:18:41 -0700, "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com> wrote:
> Signed-off-by: Venkateswararao Jujjuri "<jvrao@linux.vnet.ibm.com>
> ---
>  net/9p/trans_virtio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
> index 0ec5423..175b513 100644
> --- a/net/9p/trans_virtio.c
> +++ b/net/9p/trans_virtio.c
> @@ -592,7 +592,7 @@ static struct p9_trans_module p9_virtio_trans = {
>  	.close = p9_virtio_close,
>  	.request = p9_virtio_request,
>  	.cancel = p9_virtio_cancel,
> -	.maxsize = PAGE_SIZE*16,
> +	.maxsize = PAGE_SIZE*VIRTQUEUE_NUM,
>  	.pref = P9_TRANS_PREF_PAYLOAD_SEP,
>  	.def = 0,
>  	.owner = THIS_MODULE,

Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

I guess we also need to make sure Qemu server also set the msize to this
value so that we can operate with large msize ?

-aneesh

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
jvrao July 1, 2011, 4:27 p.m. UTC | #2
On 07/01/2011 04:24 AM, Aneesh Kumar K.V wrote:
> On Thu, 30 Jun 2011 16:18:41 -0700, "Venkateswararao Jujjuri (JV)"<jvrao@linux.vnet.ibm.com>  wrote:
>> Signed-off-by: Venkateswararao Jujjuri "<jvrao@linux.vnet.ibm.com>
>> ---
>>   net/9p/trans_virtio.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
>> index 0ec5423..175b513 100644
>> --- a/net/9p/trans_virtio.c
>> +++ b/net/9p/trans_virtio.c
>> @@ -592,7 +592,7 @@ static struct p9_trans_module p9_virtio_trans = {
>>   	.close = p9_virtio_close,
>>   	.request = p9_virtio_request,
>>   	.cancel = p9_virtio_cancel,
>> -	.maxsize = PAGE_SIZE*16,
>> +	.maxsize = PAGE_SIZE*VIRTQUEUE_NUM,
>>   	.pref = P9_TRANS_PREF_PAYLOAD_SEP,
>>   	.def = 0,
>>   	.owner = THIS_MODULE,
> Reviewed-by: Aneesh Kumar K.V<aneesh.kumar@linux.vnet.ibm.com>
>
> I guess we also need to make sure Qemu server also set the msize to this
> value so that we can operate with large msize ?
QEMU server acks whatever client requests/sends through TVERSION.
Apart from this we need a broader policy on the whole msize on QEMU
to validate the client's proposal before blindly accepting it.

- JV
> -aneesh


------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
diff mbox

Patch

diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
index 0ec5423..175b513 100644
--- a/net/9p/trans_virtio.c
+++ b/net/9p/trans_virtio.c
@@ -592,7 +592,7 @@  static struct p9_trans_module p9_virtio_trans = {
 	.close = p9_virtio_close,
 	.request = p9_virtio_request,
 	.cancel = p9_virtio_cancel,
-	.maxsize = PAGE_SIZE*16,
+	.maxsize = PAGE_SIZE*VIRTQUEUE_NUM,
 	.pref = P9_TRANS_PREF_PAYLOAD_SEP,
 	.def = 0,
 	.owner = THIS_MODULE,