diff mbox

[V9fs-developer,-V2,1/2] net/9p: Remove structure not used in the code

Message ID 1310028244-18451-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com (mailing list archive)
State Accepted, archived
Delegated to: Eric Van Hensbergen
Headers show

Commit Message

Aneesh Kumar K.V July 7, 2011, 8:44 a.m. UTC
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 include/net/9p/9p.h |  183 ++-------------------------------------------------
 1 files changed, 5 insertions(+), 178 deletions(-)

Comments

Aneesh Kumar K.V July 10, 2011, 6:01 p.m. UTC | #1
How do we take this patch ? Patch 2 have a dependency on patch 1
otherwise tools/kvm build will fail. So may Eric can ack this patch and
this can go via tools/kvm tree ?


On Thu,  7 Jul 2011 14:14:03 +0530, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>  include/net/9p/9p.h |  183 ++-------------------------------------------------
>  1 files changed, 5 insertions(+), 178 deletions(-)
> 
> diff --git a/include/net/9p/9p.h b/include/net/9p/9p.h
> index 008711e..fcb8473 100644
> --- a/include/net/9p/9p.h
> +++ b/include/net/9p/9p.h
> @@ -321,21 +321,6 @@ enum p9_qid_t {
>  #define P9_READDIRHDRSZ	24
> 
>  /**
> - * struct p9_str - length prefixed string type
> - * @len: length of the string
> - * @str: the string
> - *
> - * The protocol uses length prefixed strings for all
> - * string data, so we replicate that for our internal
> - * string members.
> - */
> -
> -struct p9_str {
> -	u16 len;
> -	char *str;
> -};
> -
> -/**
>   * struct p9_qid - file system entity information
>   * @type: 8-bit type &p9_qid_t
>   * @version: 16-bit monotonically incrementing version number
> @@ -371,11 +356,11 @@ struct p9_qid {
>   * @atime: Last access/read time
>   * @mtime: Last modify/write time
>   * @length: file length
> - * @name: last element of path (aka filename) in type &p9_str
> - * @uid: owner name in type &p9_str
> - * @gid: group owner in type &p9_str
> - * @muid: last modifier in type &p9_str
> - * @extension: area used to encode extended UNIX support in type &p9_str
> + * @name: last element of path (aka filename)
> + * @uid: owner name
> + * @gid: group owner
> + * @muid: last modifier
> + * @extension: area used to encode extended UNIX support
>   * @n_uid: numeric user id of owner (part of 9p2000.u extension)
>   * @n_gid: numeric group id (part of 9p2000.u extension)
>   * @n_muid: numeric user id of laster modifier (part of 9p2000.u extension)
> @@ -512,11 +497,6 @@ struct p9_getlock {
>  	char *client_id;
>  };
> 
> -/* Structures for Protocol Operations */
> -struct p9_tstatfs {
> -	u32 fid;
> -};
> -
>  struct p9_rstatfs {
>  	u32 type;
>  	u32 bsize;
> @@ -529,159 +509,6 @@ struct p9_rstatfs {
>  	u32 namelen;
>  };
> 
> -struct p9_trename {
> -	u32 fid;
> -	u32 newdirfid;
> -	struct p9_str name;
> -};
> -
> -struct p9_rrename {
> -};
> -
> -struct p9_tversion {
> -	u32 msize;
> -	struct p9_str version;
> -};
> -
> -struct p9_rversion {
> -	u32 msize;
> -	struct p9_str version;
> -};
> -
> -struct p9_tauth {
> -	u32 afid;
> -	struct p9_str uname;
> -	struct p9_str aname;
> -	u32 n_uname;		/* 9P2000.u extensions */
> -};
> -
> -struct p9_rauth {
> -	struct p9_qid qid;
> -};
> -
> -struct p9_rerror {
> -	struct p9_str error;
> -	u32 errno;		/* 9p2000.u extension */
> -};
> -
> -struct p9_tflush {
> -	u16 oldtag;
> -};
> -
> -struct p9_rflush {
> -};
> -
> -struct p9_tattach {
> -	u32 fid;
> -	u32 afid;
> -	struct p9_str uname;
> -	struct p9_str aname;
> -	u32 n_uname;		/* 9P2000.u extensions */
> -};
> -
> -struct p9_rattach {
> -	struct p9_qid qid;
> -};
> -
> -struct p9_twalk {
> -	u32 fid;
> -	u32 newfid;
> -	u16 nwname;
> -	struct p9_str wnames[16];
> -};
> -
> -struct p9_rwalk {
> -	u16 nwqid;
> -	struct p9_qid wqids[16];
> -};
> -
> -struct p9_topen {
> -	u32 fid;
> -	u8 mode;
> -};
> -
> -struct p9_ropen {
> -	struct p9_qid qid;
> -	u32 iounit;
> -};
> -
> -struct p9_tcreate {
> -	u32 fid;
> -	struct p9_str name;
> -	u32 perm;
> -	u8 mode;
> -	struct p9_str extension;
> -};
> -
> -struct p9_rcreate {
> -	struct p9_qid qid;
> -	u32 iounit;
> -};
> -
> -struct p9_tread {
> -	u32 fid;
> -	u64 offset;
> -	u32 count;
> -};
> -
> -struct p9_rread {
> -	u32 count;
> -	u8 *data;
> -};
> -
> -struct p9_twrite {
> -	u32 fid;
> -	u64 offset;
> -	u32 count;
> -	u8 *data;
> -};
> -
> -struct p9_rwrite {
> -	u32 count;
> -};
> -
> -struct p9_treaddir {
> -	u32 fid;
> -	u64 offset;
> -	u32 count;
> -};
> -
> -struct p9_rreaddir {
> -	u32 count;
> -	u8 *data;
> -};
> -
> -
> -struct p9_tclunk {
> -	u32 fid;
> -};
> -
> -struct p9_rclunk {
> -};
> -
> -struct p9_tremove {
> -	u32 fid;
> -};
> -
> -struct p9_rremove {
> -};
> -
> -struct p9_tstat {
> -	u32 fid;
> -};
> -
> -struct p9_rstat {
> -	struct p9_wstat stat;
> -};
> -
> -struct p9_twstat {
> -	u32 fid;
> -	struct p9_wstat stat;
> -};
> -
> -struct p9_rwstat {
> -};
> -
>  /**
>   * struct p9_fcall - primary packet structure
>   * @size: prefixed length of the structure
> -- 
> 1.7.4.1
> 

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
Pekka Enberg July 10, 2011, 6:18 p.m. UTC | #2
On Sun, 10 Jul 2011, Aneesh Kumar K.V wrote:
> How do we take this patch ? Patch 2 have a dependency on patch 1
> otherwise tools/kvm build will fail. So may Eric can ack this patch and
> this can go via tools/kvm tree ?

Sure, we can do that but I'm not applying patches outside of tools/kvm 
without explicit agreement from proper maintainers.

 			Pekka

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
Eric Van Hensbergen July 12, 2011, 1:01 p.m. UTC | #3
On Thu, Jul 7, 2011 at 3:44 AM, Aneesh Kumar K.V
<aneesh.kumar@linux.vnet.ibm.com> wrote:
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>

> ---
>  include/net/9p/9p.h |  183 ++-------------------------------------------------
>  1 files changed, 5 insertions(+), 178 deletions(-)
>
> diff --git a/include/net/9p/9p.h b/include/net/9p/9p.h
> index 008711e..fcb8473 100644
> --- a/include/net/9p/9p.h
> +++ b/include/net/9p/9p.h
> @@ -321,21 +321,6 @@ enum p9_qid_t {
>  #define P9_READDIRHDRSZ        24
>
>  /**
> - * struct p9_str - length prefixed string type
> - * @len: length of the string
> - * @str: the string
> - *
> - * The protocol uses length prefixed strings for all
> - * string data, so we replicate that for our internal
> - * string members.
> - */
> -
> -struct p9_str {
> -       u16 len;
> -       char *str;
> -};
> -
> -/**
>  * struct p9_qid - file system entity information
>  * @type: 8-bit type &p9_qid_t
>  * @version: 16-bit monotonically incrementing version number
> @@ -371,11 +356,11 @@ struct p9_qid {
>  * @atime: Last access/read time
>  * @mtime: Last modify/write time
>  * @length: file length
> - * @name: last element of path (aka filename) in type &p9_str
> - * @uid: owner name in type &p9_str
> - * @gid: group owner in type &p9_str
> - * @muid: last modifier in type &p9_str
> - * @extension: area used to encode extended UNIX support in type &p9_str
> + * @name: last element of path (aka filename)
> + * @uid: owner name
> + * @gid: group owner
> + * @muid: last modifier
> + * @extension: area used to encode extended UNIX support
>  * @n_uid: numeric user id of owner (part of 9p2000.u extension)
>  * @n_gid: numeric group id (part of 9p2000.u extension)
>  * @n_muid: numeric user id of laster modifier (part of 9p2000.u extension)
> @@ -512,11 +497,6 @@ struct p9_getlock {
>        char *client_id;
>  };
>
> -/* Structures for Protocol Operations */
> -struct p9_tstatfs {
> -       u32 fid;
> -};
> -
>  struct p9_rstatfs {
>        u32 type;
>        u32 bsize;
> @@ -529,159 +509,6 @@ struct p9_rstatfs {
>        u32 namelen;
>  };
>
> -struct p9_trename {
> -       u32 fid;
> -       u32 newdirfid;
> -       struct p9_str name;
> -};
> -
> -struct p9_rrename {
> -};
> -
> -struct p9_tversion {
> -       u32 msize;
> -       struct p9_str version;
> -};
> -
> -struct p9_rversion {
> -       u32 msize;
> -       struct p9_str version;
> -};
> -
> -struct p9_tauth {
> -       u32 afid;
> -       struct p9_str uname;
> -       struct p9_str aname;
> -       u32 n_uname;            /* 9P2000.u extensions */
> -};
> -
> -struct p9_rauth {
> -       struct p9_qid qid;
> -};
> -
> -struct p9_rerror {
> -       struct p9_str error;
> -       u32 errno;              /* 9p2000.u extension */
> -};
> -
> -struct p9_tflush {
> -       u16 oldtag;
> -};
> -
> -struct p9_rflush {
> -};
> -
> -struct p9_tattach {
> -       u32 fid;
> -       u32 afid;
> -       struct p9_str uname;
> -       struct p9_str aname;
> -       u32 n_uname;            /* 9P2000.u extensions */
> -};
> -
> -struct p9_rattach {
> -       struct p9_qid qid;
> -};
> -
> -struct p9_twalk {
> -       u32 fid;
> -       u32 newfid;
> -       u16 nwname;
> -       struct p9_str wnames[16];
> -};
> -
> -struct p9_rwalk {
> -       u16 nwqid;
> -       struct p9_qid wqids[16];
> -};
> -
> -struct p9_topen {
> -       u32 fid;
> -       u8 mode;
> -};
> -
> -struct p9_ropen {
> -       struct p9_qid qid;
> -       u32 iounit;
> -};
> -
> -struct p9_tcreate {
> -       u32 fid;
> -       struct p9_str name;
> -       u32 perm;
> -       u8 mode;
> -       struct p9_str extension;
> -};
> -
> -struct p9_rcreate {
> -       struct p9_qid qid;
> -       u32 iounit;
> -};
> -
> -struct p9_tread {
> -       u32 fid;
> -       u64 offset;
> -       u32 count;
> -};
> -
> -struct p9_rread {
> -       u32 count;
> -       u8 *data;
> -};
> -
> -struct p9_twrite {
> -       u32 fid;
> -       u64 offset;
> -       u32 count;
> -       u8 *data;
> -};
> -
> -struct p9_rwrite {
> -       u32 count;
> -};
> -
> -struct p9_treaddir {
> -       u32 fid;
> -       u64 offset;
> -       u32 count;
> -};
> -
> -struct p9_rreaddir {
> -       u32 count;
> -       u8 *data;
> -};
> -
> -
> -struct p9_tclunk {
> -       u32 fid;
> -};
> -
> -struct p9_rclunk {
> -};
> -
> -struct p9_tremove {
> -       u32 fid;
> -};
> -
> -struct p9_rremove {
> -};
> -
> -struct p9_tstat {
> -       u32 fid;
> -};
> -
> -struct p9_rstat {
> -       struct p9_wstat stat;
> -};
> -
> -struct p9_twstat {
> -       u32 fid;
> -       struct p9_wstat stat;
> -};
> -
> -struct p9_rwstat {
> -};
> -
>  /**
>  * struct p9_fcall - primary packet structure
>  * @size: prefixed length of the structure
> --
> 1.7.4.1
>
>
> ------------------------------------------------------------------------------
> All of the data generated in your IT infrastructure is seriously valuable.
> Why? It contains a definitive record of application performance, security
> threats, fraudulent activity, and more. Splunk takes this data and makes
> sense of it. IT sense. And common sense.
> http://p.sf.net/sfu/splunk-d2d-c2
> _______________________________________________
> V9fs-developer mailing list
> V9fs-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/v9fs-developer
>

------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security 
threats, fraudulent activity, and more. Splunk takes this data and makes 
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
Pekka Enberg July 13, 2011, 10:05 a.m. UTC | #4
On 7/12/11 4:01 PM, Eric Van Hensbergen wrote:
> On Thu, Jul 7, 2011 at 3:44 AM, Aneesh Kumar K.V
> <aneesh.kumar@linux.vnet.ibm.com>  wrote:
>> Signed-off-by: Aneesh Kumar K.V<aneesh.kumar@linux.vnet.ibm.com>
> Signed-off-by: Eric Van Hensbergen<ericvh@gmail.com>

Thanks! I'll pick this up in my KVM tool tree.

------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric 
Ries, the creator of the Lean Startup Methodology on "Lean Startup 
Secrets Revealed." This video shows you how to validate your ideas, 
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
diff mbox

Patch

diff --git a/include/net/9p/9p.h b/include/net/9p/9p.h
index 008711e..fcb8473 100644
--- a/include/net/9p/9p.h
+++ b/include/net/9p/9p.h
@@ -321,21 +321,6 @@  enum p9_qid_t {
 #define P9_READDIRHDRSZ	24
 
 /**
- * struct p9_str - length prefixed string type
- * @len: length of the string
- * @str: the string
- *
- * The protocol uses length prefixed strings for all
- * string data, so we replicate that for our internal
- * string members.
- */
-
-struct p9_str {
-	u16 len;
-	char *str;
-};
-
-/**
  * struct p9_qid - file system entity information
  * @type: 8-bit type &p9_qid_t
  * @version: 16-bit monotonically incrementing version number
@@ -371,11 +356,11 @@  struct p9_qid {
  * @atime: Last access/read time
  * @mtime: Last modify/write time
  * @length: file length
- * @name: last element of path (aka filename) in type &p9_str
- * @uid: owner name in type &p9_str
- * @gid: group owner in type &p9_str
- * @muid: last modifier in type &p9_str
- * @extension: area used to encode extended UNIX support in type &p9_str
+ * @name: last element of path (aka filename)
+ * @uid: owner name
+ * @gid: group owner
+ * @muid: last modifier
+ * @extension: area used to encode extended UNIX support
  * @n_uid: numeric user id of owner (part of 9p2000.u extension)
  * @n_gid: numeric group id (part of 9p2000.u extension)
  * @n_muid: numeric user id of laster modifier (part of 9p2000.u extension)
@@ -512,11 +497,6 @@  struct p9_getlock {
 	char *client_id;
 };
 
-/* Structures for Protocol Operations */
-struct p9_tstatfs {
-	u32 fid;
-};
-
 struct p9_rstatfs {
 	u32 type;
 	u32 bsize;
@@ -529,159 +509,6 @@  struct p9_rstatfs {
 	u32 namelen;
 };
 
-struct p9_trename {
-	u32 fid;
-	u32 newdirfid;
-	struct p9_str name;
-};
-
-struct p9_rrename {
-};
-
-struct p9_tversion {
-	u32 msize;
-	struct p9_str version;
-};
-
-struct p9_rversion {
-	u32 msize;
-	struct p9_str version;
-};
-
-struct p9_tauth {
-	u32 afid;
-	struct p9_str uname;
-	struct p9_str aname;
-	u32 n_uname;		/* 9P2000.u extensions */
-};
-
-struct p9_rauth {
-	struct p9_qid qid;
-};
-
-struct p9_rerror {
-	struct p9_str error;
-	u32 errno;		/* 9p2000.u extension */
-};
-
-struct p9_tflush {
-	u16 oldtag;
-};
-
-struct p9_rflush {
-};
-
-struct p9_tattach {
-	u32 fid;
-	u32 afid;
-	struct p9_str uname;
-	struct p9_str aname;
-	u32 n_uname;		/* 9P2000.u extensions */
-};
-
-struct p9_rattach {
-	struct p9_qid qid;
-};
-
-struct p9_twalk {
-	u32 fid;
-	u32 newfid;
-	u16 nwname;
-	struct p9_str wnames[16];
-};
-
-struct p9_rwalk {
-	u16 nwqid;
-	struct p9_qid wqids[16];
-};
-
-struct p9_topen {
-	u32 fid;
-	u8 mode;
-};
-
-struct p9_ropen {
-	struct p9_qid qid;
-	u32 iounit;
-};
-
-struct p9_tcreate {
-	u32 fid;
-	struct p9_str name;
-	u32 perm;
-	u8 mode;
-	struct p9_str extension;
-};
-
-struct p9_rcreate {
-	struct p9_qid qid;
-	u32 iounit;
-};
-
-struct p9_tread {
-	u32 fid;
-	u64 offset;
-	u32 count;
-};
-
-struct p9_rread {
-	u32 count;
-	u8 *data;
-};
-
-struct p9_twrite {
-	u32 fid;
-	u64 offset;
-	u32 count;
-	u8 *data;
-};
-
-struct p9_rwrite {
-	u32 count;
-};
-
-struct p9_treaddir {
-	u32 fid;
-	u64 offset;
-	u32 count;
-};
-
-struct p9_rreaddir {
-	u32 count;
-	u8 *data;
-};
-
-
-struct p9_tclunk {
-	u32 fid;
-};
-
-struct p9_rclunk {
-};
-
-struct p9_tremove {
-	u32 fid;
-};
-
-struct p9_rremove {
-};
-
-struct p9_tstat {
-	u32 fid;
-};
-
-struct p9_rstat {
-	struct p9_wstat stat;
-};
-
-struct p9_twstat {
-	u32 fid;
-	struct p9_wstat stat;
-};
-
-struct p9_rwstat {
-};
-
 /**
  * struct p9_fcall - primary packet structure
  * @size: prefixed length of the structure