From patchwork Mon Jul 17 16:29:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Van Hensbergen X-Patchwork-Id: 13315993 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75435253DE for ; Mon, 17 Jul 2023 16:29:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34661C433C8; Mon, 17 Jul 2023 16:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689611345; bh=HtOElUNyoZNBTq+YJJPGA6QUAQwhzK9Ts0x7WmL3Ogs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=hkI6fdXx+442oIfRvhPZtlwLRAzVGAH2TUWRkO0HgzibV3xnV7FtN3EEfECZKv1BD kotg7kLZd/xdqnt1cVqDuIvspSGamAURkn7SQFzKVPlt6a1ar2/QvMHVyIZlbWIci+ /XvOh+MAV8tKYulIdNsNARGdQWzRPrZ27FzsUQi8DTZE5gpFHlN0onNHE5LHYodRa6 2xddGuY49CzDvV0U5jomPjtnLsV3EbIWfYtg/lzuNk/AfLU/q6acEdXlMd8ZbFgWme C9sbZPEjrOHjPWg8T4T/tSCB7VgHsTJtDa47HHRSbaFdHPwiwA1QoIhKKMMe0Ys/vA z/7BQJS0AvIRQ== From: Eric Van Hensbergen Date: Mon, 17 Jul 2023 16:29:00 +0000 Subject: [PATCH 1/3] fs/9p: remove unecessary and overrestrictive check Precedence: bulk X-Mailing-List: v9fs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230716-fixes-overly-restrictive-mmap-v1-1-0683b283b932@kernel.org> References: <20230716-fixes-overly-restrictive-mmap-v1-0-0683b283b932@kernel.org> In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v1-0-0683b283b932@kernel.org> To: Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Robert Schwebel , Eric Van Hensbergen X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=733; i=ericvh@kernel.org; h=from:subject:message-id; bh=HtOElUNyoZNBTq+YJJPGA6QUAQwhzK9Ts0x7WmL3Ogs=; b=owEBbQKS/ZANAwAKAYj/1ftKX/+YAcsmYgBktWxPX9pZef4TUTigWeU3IyymFufia++0mC0aA cCwpcYpqxaJAjMEAAEKAB0WIQSWlvDRlqWQmKTK0VGI/9X7Sl//mAUCZLVsTwAKCRCI/9X7Sl// mHmSD/9B8p6xF2EFjQMbCX6wfXlqLY72QBgwxjLmcSJNov5L0lYLkg0kzZxkqX9ayV24SkeXDww T7XYiKG5Z9fkofZ/MqLNgOOIxGOHu/e6XKt4e5NQ/KApJecLM0NdYGGbw3pLY7L9kfx6on+CCvT SBUcguO7Jra30yIewz5WLmc1S8kDQSPQ3qRz2MYOczeI+f7s7Bp1kQeh287QJOpbPNhyIpoqsja F5p3ggxbSlSzeoWj37gouzpQO8ETr7LLELU4UAr7VDXG2D4SJ08hftpnySiQN/ZSu5xrPC4fGlI CcHVa53YvOdfBSF7YDEaMonpmp5TxxzElDDoe6n7LHKIrB+n5tun/sN674PbHLmA6GLnDXaJQZ0 MJ8OCc3dq5/nvSQQ2TeGOGrYWlB3elTKCMKwiqsT/eEM6gDoJv1OMcd5DJn839LtHPILc0wFZX4 +81bV3bUvPLSiZsYBlNOyTWuyKEgcUDnoRPfP6tzzMyI5dIABO0zS280WBixurkxoE2PRmqvR1a YRzotcC3Y/YDeUQ9Sdr6wyAO4Nu/BDffvU5ibl+v/8/1UgtmMnSpVzl7nrxUIzx/6chKYOb7lqv pRHW8T/ltnnL5DF3PAEpXxc0tXMov5H+ro6DVNzlpjWWpye24gFmWcJ252FUwQENgQJmEyOFu/i MRll+XH93fvfmWA== X-Developer-Key: i=ericvh@kernel.org; a=openpgp; fpr=9696F0D196A59098A4CAD15188FFD5FB4A5FFF98 This eliminates a check for shared that was overrestrictive and duplicated a check in generic_file_readonly_mmap. Signed-off-by: Eric Van Hensbergen Reviewed-by: Dominique Martinet Reviewed-by: Christian Schoenebeck --- fs/9p/vfs_file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c index 2996fb00387fa..bda3abd6646b8 100644 --- a/fs/9p/vfs_file.c +++ b/fs/9p/vfs_file.c @@ -506,8 +506,6 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma) if (!(v9ses->cache & CACHE_WRITEBACK)) { p9_debug(P9_DEBUG_CACHE, "(no mmap mode)"); - if (vma->vm_flags & VM_MAYSHARE) - return -ENODEV; invalidate_inode_pages2(filp->f_mapping); return generic_file_readonly_mmap(filp, vma); }