From patchwork Wed Jul 19 15:17:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Van Hensbergen X-Patchwork-Id: 13319111 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC5E1156CA for ; Wed, 19 Jul 2023 15:17:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77B2EC433CA; Wed, 19 Jul 2023 15:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689779841; bh=WUnkwoYUUaeSflcgEirZoVzc0KTIoUWAOUey/F0595E=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=J2fQqp+fG2a9bG2AbvMG+1AquX/HeauPeLpjDo/QiW2tWytYlMZTaDeYO1f1e2GCn cODJeQFzCtEeVP4k6v8KdsFloyH0ZtKW+hcvV0iPaKsmY6nLm5ZszYMBvrD4pGIQWA M7F3ODvF5ZCTp/wu6rShp4KRjVwBZHUTcGR7tNMIkDHlJUArUgqsszYvpW+4S1zc2s j7eBVU/2wGuHRKlO19C9mVf2/xOYN3P2SqYah8EsFj8lDZpWfF5sFw3lo+cB/KOQcY FgnlvPtaKFaA/DNBcEzwkl8gXGUXGqjGVsHBK3jRbcE0zg1B36AhJbhUHfmls3/ehD hVvGwULqQUo2w== From: Eric Van Hensbergen Date: Wed, 19 Jul 2023 15:17:05 +0000 Subject: [PATCH v3 1/4] fs/9p: remove unnecessary and overrestrictive check Precedence: bulk X-Mailing-List: v9fs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230716-fixes-overly-restrictive-mmap-v3-1-769791f474fd@kernel.org> References: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> To: Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, stable@vger.kernel.org, Robert Schwebel , Eric Van Hensbergen X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1121; i=ericvh@kernel.org; h=from:subject:message-id; bh=WUnkwoYUUaeSflcgEirZoVzc0KTIoUWAOUey/F0595E=; b=owEBbQKS/ZANAwAKAYj/1ftKX/+YAcsmYgBkt/5+sjS/J2eXctdnFkVSGorDfItoESVfVnLlO u1TSResKW+JAjMEAAEKAB0WIQSWlvDRlqWQmKTK0VGI/9X7Sl//mAUCZLf+fgAKCRCI/9X7Sl// mKnlD/9gTDICEgt4oNIktJwJ54LppB/+HdDJ3lrDEyTHtvDiG67S5Ch9+XTOM4+RwN6L86jYnLK Mybtaze2WRW1BDBy9X3P6zzptBG60z/F8Rue9pVC2VNc02MZ1/2kF9yMLvER2uPy0Wyw1Ngvonm FHAz9Ua5eIsJewOe/h239t7qsZ2SiP3FtBHI2sVk9XWa0LZG4lYwhqCO0gobnXqZ0I+oddvNRWD 020NdzQekYrPGAQ+mHKYbBVvKCUq4IajQEltCOU6bMG1sTkkdMLuFqFunqwmtDKgb5ukgjafXbK jaY4g0kPJc6KefWoyNyskuP840uu957mED2MrA1+e3OuQOI4Tj5bnGqpMHsxYCF7FCPrGdP9nPs Bh9muCBdhe1oiG51rfB/9XQk01XBEGzbnfdc081sL9JYRII2mZSDmg3HsD5+Evb8AHQvaZq5lqx DNz9ayNhuHf0eenYlBFO+U5B4L17SPm596RydHEEs1Dj+vs269WbsPYZyKGFPb8Jd5JIyCZHIMD BLAzp0i/DoeBSft/PlWqci/Og7kTPLpC6iNv1QZwf/QW3cMaW0SR4uPoBKHRt7uPFlMW8PRCvnr oLoqyelLtyD5SR5xvPM+uexBu/25PNQB5PuiJKuZXyH7eHk13rFiMt/Rbfdn1dH+TUzBQtM0pZD SroebqlMCsc6LOg== X-Developer-Key: i=ericvh@kernel.org; a=openpgp; fpr=9696F0D196A59098A4CAD15188FFD5FB4A5FFF98 This eliminates a check for shared that was overrestrictive and duplicated a check in generic_file_readonly_mmap. Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes") Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%2F@pengutronix.de/ Reviewed-by: Dominique Martinet Reviewed-by: Christian Schoenebeck Signed-off-by: Eric Van Hensbergen --- fs/9p/vfs_file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c index 2996fb00387f..9b61b480a9b0 100644 --- a/fs/9p/vfs_file.c +++ b/fs/9p/vfs_file.c @@ -505,9 +505,7 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma) p9_debug(P9_DEBUG_MMAP, "filp :%p\n", filp); if (!(v9ses->cache & CACHE_WRITEBACK)) { - p9_debug(P9_DEBUG_CACHE, "(no mmap mode)"); - if (vma->vm_flags & VM_MAYSHARE) - return -ENODEV; + p9_debug(P9_DEBUG_CACHE, "(read-only mmap mode)"); invalidate_inode_pages2(filp->f_mapping); return generic_file_readonly_mmap(filp, vma); }