diff mbox

[V9fs-developer] net: fix build warning in trans_rdma.c

Message ID 51F7844F.60904@huawei.com (mailing list archive)
State New, archived
Headers show

Commit Message

Xishi Qiu July 30, 2013, 9:15 a.m. UTC
When building v3.11-rc3, I get the following warning:
...
net/9p/trans_rdma.c:594: warning: ‘rdma_cancelled’ defined but not used
...
As the function is not be used, so remove it.

Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
 net/9p/trans_rdma.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)

Comments

Daniel Baluta July 30, 2013, 9:27 a.m. UTC | #1
On Tue, Jul 30, 2013 at 12:15 PM, Xishi Qiu <qiuxishi@huawei.com> wrote:
> When building v3.11-rc3, I get the following warning:
> ...
> net/9p/trans_rdma.c:594: warning: ‘rdma_cancelled’ defined but not used
> ...
> As the function is not be used, so remove it.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
>  net/9p/trans_rdma.c |   11 -----------
>  1 files changed, 0 insertions(+), 11 deletions(-)
>
> diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
> index 928f2bb..8f68df5 100644
> --- a/net/9p/trans_rdma.c
> +++ b/net/9p/trans_rdma.c
> @@ -588,17 +588,6 @@ static int rdma_cancel(struct p9_client *client, struct p9_req_t *req)
>         return 1;
>  }
>
> -/* A request has been fully flushed without a reply.
> - * That means we have posted one buffer in excess.
> - */
> -static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)
> -{
> -       struct p9_trans_rdma *rdma = client->trans;
> -
> -       atomic_inc(&rdma->excess_rc);
> -       return 0;
> -}
> -
>  /**
>   * trans_create_rdma - Transport method for creating atransport instance
>   * @client: client instance

Hi,

This is wrong.

Please check http://comments.gmane.org/gmane.linux.network/276261.

thanks,
Daniel.

------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent 
caught up. So what steps can you take to put your SQL databases under 
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
diff mbox

Patch

diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index 928f2bb..8f68df5 100644
--- a/net/9p/trans_rdma.c
+++ b/net/9p/trans_rdma.c
@@ -588,17 +588,6 @@  static int rdma_cancel(struct p9_client *client, struct p9_req_t *req)
 	return 1;
 }
 
-/* A request has been fully flushed without a reply.
- * That means we have posted one buffer in excess.
- */
-static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)
-{
-	struct p9_trans_rdma *rdma = client->trans;
-
-	atomic_inc(&rdma->excess_rc);
-	return 0;
-}
-
 /**
  * trans_create_rdma - Transport method for creating atransport instance
  * @client: client instance