[MM-PART3,v3,0/9] xen/arm: Provide a generic function to update Xen PT

Message

Julien Grall June 14, 2019, 5:51 p.m. UTC

Hi all,

This is the third part of the boot/memory rework for Xen on Arm. At the
moment, the update to Xen PT is scattered all around mm.c. This makes
difficult to rework Xen memory layout or even ensuring we are following the
Arm Arm properly (and we are not so far!).

This part contains code to provide a generic function to update Xen PT.
While I could have started from scratch, I decided to base the new function
on create_xen_entries() (now renamed xen_pt_update()). This makes slightly
easier to follow the changes.

In this series, the new generic function will only support 3rd-level update
and cannot be used in early boot (i.e because xenheap is not initialized).
This will be extended in follow-up series to allow more use within mm.c.

There are probably some optimization possible around the TLBs flush. I haven't
looked at it so far.

The last two patches of this series is to show how existing callers can be
converted. There are more conversion to come in follow-up series.

For convenience, I provided a branch with all the patches applied base
on staging.

git://xenbits.xen.org/people/julieng/xen-unstable.git branch mm/part3/v3

Cheers,

Julien Grall (9):
  xen/arm: Rework HSCTLR_BASE
  xen/arm: mm: Introduce _PAGE_PRESENT and _PAGE_POPULATE
  xen/arm: mm: Sanity check any update of Xen page tables
  xen/arm: mm: Rework xen_pt_update_entry to avoid use xenmap_operation
  xen/arm: mm: Remove enum xenmap_operation
  xen/arm: mm: Use {, un}map_domain_page() to map/unmap Xen page-tables
  xen/arm: mm: Rework Xen page-tables walk during update
  xen/arm: mm: Don't open-code Xen PT update in {set, clear}_fixmap()
  xen/arm: mm: Remove set_pte_flags_on_range()

 xen/arch/arm/arm32/head.S       |  12 +-
 xen/arch/arm/arm64/head.S       |  10 +-
 xen/arch/arm/mm.c               | 390 +++++++++++++++++++++++++++-------------
 xen/include/asm-arm/page.h      |   9 +-
 xen/include/asm-arm/processor.h |  56 +++++-
 5 files changed, 332 insertions(+), 145 deletions(-)

Comments

Julien Grall June 16, 2019, 8:45 p.m. UTC | #1

Hi,

On 6/14/19 6:51 PM, Julien Grall wrote:
> Julien Grall (9):
>    xen/arm: Rework HSCTLR_BASE
>    xen/arm: mm: Introduce _PAGE_PRESENT and _PAGE_POPULATE
>    xen/arm: mm: Sanity check any update of Xen page tables
>    xen/arm: mm: Rework xen_pt_update_entry to avoid use xenmap_operation
>    xen/arm: mm: Remove enum xenmap_operation
>    xen/arm: mm: Use {, un}map_domain_page() to map/unmap Xen page-tables
>    xen/arm: mm: Rework Xen page-tables walk during update
>    xen/arm: mm: Don't open-code Xen PT update in {set, clear}_fixmap()
>    xen/arm: mm: Remove set_pte_flags_on_range()

They are all committed now. Thank you for the review!

I am still working on the follow-up series. I am hoping to send more 
before XDS.

Cheers,

> 
>   xen/arch/arm/arm32/head.S       |  12 +-
>   xen/arch/arm/arm64/head.S       |  10 +-
>   xen/arch/arm/mm.c               | 390 +++++++++++++++++++++++++++-------------
>   xen/include/asm-arm/page.h      |   9 +-
>   xen/include/asm-arm/processor.h |  56 +++++-
>   5 files changed, 332 insertions(+), 145 deletions(-)
>