[v7,0/5] TEE mediator (and OP-TEE) support in XEN

Message

Volodymyr Babchuk June 19, 2019, 5:53 p.m. UTC

Hello community,

Please find new version of OP-TEE patch series. This is the kind of
follow-up for the previous version, as most of the patches of the
previous version were commited.

This series includes leftovers of the prev. version and three new patches.
One of the new patches adds a way to detect if OP-TEE were build
with virtualization support and two others bear cosmetic changes to
Kconfig files.

This patches also can  be pulled from [4]

==
Changes in v7:
 - 8 of 10 patches were commited
 - New patch "xen/arm: tee: place OP-TEE Kconfig option right after TEE"
   places options in menuconfig in more natural way
 - New patch "xen/arm: optee: check if OP-TEE is virtualization-aware"
   ensues that OP-TEE is virtualization-aware
 - New patch "xen/arm: optee: document OPTEE option in tee/Kconfig"
   add short description of OP-TEE mediator
 - Documentation in "tools/arm: tee: add "tee" option for xl.cfg"
   was updated

===
Changes in v6:
 - Series rebased to staging branch instead of master one.
 - OP-TEE protocol headers was taken from OP-TEE tree instead of
   Linux one
 - Added acked-by tags
 - Fixed (and tested) issue when XEN would not boot if it is build
   with CONFIG_TEE=n

====
Changes in v5:
 - Substantial rework of OP-TEE mediator. Now it tries to return meaningful
   error codes back to the guest.
 - OP-TEE mediator does not use struct cpu_user_regs as a storage for
   parameters and return values when calling OP-TEE. This makes it
   compatbile with requirement from SMCCC.
 - tee=native option replaced with tee=optee
 - Authorship and s-o-b tag reset to my EPAM mail address

====
Changes in v4:
 - Patch "arm: add tee_enabled flag to xen_arch_domainconfig" was
   squashed into "xen/arm: add generic TEE mediator framework"
 - I implemented more elaborate error repoting to a guest. Now guest
   will get meaningful error codes instead of generic
   ARM_SMCCC_ERR_UNKNOWN_FUNCTION.

====
Changes in v3:
 - Use domain flags insted of domctl interface to enable optee for guests
 - Remove patch "libxc: add xc_dom_tee_enable(...) function" because
   of previous change
 - Mediator now stores own context in arch part of struct domain, so
   I removed patch "optee: add domain contexts"

====
Changes in v2:

This is v2 of patch series for OP-TEE mediator support in XEN. Changes from v1:

 - Added domctl interface, so now xl decides what domain should work with TEE
 - Removed XSM support due to change described above
 - Patch with OP-TEE mediator was splited to 7 separate patches
 - Removed patch with call_smccc() function. Now this series depend on
   Julien Grall's series "xen/arm: SMCCC fixup and improvement" [3]

=====
v1:

This is follow for patch series [1]. There was lots of discussions
for that series and I tried to address all of them in this new patchset.

Currently, I had a working solution for OP-TEE virtualization and it is being
upstreamed right now ([2]). So, I think it is a good time to introduce support
in XEN as well.

This series include generic TEE mediator framework and full-scale OP-TEE mediator
which is working with mentioned chages in OP-TEE. So, multiple domains can
work simultaneously with OP-TEE.

I added XSM support, so now it is possible to control which domains can work
with TEEs. Also I changed way how TEE discovery is done. Now  it is very
generic and should support any platform.

[1] https://lists.xenproject.org/archives/html/xen-devel/2017-10/msg01451.html
[2] https://github.com/OP-TEE/optee_os/pull/2370
[3] https://lists.xenproject.org/archives/html/xen-devel/2018-08/msg02138.html
[4] https://github.com/lorc/xen/tree/optee_v7

Volodymyr Babchuk (5):
  tools/arm: tee: add "tee" option for xl.cfg
  tools/arm: optee: create optee firmware node in DT if tee=optee
  xen/arm: tee: place OP-TEE Kconfig option right after TEE
  xen/arm: optee: check if OP-TEE is virtualization-aware
  xen/arm: optee: document OPTEE option in tee/Kconfig

 docs/man/xl.cfg.5.pod.in    | 29 +++++++++++++++++++++++++
 tools/libxl/libxl.h         |  5 +++++
 tools/libxl/libxl_arm.c     | 42 +++++++++++++++++++++++++++++++++++++
 tools/libxl/libxl_types.idl |  6 ++++++
 tools/xl/xl_parse.c         |  9 ++++++++
 xen/arch/arm/Kconfig        |  4 ++--
 xen/arch/arm/tee/Kconfig    |  5 +++++
 xen/arch/arm/tee/optee.c    | 10 +++++++++
 8 files changed, 108 insertions(+), 2 deletions(-)

Comments

Julien Grall Sept. 18, 2019, 1:59 p.m. UTC | #1

Hi,

On 19/06/2019 18:53, Volodymyr Babchuk wrote:
> Volodymyr Babchuk (5):
>    tools/arm: tee: add "tee" option for xl.cfg
>    tools/arm: optee: create optee firmware node in DT if tee=optee
>    xen/arm: tee: place OP-TEE Kconfig option right after TEE
>    xen/arm: optee: check if OP-TEE is virtualization-aware
>    xen/arm: optee: document OPTEE option in tee/Kconfig

This series is now fully committed. Thank you for the contribution!

Cheers,

> 
>   docs/man/xl.cfg.5.pod.in    | 29 +++++++++++++++++++++++++
>   tools/libxl/libxl.h         |  5 +++++
>   tools/libxl/libxl_arm.c     | 42 +++++++++++++++++++++++++++++++++++++
>   tools/libxl/libxl_types.idl |  6 ++++++
>   tools/xl/xl_parse.c         |  9 ++++++++
>   xen/arch/arm/Kconfig        |  4 ++--
>   xen/arch/arm/tee/Kconfig    |  5 +++++
>   xen/arch/arm/tee/optee.c    | 10 +++++++++
>   8 files changed, 108 insertions(+), 2 deletions(-)
>