From patchwork Wed Sep 11 20:04:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 11141845 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AA362184E for ; Wed, 11 Sep 2019 20:07:09 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8616D20838 for ; Wed, 11 Sep 2019 20:07:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="Aogj0XCn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8616D20838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i88s5-0003Aw-38; Wed, 11 Sep 2019 20:05:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i88s3-00039x-57 for xen-devel@lists.xenproject.org; Wed, 11 Sep 2019 20:05:43 +0000 X-Inumbo-ID: 78f20aab-d4cf-11e9-83dd-12813bfff9fa Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 78f20aab-d4cf-11e9-83dd-12813bfff9fa; Wed, 11 Sep 2019 20:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568232317; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=8E2CVo26NPzCSTbDgXbci1/oSFuY7QM1zw5qhDruAUE=; b=Aogj0XCn6GCgELr5G/2SB12VZsXodnFMrln5JrZ9HDRqCEepNGtrYz/P C87DilaiAjf8JK/Q4pU/1PQyHkGkYGmwSj8bJy3YtyiIF/5uguNxHNrlW u3wEj2mz2knTJaepfl+mTEH/TexIXdjb20Ol3ZEcH0snfI+cVIn1SgERR Q=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa1.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa1.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa1.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: K7zLYxo1BPD917lScnLR7MrYM3b0KRTBGmUqq5fgmw4359O7N5tEZQhRR+d3VAXrp8E0WNQD+/ HooYRBql8mIseaT/cbW9LybzPQvPwO7lnWBKvgopkg1xb3PZz2fLE9gPVyjl4NIZh92vrbeHre mTEduGg8cGUpaKtoiaCuavfKQs4IreFQWnXhR3rybUhV5WhAePZAJX1YWmRRzY16SXuqMuF05/ 6aJosKpuwEK92nVMf/LyLtJAL9x/63PCirpjMlajfZ4ZDjq3QvBz78W+4sAAIenZ/c9Vbf9SbS +4Y= X-SBRS: 2.7 X-MesageID: 5506251 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,494,1559534400"; d="scan'208";a="5506251" From: Andrew Cooper To: Xen-devel Date: Wed, 11 Sep 2019 21:04:56 +0100 Message-ID: <20190911200504.5693-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 0/8] x86/cpuid: Switch to using XEN_DOMCTL_set_cpumsr_policy X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Wei Liu , Andrew Cooper , Jan Beulich , Ian Jackson , Daniel De Graaf , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" This is the next part of the Xen/Toolstack CPUID/MSR work. With most of the pieces in place, implement XEN_DOMCTL_set_cpumsr_policy to obsolete the problematic XEN_DOMCTL_set_cpuid. Key improvements: 1) The API supports configuring static MSR settings for the domain, a capbility which Xen has never had before. 2) The hypercall supports saying no when the toolstack tries to pass problematic data. 3) The domain builder no longer uses native CPUID instructions for constructing guest policies, which is and has always been erroneous behaviour. 4) Vastily reduce the number of hypercalls for typicaly guest construction, by not issuing a hypercall per CPUID leaf. Patch 3 has been posted before, but a long time ago and it has changed substantially, so I've decided to start the version numbering from fresh. This series can be found in git from from: http://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=shortlog;h=refs/heads/xen-cpuid Andrew Cooper (8): libx86: Introduce x86_cpu_policies_are_compatible() x86/cpuid: Split update_domain_cpuid_info() in half x86/domctl: Implement XEN_DOMCTL_set_cpumsr_policy tools/libxc: Pre-cleanup for xc_cpuid_{set,apply_policy}() tools/libxc: Rework xc_cpuid_set() to use {get,set}_cpu_policy() tools/libxc: Rework xc_cpuid_apply_policy() to use {get,set}_cpu_policy() x86/domctl: Drop XEN_DOMCTL_set_cpuid x86/cpuid: Enable CPUID Faulting for the control domain tools/flask/policy/modules/dom0.te | 2 +- tools/flask/policy/modules/xen.if | 2 +- tools/libxc/include/xenctrl.h | 7 +- tools/libxc/xc_cpuid_x86.c | 931 +++++++++++-------------------- tools/tests/cpu-policy/Makefile | 2 +- tools/tests/cpu-policy/test-cpu-policy.c | 111 +++- xen/arch/x86/cpu/common.c | 19 +- xen/arch/x86/domctl.c | 258 ++++----- xen/include/public/domctl.h | 26 +- xen/include/xen/lib/x86/cpu-policy.h | 19 + xen/include/xen/lib/x86/cpuid.h | 11 +- xen/lib/x86/Makefile | 1 + xen/lib/x86/policy.c | 53 ++ xen/xsm/flask/hooks.c | 4 +- xen/xsm/flask/policy/access_vectors | 4 +- 15 files changed, 632 insertions(+), 818 deletions(-) create mode 100644 xen/lib/x86/policy.c