mbox series

[v2,0/3] Remove backend xen store entry on domain destroy

Message ID 20191121181300.6497-1-al1img@gmail.com (mailing list archive)
Headers show
Series Remove backend xen store entry on domain destroy | expand

Message

Oleksandr Grytsov Nov. 21, 2019, 6:12 p.m. UTC
From: Oleksandr Grytsov <oleksandr_grytsov@epam.com>

Changes since v1:

* add commit to rename VKB backend type "linux" to "pv";
* add default case to handle adding/removing PV devices in add_device,
  remove_device functions (libxl_device.c);
* add comment about removing num_vifs, num_vbds into commit message.

Oleksandr Grytsov (3):
  libxl: introduce new backend type VINPUT
  libxl: rename VKB backend type "linux" to "pv"
  libxl: make default path to add/remove all PV devices

 docs/man/xl.cfg.5.pod.in             |  4 +-
 tools/libxl/libxl_device.c           | 63 +++++++++++-----------------
 tools/libxl/libxl_types.idl          |  2 +-
 tools/libxl/libxl_types_internal.idl |  1 +
 tools/libxl/libxl_vkb.c              | 29 ++++++++-----
 5 files changed, 47 insertions(+), 52 deletions(-)

Comments

Ian Jackson Nov. 22, 2019, 11:23 a.m. UTC | #1
Oleksandr Grytsov writes ("[PATCH v2 0/3] Remove backend xen store entry on domain destroy"):
> From: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
> 
> Changes since v1:
> 
> * add commit to rename VKB backend type "linux" to "pv";
> * add default case to handle adding/removing PV devices in add_device,
>   remove_device functions (libxl_device.c);
> * add comment about removing num_vifs, num_vbds into commit message.

Thank you for this.  As you see, I approve.  We need an ack from the
Release Manager, so I have addresed Juergen (and also added the
missing `for-4.13' tag to the subject).

Given where we are in the release cycle with this (which I stress is
not really Oleksandr's fault) I think I would like to get a 2nd review
from another libxl maintainer.  Anthony, or Wei, would you like to
take a look ?

Thanks,
Ian.