From patchwork Mon Jan 20 12:20:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 11341957 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8606C6C1 for ; Mon, 20 Jan 2020 12:22:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6D0912073D for ; Mon, 20 Jan 2020 12:22:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D0912073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1itW3M-0001DP-I7; Mon, 20 Jan 2020 12:21:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1itW3K-0001D2-QO for xen-devel@lists.xenproject.org; Mon, 20 Jan 2020 12:21:10 +0000 X-Inumbo-ID: 4effbb72-3b7f-11ea-b95e-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4effbb72-3b7f-11ea-b95e-12813bfff9fa; Mon, 20 Jan 2020 12:20:56 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BE130AC7C; Mon, 20 Jan 2020 12:20:54 +0000 (UTC) From: Thomas Zimmermann To: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, hdegoede@redhat.com, david@lechnology.com, noralf@tronnes.org, sean@poorly.run, oleksandr_andrushchenko@epam.com, sam@ravnborg.org, laurent.pinchart@ideasonboard.com, emil.velikov@collabora.com Date: Mon, 20 Jan 2020 13:20:47 +0100 Message-Id: <20200120122051.25178-1-tzimmermann@suse.de> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v3 0/4] Use no_vblank property for drivers without VBLANK X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Thomas Zimmermann , dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Instead of faking VBLANK events by themselves, drivers without VBLANK support can enable drm_crtc_vblank.no_vblank and let DRM do the rest. The patchset makes this official and converts over drivers. The current implementation looks at the number of initialized CRTCs wrt vblanking. If vblanking has been initialized for a CRTC, the driver is responsible for sending out VBLANK events. Otherwise, DRM will send out the event. The behaviour selected by initializing no_vblank as part of drm_atomic_helper_check_modeset(). I went through all drivers, looking for those that call send out VBLANK events but do not call drm_vblank_init(). These are converted to the new semantics. This affects tiny drivers; drivers for virtual hardware; and a few others, which do not support interrupts. Xen comes with its own VBLANK logic and disables no_vblank explictly. For now, I left out Hans' R-b on v2 of the series, as the patches changed quite a bit. v3: * reorder and squash patches * set no_vblank in drm_atomic_helper_check_modeset() for *all* drivers (Daniel) * convert all drivers to new semnatics as necessary v2: * document functionality (Daniel) * cleanup ast (Daniel) * let simple-kms handle no_vblank where possible Thomas Zimmermann (4): drm: Add drm_crtc_has_vblank() drm: Initialize struct drm_crtc_state.no_vblank from device settings drm/ast: Don't set struct drm_crtc_state.no_vblank explictly drm/udl: Don't set struct drm_crtc_state.no_vblank explictly drivers/gpu/drm/arc/arcpgu_crtc.c | 16 ------------- drivers/gpu/drm/ast/ast_mode.c | 2 -- drivers/gpu/drm/bochs/bochs_kms.c | 9 ------- drivers/gpu/drm/cirrus/cirrus.c | 8 ------- drivers/gpu/drm/drm_atomic_helper.c | 10 +++++++- drivers/gpu/drm/drm_mipi_dbi.c | 9 ------- drivers/gpu/drm/drm_vblank.c | 30 ++++++++++++++++++++++++ drivers/gpu/drm/qxl/qxl_display.c | 14 ----------- drivers/gpu/drm/tiny/gm12u320.c | 9 ------- drivers/gpu/drm/tiny/ili9225.c | 9 ------- drivers/gpu/drm/tiny/repaper.c | 9 ------- drivers/gpu/drm/tiny/st7586.c | 9 ------- drivers/gpu/drm/udl/udl_modeset.c | 11 --------- drivers/gpu/drm/vboxvideo/vbox_mode.c | 12 ---------- drivers/gpu/drm/virtio/virtgpu_display.c | 8 ------- drivers/gpu/drm/xen/xen_drm_front_kms.c | 13 ++++++++++ include/drm/drm_crtc.h | 27 +++++++++++++++------ include/drm/drm_simple_kms_helper.h | 7 ++++-- include/drm/drm_vblank.h | 1 + 19 files changed, 78 insertions(+), 135 deletions(-) Acked-by: Gerd Hoffmann --- 2.24.1