From patchwork Mon Jul 6 13:26:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11645765 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5A83713B4 for ; Mon, 6 Jul 2020 13:28:13 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36898206F5 for ; Mon, 6 Jul 2020 13:28:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qbnbFANx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36898206F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jsR8h-00036n-Hq; Mon, 06 Jul 2020 13:26:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jsR8g-00036i-8X for xen-devel@lists.xenproject.org; Mon, 06 Jul 2020 13:26:30 +0000 X-Inumbo-ID: 4cbb88b4-bf8c-11ea-bb8b-bc764e2007e4 Received: from mail-wr1-x432.google.com (unknown [2a00:1450:4864:20::432]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 4cbb88b4-bf8c-11ea-bb8b-bc764e2007e4; Mon, 06 Jul 2020 13:26:29 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id f18so32847578wrs.0 for ; Mon, 06 Jul 2020 06:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tSVh3xZmU5Rl/VlxY1hhYknTsE0eO5DVOcNMGKELemE=; b=qbnbFANxBTkqeC8ntLvePUEA/6O+OhVKoiQ3wU8s9JPQSj4pshbaGeOTNW7MAamPcu Su+J3Dd1u74P4moHRgtiNEk57vt/sKjMkE9cJ46oAlj8Xe4Ltx59jSHx/tSifGlkp9jT jbSmk+3wA+8Uyjfv74QRqOXNsvpz9jkOL8r40qFfwnHqcWwWPWUUu5MwltusREfB6Yc0 pS6kgkug7Yp/zCYMoPi2XhqG6MiJiRGd7USoADPe+zJglJiboMUZG8IhQY4v81cPu9zV mQl7kmK5T2dLV1wubFA+r0qPiAve69N7SG3QCH2MZOTHvjpa/0djo5deiRXNEJBfIsQR 1Ayg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=tSVh3xZmU5Rl/VlxY1hhYknTsE0eO5DVOcNMGKELemE=; b=SObFtEo0FMMb6I6mv14zMP6QV6awC4NOuPmAVbTREIR42OBN2Gp5D49Y/3WaUn+hCj vmYJ5V9P6ijW2KOGfB9HshPbQBF6yhPU1IXE7vdTF2nuVkYqMp3ZDKn6pUXfhqbVIrDI Oft8I65wugyhja49XLFXggun/gKr39z451gvJ6FJXQmlReI6b2k/geLfwXp4qypwm2fs UZ+SU8Q+TTUeeSYEDO3cCdqJupMgfgMn2HYRnPpzV8SZ7JL0mAANSC4qqzHEAP8R5Aat j0XJHQyreTzsh14zUD0wXt8ID/PL5MbxxJu812/iPgG6ooRjELGe3hY12AOojKhttR64 g53w== X-Gm-Message-State: AOAM531xPPvHIUXLccHKKB9BNqDdrUVa9pKGLVeTr+8qlqluqlxVDZg5 UwwCxeqNyDS1nV5plWd/Vmw= X-Google-Smtp-Source: ABdhPJy3fteBFpWnCcBm76WBnCreC3Ozl3AURYlcuW7tquHy8jvwLRuhDJFqfAi9hiIEX+1alLgbyg== X-Received: by 2002:adf:f203:: with SMTP id p3mr20519115wro.331.1594041988856; Mon, 06 Jul 2020 06:26:28 -0700 (PDT) Received: from localhost.localdomain (138.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.138]) by smtp.gmail.com with ESMTPSA id w2sm24447004wrs.77.2020.07.06.06.26.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:26:28 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Markus Armbruster , qemu-devel@nongnu.org Subject: [PATCH 0/2] block/block-backend: Let blk_attach_dev() provide helpful error Date: Mon, 6 Jul 2020 15:26:24 +0200 Message-Id: <20200706132626.22133-1-f4bug@amsat.org> X-Mailer: git-send-email 2.21.3 MIME-Version: 1.0 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Stefano Stabellini , =?utf-8?q?Daniel_P=2E_Berrang?= =?utf-8?q?=C3=A9?= , Eduardo Habkost , qemu-block@nongnu.org, Paul Durrant , Laurent Vivier , Max Reitz , Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" A pair of patches which helps me debug an issue with block drive already attached. Suggestions to correctly/better use the Error API welcome, in particular in qdev-properties-system::set_drive_helper(). Philippe Mathieu-Daudé (2): block/block-backend: Trace blk_attach_dev() block/block-backend: Let blk_attach_dev() provide helpful error include/sysemu/block-backend.h | 2 +- block/block-backend.c | 12 +++++++++++- hw/block/fdc.c | 4 +--- hw/block/swim.c | 4 +--- hw/block/xen-block.c | 5 +++-- hw/core/qdev-properties-system.c | 17 ++++++++++------- hw/ide/qdev.c | 4 +--- hw/scsi/scsi-disk.c | 4 +--- block/trace-events | 1 + 9 files changed, 30 insertions(+), 23 deletions(-)