| Message ID | 20200707165037.1026246-1-armbru@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | error: auto propagated local_err part I | expand |
07.07.2020 19:50, Markus Armbruster wrote: > To speed things up, I'm taking the liberty to respin Vladimir's series > with my documentation amendments. Thank you! > > After my documentation work, I'm very much inclined to rename > ERRP_AUTO_PROPAGATE() to ERRP_GUARD(). The fact that it propagates > below the hood is detail. What matters to its users is that it lets > them use @errp more freely. Thoughts? No objections, if we are making error-propagation to be internal implementation detail, no reason to shout about it in the macro name.
On 7/7/20 11:50 AM, Markus Armbruster wrote: > To speed things up, I'm taking the liberty to respin Vladimir's series > with my documentation amendments. > > After my documentation work, I'm very much inclined to rename > ERRP_AUTO_PROPAGATE() to ERRP_GUARD(). The fact that it propagates > below the hood is detail. What matters to its users is that it lets > them use @errp more freely. Thoughts? I like it - the shorter name is easier to type. (The rename is a mechanical change, so if we agree to it, we should do it up front to minimize the churn to all the functions where we add use of the macro) > > Based-on: Message-Id: <20200707160613.848843-1-armbru@redhat.com> > > Available from my public repository https://repo.or.cz/qemu/armbru.git > on branch error-auto. > > v12: (based on "[PATCH v4 00/45] Less clumsy error checking") > 01: Comments merged properly with recent commit "error: Document Error > API usage rules", and edited for clarity. Put ERRP_AUTO_PROPAGATE() > before its helpers, and touch up style. > 01-08: Commit messages tweaked >
To speed things up, I'm taking the liberty to respin Vladimir's series with my documentation amendments. After my documentation work, I'm very much inclined to rename ERRP_AUTO_PROPAGATE() to ERRP_GUARD(). The fact that it propagates below the hood is detail. What matters to its users is that it lets them use @errp more freely. Thoughts? Based-on: Message-Id: <20200707160613.848843-1-armbru@redhat.com> Available from my public repository https://repo.or.cz/qemu/armbru.git on branch error-auto. v12: (based on "[PATCH v4 00/45] Less clumsy error checking") 01: Comments merged properly with recent commit "error: Document Error API usage rules", and edited for clarity. Put ERRP_AUTO_PROPAGATE() before its helpers, and touch up style. 01-08: Commit messages tweaked Vladimir's cover letter for v11: v11: (based-on "[PATCH v2 00/44] Less clumsy error checking") 01: minor rebase of documentation, keep r-bs 02: - minor comment tweaks [Markus] - use explicit file name in MAINTAINERS instead of pattern - add Markus's r-b 03,07,08: rabase changes, drop r-bs v11 is available at https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v11 v10 is available at https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v10 In these series, there is no commit-per-subsystem script, each generated commit is generated in separate. Still, generating commands are very similar, and looks like sed -n '/^<Subsystem name>$/,/^$/{s/^F: //p}' MAINTAINERS | \ xargs git ls-files | grep '\.[hc]$' | \ xargs spatch \ --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h \ --in-place --no-show-diff --max-width 80 Note, that in each generated commit, generation command is the only text, indented by 8 spaces in 'git log -1' output, so, to regenerate all commits (for example, after rebase, or change in coccinelle script), you may use the following command: git rebase -x "sh -c \"git show --pretty= --name-only | xargs git checkout HEAD^ -- ; git reset; git log -1 | grep '^ ' | sh\"" HEAD~6 Which will start automated interactive rebase for generated patches, which will stop if generated patch changed (you may do git commit --amend to apply updated generated changes). Note: git show --pretty= --name-only - lists files, changed in HEAD git log -1 | grep '^ ' | sh - rerun generation command of HEAD Check for compilation of changed .c files git rebase -x "sh -c \"git show --pretty= --name-only | sed -n 's/\.c$/.o/p' | xargs make -j9\"" HEAD~6 Vladimir Sementsov-Ogievskiy (8): error: New macro ERRP_AUTO_PROPAGATE() scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() sd: Use ERRP_AUTO_PROPAGATE() pflash: Use ERRP_AUTO_PROPAGATE() fw_cfg: Use ERRP_AUTO_PROPAGATE() virtio-9p: Use ERRP_AUTO_PROPAGATE() nbd: Use ERRP_AUTO_PROPAGATE() xen: Use ERRP_AUTO_PROPAGATE() scripts/coccinelle/auto-propagated-errp.cocci | 337 ++++++++++++++++++ include/block/nbd.h | 1 + include/qapi/error.h | 163 ++++++++- block/nbd.c | 7 +- hw/9pfs/9p-local.c | 12 +- hw/9pfs/9p.c | 1 + hw/block/dataplane/xen-block.c | 17 +- hw/block/pflash_cfi01.c | 7 +- hw/block/pflash_cfi02.c | 7 +- hw/block/xen-block.c | 102 +++--- hw/nvram/fw_cfg.c | 14 +- hw/pci-host/xen_igd_pt.c | 7 +- hw/sd/sdhci-pci.c | 7 +- hw/sd/sdhci.c | 21 +- hw/sd/ssi-sd.c | 10 +- hw/xen/xen-backend.c | 7 +- hw/xen/xen-bus.c | 92 ++--- hw/xen/xen-host-pci-device.c | 27 +- hw/xen/xen_pt.c | 25 +- hw/xen/xen_pt_config_init.c | 17 +- nbd/client.c | 5 + nbd/server.c | 5 + MAINTAINERS | 1 + 23 files changed, 659 insertions(+), 233 deletions(-) create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci