From patchwork Thu Feb 25 17:41:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 12104607 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B4DEC433DB for ; Thu, 25 Feb 2021 17:42:23 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D84064F1A for ; Thu, 25 Feb 2021 17:42:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D84064F1A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.89890.169779 (Exim 4.92) (envelope-from ) id 1lFKeU-00068j-8f; Thu, 25 Feb 2021 17:42:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 89890.169779; Thu, 25 Feb 2021 17:42:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFKeU-00068c-5R; Thu, 25 Feb 2021 17:42:14 +0000 Received: by outflank-mailman (input) for mailman id 89890; Thu, 25 Feb 2021 17:42:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFKeT-00068X-Ba for xen-devel@lists.xenproject.org; Thu, 25 Feb 2021 17:42:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFKeS-0005qf-CD; Thu, 25 Feb 2021 17:42:12 +0000 Received: from 54-240-197-235.amazon.com ([54.240.197.235] helo=ufe34d9ed68d054.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lFKeR-00032g-Vg; Thu, 25 Feb 2021 17:42:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Message-Id:Date:Subject:Cc:To:From; bh=hMmY1pZlwkcpsLVU2u7EXJeXlw3MMy5FmKya1ob/Nqw=; b=3ZDz04sUXadIkRDEJ3JECubTga O7Dpg4WwmkgBYmTLytupZgVj54glxTTx/Yjgi3SP+u4h0vomepH0uw1uKONXZefI2rwdeuDKs0ogS cb44sLI61Ul1TIdbOWeVRrZCnbQasYF5CBAKaHA/tUyA0j1TAY1mwR5jpYfVu0IEFzag=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: raphning@amazon.co.uk, iwj@xenproject.org, Julien Grall , Wei Liu , Juergen Gross Subject: [PATCH for-4.15 0/5] xenstore: Address coverity issues in the LiveUpdate code Date: Thu, 25 Feb 2021 17:41:26 +0000 Message-Id: <20210225174131.10115-1-julien@xen.org> X-Mailer: git-send-email 2.17.1 From: Julien Grall Hi all, The AWS coverity instance spotted a few issues that could either leak memory and derefence NULL pointer. All the patches are candidate for 4.15 as they are hardening XenStored code. The changes are low risks. Cheers, Julien Grall (5): tools/xenstored: Avoid unnecessary talloc_strdup() in do_control_lu() tools/xenstored: Avoid unnecessary talloc_strdup() in do_lu_start() tools/xenstored: control: Store the save filename in lu_dump_state tools/xenstore-control: Don't leak buf in live_update_start() tools/xenstored: Silence coverity when using xs_state_* structures tools/xenstore/include/xenstore_state.h | 6 +++--- tools/xenstore/xenstore_control.c | 4 +++- tools/xenstore/xenstored_control.c | 26 +++++++++++-------------- 3 files changed, 17 insertions(+), 19 deletions(-)