mbox series

[v2,0/3] xsm: refactor and optimize policy loading

Message ID 20220531023945.22196-1-dpsmith@apertussolutions.com (mailing list archive)
Headers show
Series xsm: refactor and optimize policy loading | expand

Message

Daniel P. Smith May 31, 2022, 2:39 a.m. UTC
This series was born out of some cleanup work done while crafting the
hyperlaunch boot modules patch series. The primary purpose of this series was
to stop walking all boot modules when it was not necessary, but the scope
creeped during review.

Changes in v2:
* changed init_policy to policy_file_required
* split the patch into a series
* corrected casting of policy buffer
* use IS_ENABLED() instead of #ifdef sequence
* moved #ifdef inside of braces for xsm_dt_policy_init()
* addressed lack of error handling of xsm{mb,dt}_init()

Daniel P. Smith (3):
  xsm: only search for a policy file when needed
  xsm: consolidate loading the policy buffer
  xsm: properly handle error from XSM init

 xen/arch/arm/setup.c  | 10 ++++----
 xen/arch/x86/setup.c  |  9 +++++--
 xen/include/xsm/xsm.h |  2 +-
 xen/xsm/xsm_core.c    | 56 +++++++++++++++++++++----------------------
 xen/xsm/xsm_policy.c  | 31 ++++++++++++++++++++----
 5 files changed, 68 insertions(+), 40 deletions(-)

Comments

Jan Beulich May 31, 2022, 8:25 a.m. UTC | #1
On 31.05.2022 04:39, Daniel P. Smith wrote:
> This series was born out of some cleanup work done while crafting the
> hyperlaunch boot modules patch series. The primary purpose of this series was
> to stop walking all boot modules when it was not necessary, but the scope
> creeped during review.
> 
> Changes in v2:
> * changed init_policy to policy_file_required
> * split the patch into a series
> * corrected casting of policy buffer
> * use IS_ENABLED() instead of #ifdef sequence
> * moved #ifdef inside of braces for xsm_dt_policy_init()
> * addressed lack of error handling of xsm{mb,dt}_init()
> 
> Daniel P. Smith (3):
>   xsm: only search for a policy file when needed
>   xsm: consolidate loading the policy buffer
>   xsm: properly handle error from XSM init

The thread consists of 5 follow-ups, including two different 1/3 and two
different 2/3. This wants sorting and then perhaps (properly) resending.

Jan
Daniel P. Smith May 31, 2022, 10:38 a.m. UTC | #2
On 5/31/22 04:25, Jan Beulich wrote:
> On 31.05.2022 04:39, Daniel P. Smith wrote:
>> This series was born out of some cleanup work done while crafting the
>> hyperlaunch boot modules patch series. The primary purpose of this series was
>> to stop walking all boot modules when it was not necessary, but the scope
>> creeped during review.
>>
>> Changes in v2:
>> * changed init_policy to policy_file_required
>> * split the patch into a series
>> * corrected casting of policy buffer
>> * use IS_ENABLED() instead of #ifdef sequence
>> * moved #ifdef inside of braces for xsm_dt_policy_init()
>> * addressed lack of error handling of xsm{mb,dt}_init()
>>
>> Daniel P. Smith (3):
>>   xsm: only search for a policy file when needed
>>   xsm: consolidate loading the policy buffer
>>   xsm: properly handle error from XSM init
> 
> The thread consists of 5 follow-ups, including two different 1/3 and two
> different 2/3. This wants sorting and then perhaps (properly) resending.

Yep, looks like I had stray copies from an internal review spin. My
apologies. Will resend clean version.

v/r,
dps