mbox series

[for-4.17,0/6] (v)pci: fixes related to memory decoding handling

Message ID 20221020094649.28667-1-roger.pau@citrix.com (mailing list archive)
Headers show
Series (v)pci: fixes related to memory decoding handling | expand

Message

Roger Pau Monné Oct. 20, 2022, 9:46 a.m. UTC 
Hello,

First two patches fix some build isses that showed up on the vpci test
harness, following patches attempt to fix the regressions caused by
75cc460a1b ('xen/pci: detect when BARs are not suitably positioned') and
the last patch relaxes the check done when attempting to write to BARs
with memory decoding enabled.

I consider all of them bug fixes, albeit the last patch is not fixing a
regression (since vPCI code has always behaved this way).

Thanks, Roger.

Roger Pau Monne (6):
  test/vpci: add dummy cfcheck define
  test/vpci: fix vPCI test harness to provide pci_get_pdev()
  vpci: don't assume that vpci per-device data exists unconditionally
  vpci: introduce a local vpci_bar variable to modify_decoding()
  pci: do not disable memory decoding for devices
  vpci: refuse BAR writes only if the BAR is mapped

 tools/tests/vpci/emul.h       |  3 +-
 xen/drivers/passthrough/pci.c | 69 -----------------------------------
 xen/drivers/vpci/header.c     | 38 ++++++++++++++-----
 xen/drivers/vpci/vpci.c       |  6 +--
 4 files changed, 34 insertions(+), 82 deletions(-)

Comments

Henry Wang Oct. 20, 2022, 10:12 a.m. UTC | #1 
Hi Roger, 

> -----Original Message-----
> Subject: [PATCH for-4.17 0/6] (v)pci: fixes related to memory decoding
> handling
> 
> Hello,
> 
> First two patches fix some build isses that showed up on the vpci test
> harness, following patches attempt to fix the regressions caused by
> 75cc460a1b ('xen/pci: detect when BARs are not suitably positioned') and
> the last patch relaxes the check done when attempting to write to BARs
> with memory decoding enabled.
> 
> I consider all of them bug fixes, albeit the last patch is not fixing a
> regression (since vPCI code has always behaved this way).

As I don't really want to spam the list, I will provide my release-ack in
the cover letter.

This series is a bugfix series, so:

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry


> 
> Thanks, Roger.
> 
> Roger Pau Monne (6):
>   test/vpci: add dummy cfcheck define
>   test/vpci: fix vPCI test harness to provide pci_get_pdev()
>   vpci: don't assume that vpci per-device data exists unconditionally
>   vpci: introduce a local vpci_bar variable to modify_decoding()
>   pci: do not disable memory decoding for devices
>   vpci: refuse BAR writes only if the BAR is mapped
> 
>  tools/tests/vpci/emul.h       |  3 +-
>  xen/drivers/passthrough/pci.c | 69 -----------------------------------
>  xen/drivers/vpci/header.c     | 38 ++++++++++++++-----
>  xen/drivers/vpci/vpci.c       |  6 +--
>  4 files changed, 34 insertions(+), 82 deletions(-)
> 
> --
> 2.37.3
>