| Message ID | 20231121114048.31294-1-jgross@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | tools/xenstored: remove some command line options | expand |
On 21.11.23 12:40, Juergen Gross wrote: > Remove some command line options which have no real use case. > > Changes in V2: > - moved removal of "-N" into last patch of the series, as this is the > only option which seems to have a use case (OTOH using it has some > downsides as well). > > Juergen Gross (5): > tools/xenstored: remove "-D" command line parameter > tools/xenstored: remove "-V" command line option > tools/xenstored: remove the "-P" command line option > tools/xenstored: remove the "-R" command line option > tools/xenstored: remove "-N" command line option > > tools/xenstored/core.c | 81 +++++++----------------------------------- > 1 file changed, 12 insertions(+), 69 deletions(-) > I think at least patches 1-4 can go in as they all have the required Acks. Juergen
On 07.12.2023 09:26, Juergen Gross wrote: > On 21.11.23 12:40, Juergen Gross wrote: >> Remove some command line options which have no real use case. >> >> Changes in V2: >> - moved removal of "-N" into last patch of the series, as this is the >> only option which seems to have a use case (OTOH using it has some >> downsides as well). >> >> Juergen Gross (5): >> tools/xenstored: remove "-D" command line parameter >> tools/xenstored: remove "-V" command line option >> tools/xenstored: remove the "-P" command line option >> tools/xenstored: remove the "-R" command line option >> tools/xenstored: remove "-N" command line option >> >> tools/xenstored/core.c | 81 +++++++----------------------------------- >> 1 file changed, 12 insertions(+), 69 deletions(-) >> > > I think at least patches 1-4 can go in as they all have the required Acks. I'll try to remember to include them in the next swipe. I was kind of assuming Julien would be taking care of them. Jan
Hi Jan, On 07/12/2023 09:30, Jan Beulich wrote: > On 07.12.2023 09:26, Juergen Gross wrote: >> On 21.11.23 12:40, Juergen Gross wrote: >>> Remove some command line options which have no real use case. >>> >>> Changes in V2: >>> - moved removal of "-N" into last patch of the series, as this is the >>> only option which seems to have a use case (OTOH using it has some >>> downsides as well). >>> >>> Juergen Gross (5): >>> tools/xenstored: remove "-D" command line parameter >>> tools/xenstored: remove "-V" command line option >>> tools/xenstored: remove the "-P" command line option >>> tools/xenstored: remove the "-R" command line option >>> tools/xenstored: remove "-N" command line option >>> >>> tools/xenstored/core.c | 81 +++++++----------------------------------- >>> 1 file changed, 12 insertions(+), 69 deletions(-) >>> >> >> I think at least patches 1-4 can go in as they all have the required Acks. > > I'll try to remember to include them in the next swipe. I was kind of > assuming Julien would be taking care of them. Sorry this fell through the cracks. I can do it if you haven't yet done it. Cheers,
On 07.12.2023 13:14, Julien Grall wrote: > Hi Jan, > > On 07/12/2023 09:30, Jan Beulich wrote: >> On 07.12.2023 09:26, Juergen Gross wrote: >>> On 21.11.23 12:40, Juergen Gross wrote: >>>> Remove some command line options which have no real use case. >>>> >>>> Changes in V2: >>>> - moved removal of "-N" into last patch of the series, as this is the >>>> only option which seems to have a use case (OTOH using it has some >>>> downsides as well). >>>> >>>> Juergen Gross (5): >>>> tools/xenstored: remove "-D" command line parameter >>>> tools/xenstored: remove "-V" command line option >>>> tools/xenstored: remove the "-P" command line option >>>> tools/xenstored: remove the "-R" command line option >>>> tools/xenstored: remove "-N" command line option >>>> >>>> tools/xenstored/core.c | 81 +++++++----------------------------------- >>>> 1 file changed, 12 insertions(+), 69 deletions(-) >>>> >>> >>> I think at least patches 1-4 can go in as they all have the required Acks. >> >> I'll try to remember to include them in the next swipe. I was kind of >> assuming Julien would be taking care of them. > > Sorry this fell through the cracks. I can do it if you haven't yet done it. I haven't yet, no. Jan
On 07/12/2023 12:39, Jan Beulich wrote: > On 07.12.2023 13:14, Julien Grall wrote: >> Hi Jan, >> >> On 07/12/2023 09:30, Jan Beulich wrote: >>> On 07.12.2023 09:26, Juergen Gross wrote: >>>> On 21.11.23 12:40, Juergen Gross wrote: >>>>> Remove some command line options which have no real use case. >>>>> >>>>> Changes in V2: >>>>> - moved removal of "-N" into last patch of the series, as this is the >>>>> only option which seems to have a use case (OTOH using it has some >>>>> downsides as well). >>>>> >>>>> Juergen Gross (5): >>>>> tools/xenstored: remove "-D" command line parameter >>>>> tools/xenstored: remove "-V" command line option >>>>> tools/xenstored: remove the "-P" command line option >>>>> tools/xenstored: remove the "-R" command line option >>>>> tools/xenstored: remove "-N" command line option >>>>> >>>>> tools/xenstored/core.c | 81 +++++++----------------------------------- >>>>> 1 file changed, 12 insertions(+), 69 deletions(-) >>>>> >>>> >>>> I think at least patches 1-4 can go in as they all have the required Acks. >>> >>> I'll try to remember to include them in the next swipe. I was kind of >>> assuming Julien would be taking care of them. >> >> Sorry this fell through the cracks. I can do it if you haven't yet done it. > > I haven't yet, no. Ok. I will take care of patches #1-#4 then. Cheers,
On 07/12/2023 08:26, Juergen Gross wrote: > On 21.11.23 12:40, Juergen Gross wrote: >> Remove some command line options which have no real use case. >> >> Changes in V2: >> - moved removal of "-N" into last patch of the series, as this is the >> only option which seems to have a use case (OTOH using it has some >> downsides as well). >> >> Juergen Gross (5): >> tools/xenstored: remove "-D" command line parameter >> tools/xenstored: remove "-V" command line option >> tools/xenstored: remove the "-P" command line option >> tools/xenstored: remove the "-R" command line option >> tools/xenstored: remove "-N" command line option >> >> tools/xenstored/core.c | 81 +++++++----------------------------------- >> 1 file changed, 12 insertions(+), 69 deletions(-) >> > > I think at least patches 1-4 can go in as they all have the required Acks. Thanks for the reminder. I have committed patches #1-#4. Cheers,
On Tue, Nov 21, 2023 at 12:40:43PM +0100, Juergen Gross wrote: > Remove some command line options which have no real use case. > > Changes in V2: > - moved removal of "-N" into last patch of the series, as this is the > only option which seems to have a use case (OTOH using it has some > downsides as well). > > Juergen Gross (5): > tools/xenstored: remove "-D" command line parameter > tools/xenstored: remove "-V" command line option > tools/xenstored: remove the "-P" command line option > tools/xenstored: remove the "-R" command line option > tools/xenstored: remove "-N" command line option Should we have en entry in the changelog about all these removals? Who knows if they are used by someone or not... Thanks,
On 08.12.23 16:33, Anthony PERARD wrote: > On Tue, Nov 21, 2023 at 12:40:43PM +0100, Juergen Gross wrote: >> Remove some command line options which have no real use case. >> >> Changes in V2: >> - moved removal of "-N" into last patch of the series, as this is the >> only option which seems to have a use case (OTOH using it has some >> downsides as well). >> >> Juergen Gross (5): >> tools/xenstored: remove "-D" command line parameter >> tools/xenstored: remove "-V" command line option >> tools/xenstored: remove the "-P" command line option >> tools/xenstored: remove the "-R" command line option >> tools/xenstored: remove "-N" command line option > > Should we have en entry in the changelog about all these removals? Who > knows if they are used by someone or not... I'll send a patch in this regard when patch 5 has gone in. Juergen