| Message ID | 20240522132829.1278625-1-edgar.iglesias@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | xen/arm: smmuv3: Mark more init-only functions with __init | expand |
Hi Edgar, On 22/05/2024 14:28, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" <edgar.iglesias@amd.com> > > I was scanning for code that we could potentially move from the > .text section into .init.text and found a few candidates. > > I'm not sure if this makes sense, perhaps we don't want to mark > these functions for other reasons but my scripts found this chain > of SMMUv3 init functions as only reachable by .inittext code. > Perhaps it's a little late in the release cycle to consider this... The risk of the change is limited and the SMMUv3 driver is still in tech preview. So I would say it would be fine as long as it is fully reviewed by the code freeze date (14th June). CCing the release manager (Oleksii) to check if he is happy with committing this patch in 4.19. If not, I can queue it in a personal branch until the tree is re-opened. But note this still need a review frome either Bertrand or Rahul. Cheers,
From: "Edgar E. Iglesias" <edgar.iglesias@amd.com> I was scanning for code that we could potentially move from the .text section into .init.text and found a few candidates. I'm not sure if this makes sense, perhaps we don't want to mark these functions for other reasons but my scripts found this chain of SMMUv3 init functions as only reachable by .inittext code. Perhaps it's a little late in the release cycle to consider this... Best regards, Edgar Edgar E. Iglesias (1): xen/arm: smmuv3: Mark more init-only functions with __init xen/drivers/passthrough/arm/smmu-v3.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)