mbox series

[for-4.20?,0/5] xen/perfc: Cleanup, and wire up for RISCV/PPC

Message ID 20250102192508.2405687-1-andrew.cooper3@citrix.com (mailing list archive)
Headers show
Series xen/perfc: Cleanup, and wire up for RISCV/PPC | expand

Message

Andrew Cooper Jan. 2, 2025, 7:25 p.m. UTC 
This started as just patch 3 fixing a header tangle with FRED on x86, but grew
somewhat.

It's simple, straight forward, and gets perf counters working uniformly on all
architectures, and a net reduction in code.

It's low risk, and should be considered for 4.20 at this juncture.

https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1609450793

Andrew Cooper (5):
  xen/perfc: Drop arch_perfc_{gather,reset}()
  xen/perfc: Add perfc_defn.h to asm-generic
  xen/perfc: Trim includes
  xen/perfc: Cleanup
  xen/perfc: COMPILE TEST

 automation/gitlab-ci/build.yaml      |  1 -
 xen/Kconfig.debug                    | 14 ++++----------
 xen/arch/arm/include/asm/perfc.h     | 21 ---------------------
 xen/arch/ppc/include/asm/Makefile    |  1 +
 xen/arch/riscv/include/asm/Makefile  |  1 +
 xen/arch/x86/include/asm/perfc.h     | 12 ------------
 xen/common/perfc.c                   | 26 ++++++++++----------------
 xen/include/asm-generic/perfc_defn.h |  5 +++++
 xen/include/xen/perfc.h              | 26 ++++++++++++--------------
 xen/include/xen/perfc_defn.h         |  2 ++
 10 files changed, 35 insertions(+), 74 deletions(-)
 delete mode 100644 xen/arch/arm/include/asm/perfc.h
 delete mode 100644 xen/arch/x86/include/asm/perfc.h
 create mode 100644 xen/include/asm-generic/perfc_defn.h


base-commit: a1746cd4434dd27ca2da8430dfb10edc76264bb3

Comments

Oleksii Kurochko Jan. 7, 2025, 9:16 a.m. UTC | #1 
On 1/2/25 8:25 PM, Andrew Cooper wrote:
> This started as just patch 3 fixing a header tangle with FRED on x86, but grew
> somewhat.
>
> It's simple, straight forward, and gets perf counters working uniformly on all
> architectures, and a net reduction in code.
>
> It's low risk, and should be considered for 4.20 at this juncture.

Agree, we could consider to be in 4.20.

Feel free to commit these patch series.

Thanks.

~ Oleksii


>
> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/1609450793
>
> Andrew Cooper (5):
>    xen/perfc: Drop arch_perfc_{gather,reset}()
>    xen/perfc: Add perfc_defn.h to asm-generic
>    xen/perfc: Trim includes
>    xen/perfc: Cleanup
>    xen/perfc: COMPILE TEST
>
>   automation/gitlab-ci/build.yaml      |  1 -
>   xen/Kconfig.debug                    | 14 ++++----------
>   xen/arch/arm/include/asm/perfc.h     | 21 ---------------------
>   xen/arch/ppc/include/asm/Makefile    |  1 +
>   xen/arch/riscv/include/asm/Makefile  |  1 +
>   xen/arch/x86/include/asm/perfc.h     | 12 ------------
>   xen/common/perfc.c                   | 26 ++++++++++----------------
>   xen/include/asm-generic/perfc_defn.h |  5 +++++
>   xen/include/xen/perfc.h              | 26 ++++++++++++--------------
>   xen/include/xen/perfc_defn.h         |  2 ++
>   10 files changed, 35 insertions(+), 74 deletions(-)
>   delete mode 100644 xen/arch/arm/include/asm/perfc.h
>   delete mode 100644 xen/arch/x86/include/asm/perfc.h
>   create mode 100644 xen/include/asm-generic/perfc_defn.h
>
>
> base-commit: a1746cd4434dd27ca2da8430dfb10edc76264bb3