[v2,0/2,PATCH-for-4.13] Work towards removing brctl

Message

Steven Haigh Dec. 13, 2019, 4:08 a.m. UTC

Start updating scripts for network functionality

(Resending as the patch emails seem to have been eaten somewhere)

The scripts for networking in Xen have a mixture of formatting,
tab spacing, space spacing inconsistencies.

We also have issues where CentOS 8 does not have brctl - being
replaced with ip / bridge commands.

This series starts cleaning up whitespace and formatting, as well
as starts adding conditionals for using brctl (if present) but using
ip if /usr/sbin/brctl is not installed.

Changes since v1
  * Fixed reference to /usr/bin/brctl instead of /usr/sbin/brctl

Steven Haigh (2):
  Tidy up whitespace and formatting in file to be consistent.
  Use ip for bridge related functions where brctl is not present

 tools/hotplug/Linux/colo-proxy-setup      |  30 +++--
 tools/hotplug/Linux/vif-bridge            |  19 ++-
 tools/hotplug/Linux/vif2                  |  12 +-
 tools/hotplug/Linux/xen-network-common.sh | 151 +++++++++++-----------
 4 files changed, 121 insertions(+), 91 deletions(-)

Comments

Jürgen Groß Dec. 13, 2019, 5:42 a.m. UTC | #1

On 13.12.19 05:08, Steven Haigh wrote:
> Start updating scripts for network functionality
> 
> (Resending as the patch emails seem to have been eaten somewhere)
> 
> The scripts for networking in Xen have a mixture of formatting,
> tab spacing, space spacing inconsistencies.
> 
> We also have issues where CentOS 8 does not have brctl - being
> replaced with ip / bridge commands.
> 
> This series starts cleaning up whitespace and formatting, as well
> as starts adding conditionals for using brctl (if present) but using
> ip if /usr/sbin/brctl is not installed.
> 
> Changes since v1
>    * Fixed reference to /usr/bin/brctl instead of /usr/sbin/brctl
> 
> Steven Haigh (2):
>    Tidy up whitespace and formatting in file to be consistent.
>    Use ip for bridge related functions where brctl is not present
> 
>   tools/hotplug/Linux/colo-proxy-setup      |  30 +++--
>   tools/hotplug/Linux/vif-bridge            |  19 ++-
>   tools/hotplug/Linux/vif2                  |  12 +-
>   tools/hotplug/Linux/xen-network-common.sh | 151 +++++++++++-----------
>   4 files changed, 121 insertions(+), 91 deletions(-)
> 

As this is no 4.13 regression its too late for the patches to make it
into 4.13, sorry.