From patchwork Sun Jun 14 14:36:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grzegorz Uriasz X-Patchwork-Id: 11603327 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 54EFB13B1 for ; Sun, 14 Jun 2020 14:38:32 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30034206D7 for ; Sun, 14 Jun 2020 14:38:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oxPWLN2R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30034206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jkTl1-0004YG-N1; Sun, 14 Jun 2020 14:37:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jkTl0-0004YB-SF for xen-devel@lists.xenproject.org; Sun, 14 Jun 2020 14:37:10 +0000 X-Inumbo-ID: 874c264c-ae4c-11ea-b7bb-bc764e2007e4 Received: from mail-ej1-x643.google.com (unknown [2a00:1450:4864:20::643]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 874c264c-ae4c-11ea-b7bb-bc764e2007e4; Sun, 14 Jun 2020 14:37:10 +0000 (UTC) Received: by mail-ej1-x643.google.com with SMTP id l27so14724108ejc.1 for ; Sun, 14 Jun 2020 07:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F6On6rf2nicxLWMEIcW1TLcL1Hrgjpywh0LpJEepZ+k=; b=oxPWLN2RwlVG6htFCyTgxZKsxUBq7DbHG2EtNWJHb3TseGAKq4i8qIVWF7B4jWv1Pp 5j62QlNPBifHdsNk4uFFi7DTWyyvAMSG7Jgzo/tacn45UddqAyK3tHGG5chf5hna3Nmp HodrGPRIca6y1EvLsrCmFa7m5yjcy9sJurLbXswQBfn6OqGLcKKql4jRIkwMatorKFRt zF1OTrHnVUPNAzHOFAJ1oWSl6w/TP1XY5ZVOuUMMOr00Ni9hRB1KrcBs4VCJxUROEQ1o AAo2xQGEzKZ7nhza8lhTPMnFLnvA4cjXEF7ihZRKX/DsG/iQKMefYATaVrwdyAO8VUDm L/jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=F6On6rf2nicxLWMEIcW1TLcL1Hrgjpywh0LpJEepZ+k=; b=gxlsF2j/H0+hzXpZLww8DCTtmcCJX1sDL+6bOvSBuV5Fx6AIfVbTSDXO/EqWs1mDYO 6sXOZhhSfRNvNHjltsrs20bLNyQv7O1pJ5pP9xpqziwB8S7E5AQXBKbFBknG7dR+NW+h rLN81C1uybVXcB1sdknULVQmS5rJ2QJZKhtAAZ6sa5HzfERrHrUyhAE57J1RL8gqvqHe OVMDItEstp0nNccRgB+J0AFeo34dHIBUYB7glK2L67wqW4ySCqZn9/JIXjuYa2GFDqcK Yj5nAHbLpIfVXKmyuteL53JBSDyvojPwfLjmtnbTF5VCmRU83u5SHfI6qh3xxljrvMgc nEVg== X-Gm-Message-State: AOAM530q/qdESSR5gvqQZOKWPGnDK/VmDpyjhjeokMH7Sci/uvNzLxLL QTh0xfIeFyoCfn5n8yExpaqaTXDEiAX5hA== X-Google-Smtp-Source: ABdhPJy2itoXi9nScreiQpUBnRAYugeC2fwZnD4WdPcs4gx2OBKLUy8Nsba+6yJV2mYuNx5COFgW2A== X-Received: by 2002:a17:906:784c:: with SMTP id p12mr21434137ejm.123.1592145429358; Sun, 14 Jun 2020 07:37:09 -0700 (PDT) Received: from localhost.localdomain (public-gprs354212.centertel.pl. [37.47.14.229]) by smtp.gmail.com with ESMTPSA id l18sm6753823eds.46.2020.06.14.07.37.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Jun 2020 07:37:08 -0700 (PDT) From: Grzegorz Uriasz To: xen-devel@lists.xenproject.org Subject: [PATCH 0/1] Fix broken suspend on some machines Date: Sun, 14 Jun 2020 14:36:27 +0000 Message-Id: X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: artur@puzio.waw.pl, Wei Liu , jakub@bartmin.ski, Andrew Cooper , marmarek@invisiblethingslab.com, Grzegorz Uriasz , Jan Beulich , j.nowak26@student.uw.edu.pl, =?utf-8?q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Hi, The included patch is a small subset of a bigger patch set spanning few projects aiming to isolate the GPU in Qubes OS to a dedicated security domain. I'm doing this together with 3 colleagues as part of our Bachelors thesis. While working on the project we came across 2 machines - newer gaming laptops on which the suspend functionality on unmodified xen is completely broken. The affected machines were able to suspend but not always resume. Even if the resume succeeded then the kernel time was trashed in the dmesg log and the machine never managed to suspend another time. After changing the xen clock to hpet, suspend started working again both on stock xen and Qubes OS - this indicates a bug in the ACPI PM Timer. After disassembling the FADT ACPI table on the ASUS FX504GM I understood that the reported bit width is 32 bits but the flags indicate a 24 bit PM timer. The included patch fixes the suspend feature on ASUS FX504GM and hopefully other laptops - Probably next week I will test this patch on my friend's laptop where this issue also occurs(suspend is broken, trashed kernel time after resume). Grzegorz Uriasz (1): x86/acpi: Use FADT flags to determine the PMTMR width xen/arch/x86/acpi/boot.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)