From patchwork Wed Aug 9 11:02:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13347780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CC18C04A94 for ; Wed, 9 Aug 2023 11:03:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.580897.909374 (Exim 4.92) (envelope-from ) id 1qTgxu-0007O6-4t; Wed, 09 Aug 2023 11:02:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 580897.909374; Wed, 09 Aug 2023 11:02:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxu-0007N9-06; Wed, 09 Aug 2023 11:02:58 +0000 Received: by outflank-mailman (input) for mailman id 580897; Wed, 09 Aug 2023 11:02:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qTgxt-0007K6-By for xen-devel@lists.xenproject.org; Wed, 09 Aug 2023 11:02:57 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a849d26-36a4-11ee-8613-37d641c3527e; Wed, 09 Aug 2023 13:02:55 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id B0CED4EE073F; Wed, 9 Aug 2023 13:02:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a849d26-36a4-11ee-8613-37d641c3527e From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Subject: [XEN PATCH 0/8] xen: address MISRA C:2012 Rule 8.4 Date: Wed, 9 Aug 2023 13:02:33 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Rule states the following: "A compatible declaration shall be visible when an object or function with external linkage is defined". This series deals with violations concerning functions and variables used by C code (thus not used only within asm). The resolution strategies are as follows: 1. make the functions/variables static 2. include the header that contains the compatible declaration, or add one in the header if that's not the case. No functional change. Additional notes: - other cases, such as functions/variables used only in asm code will be possibly dealt with in future patches. - functions in 'gcov_base.c' are deviated, since they are called only from code generated by gcc in a particular non-release build configuration; - variables in 'xen/include/acpi/acglobal.h' are deviated temporarily, since it's uncertain whether modifying the include pattern to be compliant with the rule would introduce subtle bugs. Nicola Vetrini (8): arm/efi: address MISRA C:2012 Rule 8.4 xen/memory: address MISRA C:2012 Rule 8.4 xen: address MISRA C:2012 Rule 8.4 xen/arm: address MISRA C:2012 Rule 8.4 x86: address MISRA C:2012 Rule 8.4 xen/arm: mm: address MISRA C:2012 Rule 8.4 x86/i8259: address MISRA C:2012 Rule 8.4 x86/nmi: address MISRA C:2012 Rule 8.4 xen/arch/arm/efi/efi-boot.h | 2 +- xen/arch/arm/include/asm/mm.h | 3 +++ xen/arch/arm/setup.c | 1 + xen/arch/arm/time.c | 1 + xen/arch/x86/cpu/mcheck/mce.c | 2 +- xen/arch/x86/cpu/mcheck/mce_amd.c | 2 +- xen/arch/x86/cpu/microcode/core.c | 2 +- xen/arch/x86/i8259.c | 1 + xen/arch/x86/nmi.c | 3 ++- xen/arch/x86/spec_ctrl.c | 4 ++-- xen/common/kernel.c | 2 +- xen/common/memory.c | 2 +- xen/include/xen/cper.h | 3 +-- xen/include/xen/time.h | 1 + 14 files changed, 18 insertions(+), 11 deletions(-) --- 2.34.1