| Message ID | cover.1698829473.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix or deviate various instances of missing declarations | expand |
On 2023-11-01 10:15, Nicola Vetrini wrote: > The patches in this series aim to fix or deviate various instances > where a > function or variable do not have a declaration visible when such entity > is > defined (in violation of MISRA C:2012 Rule 8.4). > An exception listed under docs/misra/rules.rst allows asm-only > functions and > variables to be exempted, while the other instances are either changed > (e.g., making them static) or a missing header inclusion is added. > > Nicola Vetrini (8): > xen: modify or add declarations for variables where needed > x86: add deviation for asm-only functions > x86: add asmlinkage macro to variables only used in asm code > x86/grant: switch included header to make declarations visible > x86/vm_event: add missing include for hvm_vm_event_do_resume > xen/console: remove stub definition in consoled.h > x86/mem_access: make function static > docs/misra: exclude three more files > > automation/eclair_analysis/ECLAIR/deviations.ecl | 9 +++++++++ > docs/misra/deviations.rst | 6 ++++++ > docs/misra/exclude-list.json | 12 ++++++++++++ > xen/arch/arm/include/asm/setup.h | 3 +++ > xen/arch/arm/include/asm/smp.h | 3 +++ > xen/arch/arm/platform_hypercall.c | 2 +- > xen/arch/x86/cpu/mcheck/mce.c | 7 ++++--- > xen/arch/x86/hvm/grant_table.c | 3 +-- > xen/arch/x86/hvm/svm/intr.c | 2 +- > xen/arch/x86/hvm/svm/nestedsvm.c | 2 +- > xen/arch/x86/hvm/svm/svm.c | 4 ++-- > xen/arch/x86/hvm/vm_event.c | 1 + > xen/arch/x86/hvm/vmx/intr.c | 2 +- > xen/arch/x86/hvm/vmx/vmx.c | 4 ++-- > xen/arch/x86/hvm/vmx/vvmx.c | 2 +- > xen/arch/x86/include/asm/hvm/grant_table.h | 2 ++ > xen/arch/x86/irq.c | 2 +- > xen/arch/x86/mm/mem_access.c | 6 +++--- > xen/arch/x86/setup.c | 8 +++++--- > xen/arch/x86/traps.c | 2 +- > xen/arch/x86/x86_64/traps.c | 2 +- > xen/include/xen/compiler.h | 5 +++++ > xen/include/xen/consoled.h | 7 ------- > xen/include/xen/symbols.h | 1 + > 24 files changed, 67 insertions(+), 30 deletions(-) Please ignore this email; the patch series v6 has been sent fully in a different email
On 01.11.2023 10:30, Nicola Vetrini wrote: > The patches in this series aim to fix or deviate various instances where a > function or variable do not have a declaration visible when such entity is > defined (in violation of MISRA C:2012 Rule 8.4). > An exception listed under docs/misra/rules.rst allows asm-only functions and > variables to be exempted, while the other instances are either changed > (e.g., making them static) or a missing header inclusion is added. > > Nicola Vetrini (8): > xen: modify or add declarations for variables where needed > x86: add deviation for asm-only functions > x86: add asmlinkage macro to variables only used in asm code > x86/grant: switch included header to make declarations visible > x86/vm_event: add missing include for hvm_vm_event_do_resume > xen/console: remove stub definition in consoled.h > x86/mem_access: make function static > docs/misra: exclude three more files While I committed most of the patches from this series, the situation with patch 2 has become sufficiently unclear to me, such that I refrained from committing that and the dependent patch 3. Stefano, assuming you know what exact massaging it wants done while committing, please can I leave that to you? Or else there may want to be a re-submission. Thanks, Jan
On Tue, 21 Nov 2023, Jan Beulich wrote: > On 01.11.2023 10:30, Nicola Vetrini wrote: > > The patches in this series aim to fix or deviate various instances where a > > function or variable do not have a declaration visible when such entity is > > defined (in violation of MISRA C:2012 Rule 8.4). > > An exception listed under docs/misra/rules.rst allows asm-only functions and > > variables to be exempted, while the other instances are either changed > > (e.g., making them static) or a missing header inclusion is added. > > > > Nicola Vetrini (8): > > xen: modify or add declarations for variables where needed > > x86: add deviation for asm-only functions > > x86: add asmlinkage macro to variables only used in asm code > > x86/grant: switch included header to make declarations visible > > x86/vm_event: add missing include for hvm_vm_event_do_resume > > xen/console: remove stub definition in consoled.h > > x86/mem_access: make function static > > docs/misra: exclude three more files > > While I committed most of the patches from this series, the situation with > patch 2 has become sufficiently unclear to me, such that I refrained from > committing that and the dependent patch 3. > > Stefano, assuming you know what exact massaging it wants done while > committing, please can I leave that to you? Done