From patchwork Wed Mar 13 16:41:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vaishali Thakkar X-Patchwork-Id: 13591576 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 898E7C54791 for ; Wed, 13 Mar 2024 16:41:36 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.692627.1079948 (Exim 4.92) (envelope-from ) id 1rkRfP-0008E3-Gh; Wed, 13 Mar 2024 16:41:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 692627.1079948; Wed, 13 Mar 2024 16:41:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rkRfP-0008Dw-DU; Wed, 13 Mar 2024 16:41:23 +0000 Received: by outflank-mailman (input) for mailman id 692627; Wed, 13 Mar 2024 16:41:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rkRfO-0008Dq-LH for xen-devel@lists.xenproject.org; Wed, 13 Mar 2024 16:41:22 +0000 Received: from mail137-23.atl71.mandrillapp.com (mail137-23.atl71.mandrillapp.com [198.2.137.23]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8523251d-e158-11ee-afdd-a90da7624cb6; Wed, 13 Mar 2024 17:41:21 +0100 (CET) Received: from pmta07.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail137-23.atl71.mandrillapp.com (Mailchimp) with ESMTP id 4Tvx9B1V3Nz1XLJlY for ; Wed, 13 Mar 2024 16:41:18 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 955815554105470d8cc16439a67cb507; Wed, 13 Mar 2024 16:41:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8523251d-e158-11ee-afdd-a90da7624cb6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1710348078; x=1710608578; bh=0bduU8vi4qUwaEqWeiDsH+4vvViTADvEp8YdEFXN0zs=; h=From:Subject:To:Cc:Message-Id:Feedback-ID:Date:MIME-Version: Content-Type:Content-Transfer-Encoding:CC:Date:Subject:From; b=MluqUJDd7QgnBCO9/UmrxW33FMqUiNfTqLr7KDVXO9oFpVTXXMGWWwI8I3ZFQ6DjT L+8Sz80efk9pwxDIS2Kj733wTzhhuquHHTNzU5wmWAZ9L6EYnBCk8yU1Z2kpEHQCPI IaHc2x+OVOy9QbJIiop7rYTzeFv3evCEEy0ZBiS+aPX4qDSo+j5PXb2VKG8HRPAM7H OoXLPCfIhk+6O58QR3eMO4ZchhK5OOtDeQEwn5ofKd55ESwVjMDd5k60VYbMB4KLW7 imfHjqt60ntECTEme7eWEmpTxUHoX+tkvHb1T4NvC/v4hoMoKxgXEnPhE3Mo5nSn55 6uY7wO7Lv1MmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1710348078; x=1710608578; i=vaishali.thakkar@vates.tech; bh=0bduU8vi4qUwaEqWeiDsH+4vvViTADvEp8YdEFXN0zs=; h=From:Subject:To:Cc:Message-Id:Feedback-ID:Date:MIME-Version: Content-Type:Content-Transfer-Encoding:CC:Date:Subject:From; b=V1oXK6CpbTdLnLGjfdAAeMN8Tt0z9s1i+ooCxzex9e2b9de8YxAQ6BkhXwOvQ7j43 /AWsZgC6KBcZsA7kOKO/BURXuyuTL0GmzAzDb3XCKm4f8iGM1mQ8PnXn5zKFIcKMWd 4W+BenjUFtah49jJM1u/jkhSEuw2vPDvueqcyDO2BxI3hP5LUJkdnN/c090SxZbGkM 6KOK3TqY67wn1LBS4zYhdYXOuY7nat7FqiR28eLrTc4aRxAyW1/KiBvi1Wi34FRzjO dq068MK+2UT9n/mS56PAK37Hpy5/Hmrpgm/AHSGTZfBCwVZEyJcJNW0VlrePVqgViZ jocT5hEYy7wmA== From: Vaishali Thakkar Subject: =?utf-8?q?=5BPATCH_v3_0/3=5D_Misc_changes_for_few_VMCB_bits?= X-Mailer: git-send-email 2.44.0 X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1710348077128 To: xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, wl@xen.org, Vaishali Thakkar Message-Id: X-Native-Encoded: 1 X-Report-Abuse: =?utf-8?q?Please_forward_a_copy_of_this_message=2C_including?= =?utf-8?q?_all_headers=2C_to_abuse=40mandrill=2Ecom=2E_You_can_also_report_?= =?utf-8?q?abuse_here=3A_https=3A//mandrillapp=2Ecom/contact/abuse=3Fid=3D30?= =?utf-8?q?504962=2E955815554105470d8cc16439a67cb507?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20240313:md Date: Wed, 13 Mar 2024 16:41:18 +0000 MIME-Version: 1.0 Hi, In this patchset, first & second patch removes the unnecessary suffix from a bunch of vmcb bits. Third patch is about printing the status of sev and sev-es bits while dumping VMCB. Changes since v1: - Address comments from Andrew and Jan - Add extrapatch to drop the suffix _guest as per Andrew's suggestion in one of the reviews - Address Andrew's comment with respect to pretty printing Changes since v2: - Use VMCB accessors instead of open coding in patch 1 & 2 - Fix one remaining instance of using false/true instead of 0/1 in patch 2 - Improve the pretty printing in svm-debug based on Jan's comments - Improve commit logs and the subject of patch 3 to include the changes done in v3 Vaishali Thakkar (3): x86/svm: Drop the _enabled suffix from vmcb bits x86/svm: Drop the suffix _guest from vmcb bit x86/svmdebug: Print np, sev and sev_es vmcb bits xen/arch/x86/hvm/svm/asid.c | 6 ++--- xen/arch/x86/hvm/svm/nestedsvm.c | 22 ++++++++--------- xen/arch/x86/hvm/svm/svm.c | 2 +- xen/arch/x86/hvm/svm/svmdebug.c | 7 ++++-- xen/arch/x86/hvm/svm/vmcb.c | 2 +- xen/arch/x86/include/asm/hvm/svm/nestedsvm.h | 2 +- xen/arch/x86/include/asm/hvm/svm/vmcb.h | 26 ++++++++++---------- 7 files changed, 35 insertions(+), 32 deletions(-)