From patchwork Fri Aug 2 13:54:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksii Kurochko X-Patchwork-Id: 13751562 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79462C52D6F for ; Fri, 2 Aug 2024 13:54:32 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.771217.1181786 (Exim 4.92) (envelope-from ) id 1sZsjZ-000377-20; Fri, 02 Aug 2024 13:54:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 771217.1181786; Fri, 02 Aug 2024 13:54:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZsjY-000370-Ur; Fri, 02 Aug 2024 13:54:16 +0000 Received: by outflank-mailman (input) for mailman id 771217; Fri, 02 Aug 2024 13:54:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1sZsjX-00036j-RH for xen-devel@lists.xenproject.org; Fri, 02 Aug 2024 13:54:15 +0000 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [2a00:1450:4864:20::232]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b3c11e00-50d6-11ef-bc03-fd08da9f4363; Fri, 02 Aug 2024 15:54:14 +0200 (CEST) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2ef32fea28dso94709861fa.2 for ; Fri, 02 Aug 2024 06:54:14 -0700 (PDT) Received: from fedora.. ([94.75.70.14]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f15e1ae4easm1684271fa.43.2024.08.02.06.54.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Aug 2024 06:54:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3c11e00-50d6-11ef-bc03-fd08da9f4363 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722606853; x=1723211653; darn=lists.xenproject.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/Ntbnvw8MpC/M0odqqqPpDWj0+tD2Vlduqp8T9CgQOA=; b=E5lyX5kHMUcdbxDelMWcl++DCbytGLa9ywPRCatW6CbSp5A+OjI4dDBQPTtKtOAXXQ zmvbnyQF79H5/Ko+Q/jK5/Yq70QsKfm1TLedSZEeESvdn4vpWO+Y9wTdRqQXYt75vE6N 9a6zPhGoLLaIWBQWQ8kYMoGdY5NSbK8fzX1XeGOQP5aca85lobb0m8ALjlLx7yEq40D1 HEtnBEcfCh2f9G6KUU+qh0g1dXEua7dz3+Anf1USdw8TqYYrNuZstSnOcr8swrru5H0G 5+X/bq2fYXKlT+8nyGlrMH0uGSYf3KcDl7ryamq0pFWX5K92exO2ixhmVXBY0CtgeaEJ L2DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722606853; x=1723211653; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/Ntbnvw8MpC/M0odqqqPpDWj0+tD2Vlduqp8T9CgQOA=; b=LMrsYsV2+/fAUmLtPGYDamK67vF85mquiEq9o33jCjcIjF6l4i46iKrgEQGoCSIKAU Egz1q3CpeMCDmoi7Gur3uvOCAlC9lhlFqwE4AhoLGKs/uPRNTEnYl3G3bHgDiP54GPkq DmwNQmjc1N0rqSTwCGwmwquTCKnAFyMQ7LwVMWPApP6n7imiFLJe8ZIWm2oNda39xG+h v72jdpgeGjdOJvdqwf2Myj2sABptNMw7J7KauYYr8K96lYIwkzAuOnk0RzMKh9RKxFBf vBYtvM9oR7rLlAcKcTUWKCPUmydXZDm7A5HbBPwnYedCPOQAJqPaDV/MnG+xr60tebSQ REjw== X-Gm-Message-State: AOJu0YyZY9Yeh16um/+UM5q56r88HOtlIuXcbtegZs9zCjg6jT1MJ3Mv gWx5VKHHltMOz0qXd4BR679ft1QK2go7VGeWOuGphVi5TpUU37P8QEGdag== X-Google-Smtp-Source: AGHT+IFF5ifwd6IMltFqhWedTSaz2/kmX0vsaeu0500eV2yqUIH+pDEBjcAr9PB5fvbVYyBd8e3oaw== X-Received: by 2002:a2e:320c:0:b0:2ee:d5c3:388b with SMTP id 38308e7fff4ca-2f15ab06368mr24473641fa.39.1722606852728; Fri, 02 Aug 2024 06:54:12 -0700 (PDT) From: Oleksii Kurochko To: xen-devel@lists.xenproject.org Cc: Oleksii Kurochko , Alistair Francis , Bob Eshleman , Connor Davis , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini Subject: [PATCH v12 0/3] RISCV basic exception handling implementation Date: Fri, 2 Aug 2024 15:54:06 +0200 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 The patch series provides a basic implementation of exception handling. It can do only basic things such as decode a cause of an exception, save/restore registers and execute "wfi" instruction if an exception can not be handled. To verify that exception handling works well it was used macros from such as BUG/WARN/run_in_exception/assert_failed. It wasn't implemented show_execution_state() and stack trace discovering as it's not necessary now. --- Changes in V12: - Drop patch series depenency from "Enable build of full Xen for RISC-V" as this depenency has been merged to staging. - Change BUG_INSTR from 'ebreak' to 0x0000 ( UNIMP instruction ). - add new patch with refactoring of decode_trap_cause(). - The following patches were merged to staging: - [PATCH v11 1/5] xen/riscv: use printk() instead of early_printk() - [PATCH v11 2/5] xen/riscv: introduce decode_cause() stuff - [PATCH v11 3/5] xen/riscv: introduce trap_init() - All other changes please look in patch separately. --- Changes in V10 - V11: - No generic changes to describe here. Please look at patch-specific changes. --- Changes in V9: - Update the cover letter message. - s/early_printk/printk. - use GENERIC_BUG_FRAME instead of arch-specific implementation of do_bug_frame(). - Rebase on top of current staging and riscv-full-xen-build-v14. --- Changes in V8: - Update the commit message of the cover letter. - Remove the patch with an introduction of dummy asm/bug.h and introduce normal asm/bug.h - Fix typo in return string from decode_reserved_interrupt_cause - Add "Acked-by: Alistair Francis " for the patch "xen/riscv: introduce decode_cause() stuff" - Remove Pointless initializer of id in do_bug_frame(). - Make bug_frames[] array constant in do_bug_frame(). - Remove cast_to_bug_frame(addr). - Rename is_valig_bugaddr to is_valid_bug_insn(). - Add check that read_instr is used only on Xen code - Update the commit message. --- Changes in V7: - Update the depenency ( mentioned in the cover letter message ) of the current patch series. - clean up comments. - code style fixes. - move definition of cast_to_bug_frame() from patch 4 to 5. --- Changes in V6: - Update the cover letter message: the patch set is based on MMU patch series. - Introduce new patch with temporary printk functionality. ( it will be removed when Xen common code will be ready ) - Change early_printk() to printk(). - Remove usage of LINK_TO_LOAD() due to the MMU being enabled first. - Add additional explanatory comments. - Remove patch "xen/riscv: initialize boot_info structure" from the patch series. --- Changes in V5: - Rebase on top of [1] and [2] - Add new patch which introduces stub for to keep Xen compilable as in the patch [xen/riscv: introduce decode_cause() stuff] is used header which requires . - Remove from riscv/traps/c as nothing would require inclusion. - decode_reserved_interrupt_cause(), decode_interrupt_cause(), decode_cause, do_unexpected_trap() were made as static they are expected to be used only in traps.c - Remove "#include " from as there is no any need in it anymore - Update macros GET_INSN_LENGTH: remove UL and 'unsigned int len;' from it - Remove " include " from risc/setup.c. it is not needed in the current version of the patch - change an argument type from vaddr_t to uint32_t for is_valid_bugaddr and introduce read_instr() to read instruction properly as the length of qinstruction can be either 32 or 16 bits. - Code style fixes - update the comments before do_bug_frame() in riscv/trap.c - [[PATCH v4 5/5] automation: modify RISC-V smoke test ] was dropped as it was provided more simple solution by Andrew. CI: Simplify RISCV smoke testing - Refactor is_valid_bugaddr() function. - 2 new patches ([PATCH v5 {1-2}/7]) were introduced, the goal of which is to recalculate addresses used in traps.c, which can be linker time relative. It is needed as we don't have enabled MMU yet. --- Changes in V4: - Rebase the patch series on top of new version of [introduce generic implementation of macros from bug.h] patch series. - Update the cover letter message as 'Early printk' was merged and the current one patch series is based only on [introduce generic implementation of macros from bug.h] which hasn't been commited yet. - The following patches of the patch series were merged to staging: [PATCH v3 01/14] xen/riscv: change ISA to r64G [PATCH v3 02/14] xen/riscv: add header [PATCH v3 03/14] xen/riscv: add header [PATCH v3 05/14] xen/riscv: introduce empty [PATCH v3 06/14] xen/riscv: introduce empty [PATCH v3 07/14] xen/riscv: introduce exception context [PATCH v3 08/14] xen/riscv: introduce exception handlers implementation [PATCH v3 10/14] xen/riscv: mask all interrupts - Fix addressed comments in xen-devel mailing list. --- Changes in V3: - Change the name of config RISCV_ISA_RV64IMA to RISCV_ISA_RV64G as instructions from Zicsr and Zifencei extensions aren't part of I extension any more. - Rebase the patch "xen/riscv: introduce an implementation of macros from " on top of patch series [introduce generic implementation of macros from bug.h] - Update commit messages --- Changes in V2: - take the latest riscv_encoding.h from OpenSBI, update it with Xen related changes, and update the commit message with "Origin:" tag and the commit message itself. - add "Origin:" tag to the commit messag of the patch [xen/riscv: add header]. - Remove the patch [xen/riscv: add early_printk_hnum() function] as the functionality provided by the patch isn't used now. - Refactor prcoess.h: move structure offset defines to asm-offsets.c, change register_t to unsigned long. - Refactor entry.S to use offsets defined in asm-offsets.C - Rename {__,}handle_exception to handle_trap() and do_trap() to be more consistent with RISC-V spec. - Merge the pathc which introduces do_unexpected_trap() with the patch [xen/riscv: introduce exception handlers implementation]. - Rename setup_trap_handler() to trap_init() and update correspondingly the patches in the patch series. - Refactor bug.h, remove bug_instr_t type from it. - Refactor decode_trap_cause() function to be more optimization-friendly. - Add two new empty headers: and as they are needed to include which provides ARRAY_SIZE and other macros. - Code style fixes. --- Oleksii Kurochko (3): xen/riscv: enable GENERIC_BUG_FRAME xen/riscv: test basic exception handling stuff xen/riscv: refactor decode_trap_cause() xen/arch/riscv/Kconfig | 1 + xen/arch/riscv/include/asm/bug.h | 12 +++++------- xen/arch/riscv/setup.c | 20 +++++++++++++++++++ xen/arch/riscv/traps.c | 33 ++++++++++++++++++++++++++++---- xen/common/bug.c | 1 + 5 files changed, 56 insertions(+), 11 deletions(-)