mbox series

[v1,0/1] Fix rpath handling in OCaml's Makefile.rules

Message ID cover.1733757256.git.andrii.sultanov@cloud.com (mailing list archive)
Headers show
Series Fix rpath handling in OCaml's Makefile.rules | expand

Message

Andrii Sultanov Dec. 9, 2024, 3:16 p.m. UTC 
As reported by Nix's Xen team, OCaml stub libs would embed an absolute
rpath in the binaries, which was picked up on by patchelf. This is a
symptom of improper handling of -rpath-link in the first place, so
correct that and get rid of the issue.

Andrii Sultanov (1):
  tools/ocaml: Specify rpath correctly for ocamlmklib

 tools/ocaml/Makefile.rules | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Christian Lindig Dec. 9, 2024, 3:26 p.m. UTC | #1 
> On 9 Dec 2024, at 15:16, Andrii Sultanov <andrii.sultanov@cloud.com> wrote:
> 
> As reported by Nix's Xen team, OCaml stub libs would embed an absolute
> rpath in the binaries, which was picked up on by patchelf. This is a
> symptom of improper handling of -rpath-link in the first place, so
> correct that and get rid of the issue.
> 
> Andrii Sultanov (1):
>  tools/ocaml: Specify rpath correctly for ocamlmklib
> 
> tools/ocaml/Makefile.rules | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.39.5
> 

Acked-by: Christian Lindig <christian.lindig@cloud.com>
Andrii Sultanov Dec. 9, 2024, 3:38 p.m. UTC | #2 
DO NOT COMMIT - this patch is not correct, and I will send an updated
version later.

On Mon, Dec 9, 2024 at 3:16 PM Andrii Sultanov <andrii.sultanov@cloud.com>
wrote:

> As reported by Nix's Xen team, OCaml stub libs would embed an absolute
> rpath in the binaries, which was picked up on by patchelf. This is a
> symptom of improper handling of -rpath-link in the first place, so
> correct that and get rid of the issue.
>
> Andrii Sultanov (1):
>   tools/ocaml: Specify rpath correctly for ocamlmklib
>
>  tools/ocaml/Makefile.rules | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.39.5
>
>