mbox series

[0/5] automation: cleanup hardware based tests

Message ID cover.550599c54c91da4f8417fde358992e75bf8163c0.1696557834.git-series.marmarek@invisiblethingslab.com (mailing list archive)
Headers show
Series automation: cleanup hardware based tests | expand

Message

Marek Marczykowski-Górecki Oct. 6, 2023, 2:05 a.m. UTC
While working on tests for MSI-X, I did few cleanups of hw-based gitlab tests,
greatly reducing false positive messages in the test output.

After applying this series, the tests-artifacts/alpine/3.18 container needs to
be rebuilt.
Test run with container rebuilt (on my repo):
https://gitlab.com/xen-project/people/marmarek/xen/-/pipelines/1027467761

Cc-ing Henry for release ack.
---
Cc: Henry Wang <Henry.Wang@arm.com>
Cc:  Doug Goldstein <cardoe@cardoe.com>
Cc:  Stefano Stabellini <sstabellini@kernel.org>

Marek Marczykowski-Górecki (5):
  automation: include real-time view of the domU console log too
  automation: hide timeout countdown in log
  automation: cleanup test alpine install
  automation: improve checking for MSI/MSI-X in PCI passthrough tests
  automation: extract QEMU log in relevant hardware tests

 automation/gitlab-ci/test.yaml                    |  2 +-
 automation/scripts/qubes-x86-64.sh                | 29 ++++++----------
 automation/tests-artifacts/alpine/3.18.dockerfile |  7 +---
 3 files changed, 15 insertions(+), 23 deletions(-)

base-commit: 3d2d9e90224c4f430a7ee1190fd3b871b99b0ba0

Comments

Andrew Cooper Oct. 18, 2023, 5:46 p.m. UTC | #1
On 06/10/2023 3:05 am, Marek Marczykowski-Górecki wrote:
> While working on tests for MSI-X, I did few cleanups of hw-based gitlab tests,
> greatly reducing false positive messages in the test output.
>
> After applying this series, the tests-artifacts/alpine/3.18 container needs to
> be rebuilt.
> Test run with container rebuilt (on my repo):
> https://gitlab.com/xen-project/people/marmarek/xen/-/pipelines/1027467761
>
> Cc-ing Henry for release ack.
> ---
> Cc: Henry Wang <Henry.Wang@arm.com>
> Cc:  Doug Goldstein <cardoe@cardoe.com>
> Cc:  Stefano Stabellini <sstabellini@kernel.org>
>
> Marek Marczykowski-Górecki (5):
>   automation: include real-time view of the domU console log too
>   automation: hide timeout countdown in log
>   automation: cleanup test alpine install
>   automation: improve checking for MSI/MSI-X in PCI passthrough tests
>   automation: extract QEMU log in relevant hardware tests

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Henry - this will be a good improvement to take.  It's only the test
logic, with Gitlab being happy with the result.
Stefano Stabellini Oct. 18, 2023, 10:32 p.m. UTC | #2
On Wed, 18 Oct 2023, Andrew Cooper wrote:
> On 06/10/2023 3:05 am, Marek Marczykowski-Górecki wrote:
> > While working on tests for MSI-X, I did few cleanups of hw-based gitlab tests,
> > greatly reducing false positive messages in the test output.
> >
> > After applying this series, the tests-artifacts/alpine/3.18 container needs to
> > be rebuilt.
> > Test run with container rebuilt (on my repo):
> > https://gitlab.com/xen-project/people/marmarek/xen/-/pipelines/1027467761
> >
> > Cc-ing Henry for release ack.
> > ---
> > Cc: Henry Wang <Henry.Wang@arm.com>
> > Cc:  Doug Goldstein <cardoe@cardoe.com>
> > Cc:  Stefano Stabellini <sstabellini@kernel.org>
> >
> > Marek Marczykowski-Górecki (5):
> >   automation: include real-time view of the domU console log too
> >   automation: hide timeout countdown in log
> >   automation: cleanup test alpine install
> >   automation: improve checking for MSI/MSI-X in PCI passthrough tests
> >   automation: extract QEMU log in relevant hardware tests
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> Henry - this will be a good improvement to take.  It's only the test
> logic, with Gitlab being happy with the result.

I'll leave it to Henry.

Andrew, if/when you end up committing the series, please also update the
container,
Henry Wang Oct. 19, 2023, 12:31 a.m. UTC | #3
Hi,

> On Oct 19, 2023, at 06:32, Stefano Stabellini <sstabellini@kernel.org> wrote:
> 
> On Wed, 18 Oct 2023, Andrew Cooper wrote:
>> On 06/10/2023 3:05 am, Marek Marczykowski-Górecki wrote:
>>> While working on tests for MSI-X, I did few cleanups of hw-based gitlab tests,
>>> greatly reducing false positive messages in the test output.
>>> 
>>> After applying this series, the tests-artifacts/alpine/3.18 container needs to
>>> be rebuilt.
>>> Test run with container rebuilt (on my repo):
>>> https://gitlab.com/xen-project/people/marmarek/xen/-/pipelines/1027467761
>>> 
>>> Cc-ing Henry for release ack.
>>> ---
>>> Cc: Henry Wang <Henry.Wang@arm.com>
>>> Cc:  Doug Goldstein <cardoe@cardoe.com>
>>> Cc:  Stefano Stabellini <sstabellini@kernel.org>
>>> 
>>> Marek Marczykowski-Górecki (5):
>>>  automation: include real-time view of the domU console log too
>>>  automation: hide timeout countdown in log
>>>  automation: cleanup test alpine install
>>>  automation: improve checking for MSI/MSI-X in PCI passthrough tests
>>>  automation: extract QEMU log in relevant hardware tests
>> 
>> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> 
>> Henry - this will be a good improvement to take.  It's only the test
>> logic, with Gitlab being happy with the result.
> 
> I'll leave it to Henry.

I am happy to include this as in 4.17 we discussed that CI changes won’t be
blocked.

Release-acked-by: Henry Wang <Henry.Wang@arm.com>


> Andrew, if/when you end up committing the series, please also update the
> container,

Please any of you two do that :) Thank you.

Kind regards,
Henry