Livepatch: fix typos

Commit Message

Doebel, Bjoern March 11, 2022, 7:11 p.m. UTC

Fix a couple of typos in livepatch code.

Signed-off-by: Bjoern Doebel <[e-mail]>
CC: Konrad Rzeszutek Wilk <[e-mail]>
CC: Ross Lagerwall <[e-mail]>
---
 xen/arch/x86/livepatch.c |  2 +-
 xen/common/livepatch.c   | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

Comments

Luca Fancellu March 17, 2022, 4:39 p.m. UTC | #1

> On 11 Mar 2022, at 19:11, Bjoern Doebel <[e-mail]> wrote:
> 
> Fix a couple of typos in livepatch code.

NIT: I would say: [...] in livepatch code comments.

> 
> Signed-off-by: Bjoern Doebel <[e-mail]>

With or without it:

Reviewed-by: Luca Fancellu <[e-mail]>

Cheers,
Luca

> CC: Konrad Rzeszutek Wilk <[e-mail]>
> CC: Ross Lagerwall <[e-mail]>

Jan Beulich March 31, 2022, 8:50 a.m. UTC | #2

On 11.03.2022 20:11, Bjoern Doebel wrote:
> Fix a couple of typos in livepatch code.
> 
> Signed-off-by: Bjoern Doebel <[e-mail]>
> CC: Konrad Rzeszutek Wilk <[e-mail]>
> CC: Ross Lagerwall <[e-mail]>

Acked-by: Jan Beulich <[e-mail]>
and committed in spite of a lack of a maintainer ack.

Jan

Patch

diff --git a/xen/arch/x86/livepatch.c b/xen/arch/x86/livepatch.c
index 81c48fda7f..c4a19f3169 100644
--- a/xen/arch/x86/livepatch.c
+++ b/xen/arch/x86/livepatch.c
@@ -28,7 +28,7 @@  static bool has_active_waitqueue(const struct vm_event_domain *ved)
 }
 
 /*
- * x86's implementation of waitqueue violates the livepatching safey principle
+ * x86's implementation of waitqueue violates the livepatching safety principle
  * of having unwound every CPUs stack before modifying live content.
  *
  * Search through every domain and check that no vCPUs have an active
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index be2cf75c2d..edf56a357f 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -40,7 +40,7 @@  static LIST_HEAD(payload_list);
 
 /*
  * Patches which have been applied. Need RCU in case we crash (and then
- * traps code would iterate via applied_list) when adding entries onthe list.
+ * traps code would iterate via applied_list) when adding entries on the list.
  */
 static DEFINE_RCU_READ_LOCK(rcu_applied_lock);
 static LIST_HEAD(applied_list);
@@ -326,8 +326,8 @@  static int move_payload(struct payload *payload, struct livepatch_elf *elf)
 
     /*
      * Total of all three regions - RX, RW, and RO. We have to have
-     * keep them in seperate pages so we PAGE_ALIGN the RX and RW to have
-     * them on seperate pages. The last one will by default fall on its
+     * keep them in separate pages so we PAGE_ALIGN the RX and RW to have
+     * them on separate pages. The last one will by default fall on its
      * own page.
      */
     size = PAGE_ALIGN(payload->text_size) + PAGE_ALIGN(payload->rw_size) +
@@ -882,7 +882,7 @@  static bool_t is_payload_symbol(const struct livepatch_elf *elf,
         return 0;
 
     /*
-     * The payload is not a final image as we dynmically link against it.
+     * The payload is not a final image as we dynamically link against it.
      * As such the linker has left symbols we don't care about and which
      * binutils would have removed had it be a final image. Hence we:
      * - For SHF_ALLOC - ignore symbols referring to sections that are not
@@ -1523,7 +1523,7 @@  static bool_t is_work_scheduled(const struct payload *data)
 
 /*
  * Check if payload has any of the vetoing, non-atomic hooks assigned.
- * A vetoing, non-atmic hook may perform an operation that changes the
+ * A vetoing, non-atomic hook may perform an operation that changes the
  * hypervisor state and may not be guaranteed to succeed. Result of
  * such operation may be returned and may change the livepatch workflow.
  * Such hooks may require additional cleanup actions performed by other