| Message ID | 09fa701d2be02589cc9f63d8334082346b5c1702.1693319118.git.oleksii.kurochko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | introduce stub directory to storing empty/stub headers | expand |
On 29.08.2023 16:34, Oleksii Kurochko wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -438,6 +438,7 @@ ifdef building_out_of_srctree > endif > CFLAGS += -I$(srctree)/include > CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include > +CFLAGS += -I$(srctree)/include/stubs > > # Note that link order matters! > ALL_OBJS-y := common/built_in.o I have to admit that I'm not entirely happy with the name. I wonder what other REST maintainers think. In particular I would consider using Linux'es "asm-generic" name instead, allowing to cover both stub headers like the one to be introduced here, but also other kinds of "fallback" ones. Jan
Hi Jan, > On 30 Aug 2023, at 09:30, Jan Beulich <jbeulich@suse.com> wrote: > > On 29.08.2023 16:34, Oleksii Kurochko wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -438,6 +438,7 @@ ifdef building_out_of_srctree >> endif >> CFLAGS += -I$(srctree)/include >> CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include >> +CFLAGS += -I$(srctree)/include/stubs >> >> # Note that link order matters! >> ALL_OBJS-y := common/built_in.o > > I have to admit that I'm not entirely happy with the name. I wonder what > other REST maintainers think. In particular I would consider using > Linux'es "asm-generic" name instead, allowing to cover both stub headers > like the one to be introduced here, but also other kinds of "fallback" > ones. > This is a great idea. +1 on asm-generic Cheers Bertrand > Jan >
On Wed, 2023-08-30 at 09:30 +0200, Jan Beulich wrote: > On 29.08.2023 16:34, Oleksii Kurochko wrote: > > --- a/xen/Makefile > > +++ b/xen/Makefile > > @@ -438,6 +438,7 @@ ifdef building_out_of_srctree > > endif > > CFLAGS += -I$(srctree)/include > > CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include > > +CFLAGS += -I$(srctree)/include/stubs > > > > # Note that link order matters! > > ALL_OBJS-y := common/built_in.o > > I have to admit that I'm not entirely happy with the name. I wonder > what > other REST maintainers think. In particular I would consider using > Linux'es "asm-generic" name instead, allowing to cover both stub > headers > like the one to be introduced here, but also other kinds of > "fallback" > ones. It make sense. I'll update the patch series. ~ Oleksii
diff --git a/xen/Makefile b/xen/Makefile index f57e5a596c..64c3542c84 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -438,6 +438,7 @@ ifdef building_out_of_srctree endif CFLAGS += -I$(srctree)/include CFLAGS += -I$(srctree)/arch/$(SRCARCH)/include +CFLAGS += -I$(srctree)/include/stubs # Note that link order matters! ALL_OBJS-y := common/built_in.o
stubs dir will contain empty/stubs generic for all architectures headers. Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> --- Changes in V2: - Nothing changed. --- xen/Makefile | 1 + 1 file changed, 1 insertion(+)