diff mbox

[OSSTEST,5/9] ms-planner: Improve an error message

Message ID 1450371968-27997-5-git-send-email-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson Dec. 17, 2015, 5:06 p.m. UTC 
I experienced this `die' due to mg-schema-test-database failing to
borrow shared hosts properly, and added this Dumper for debugging.

I have not bothered to improve any of the other quite terse `die's in
ms-planner.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
---
 ms-planner |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Ian Campbell Dec. 17, 2015, 5:26 p.m. UTC | #1 
On Thu, 2015-12-17 at 17:06 +0000, Ian Jackson wrote:
> I experienced this `die' due to mg-schema-test-database failing to
> borrow shared hosts properly, and added this Dumper for debugging.
> 
> I have not bothered to improve any of the other quite terse `die's in
> ms-planner.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>
diff mbox

Patch

diff --git a/ms-planner b/ms-planner
index fc65a5b..8c2e06f 100755
--- a/ms-planner
+++ b/ms-planner
@@ -319,7 +319,9 @@  END
 	my ($reso, $shareix) = ($`, $1);
 
 	my $share= $currentshare{$reso};
-	die unless !!$share == !!$shareix;
+	die Dumper($reskey, $reso, $shareix,
+		   $plan->{Allocations}{$reskey}, $currentshare{$reso})
+	    unless !!$share == !!$shareix;
 
         if ($share && $share->{OnlyPreparing}) {
             delete $plan->{Allocations}{$reskey};