From patchwork Fri Jan 15 12:23:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 8040011 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F15E29F859 for ; Fri, 15 Jan 2016 12:26:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 235A22044C for ; Fri, 15 Jan 2016 12:26:56 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 485C02044B for ; Fri, 15 Jan 2016 12:26:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aK3QE-0000uk-Hw; Fri, 15 Jan 2016 12:24:06 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aK3QC-0000uf-Hy for xen-devel@lists.xen.org; Fri, 15 Jan 2016 12:24:04 +0000 Received: from [85.158.143.35] by server-3.bemta-4.messagelabs.com id 37/E4-31122-3E4E8965; Fri, 15 Jan 2016 12:24:03 +0000 X-Env-Sender: prvs=815b692d9=Ian.Campbell@citrix.com X-Msg-Ref: server-4.tower-21.messagelabs.com!1452860641!10264970!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 56552 invoked from network); 15 Jan 2016 12:24:03 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-4.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 15 Jan 2016 12:24:03 -0000 X-IronPort-AV: E=Sophos;i="5.22,299,1449532800"; d="scan'208";a="325386321" From: Ian Campbell To: , Date: Fri, 15 Jan 2016 12:23:58 +0000 Message-ID: <1452860638-1845-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.6.1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Ian Campbell Subject: [Xen-devel] [PATCH OSSTEST] Allow longer timeout when creating backing file for a raw disk. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I noticed this dd timiung out when recommissioning the 3 cubietrucks (picasso, metzinger, gleizes) but looking at the log shows this has been happening on braque too. The current code assumes 65MB/s arriving at a timeout of 153s for the 10G file. On arndale-* the logs indicate that it is achieving 95MB/s and taking 105-107s which results in a warning but not a failure: execution took 105 seconds [**>153.846153846154/2**] In experiments on a local cubietruck I observed it achieving a much lower throughput of 40MB/s, which seems to be consistent with what others are seeing: https://groups.google.com/forum/#!category-topic/cubieboard/troubleshooting/7R4HlCDNCTU Therefore calculate the timeout assuming a throughput of 20MB/s, in practice for a 10GB file this will result in a 500s timeout. Signed-off-by: Ian Campbell Acked-by: Ian Jackson --- Osstest/TestSupport.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 28ac572..962d773 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -1747,9 +1747,9 @@ sub make_qcow2 ($$$) { } sub make_raw ($$$) { my ($ho, $gho, $disk_mb) = @_; - # In local tests this reported 130MB/s, so calculate a timeout assuming 65MB/s. + # In local tests this reported 40MB/s, so calculate a timeout assuming 20MB/s. target_cmd_root($ho, "dd if=/dev/zero of=$gho->{Rootimg} bs=1MB count=${disk_mb}", - ${disk_mb} / 65); + ${disk_mb} / 20); } sub prepareguest_part_diskimg ($$$) {