diff mbox

[v6,1/5] build: Env var to enable expert config options

Message ID 1452877299-59267-2-git-send-email-jonathan.creekmore@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jonathan Creekmore Jan. 15, 2016, 5:01 p.m. UTC 
Add an additional environment variable, defaulting to disabled,
that enables the CONFIG_EXPERT configuration option. The purpose
of the CONFIG_EXPERT configuration option is to make non-standard
Kconfig options visible during the configuration process. The
CONFIG_EXPERT option is not, itself, visible during the Kconfig
configuration process, so typical users will never see it nor
any of the non-standard configuration options.

CC: Ian Campbell <ian.campbell@citrix.com>
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Keir Fraser <keir@xen.org>
CC: Tim Deegan <tim@xen.org>
Signed-off-by: Jonathan Creekmore <jonathan.creekmore@gmail.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 xen/Kconfig  | 4 ++++
 xen/Makefile | 1 +
 2 files changed, 5 insertions(+)

Comments

Jan Beulich Jan. 15, 2016, 5:20 p.m. UTC | #1 
>>> On 15.01.16 at 18:01, <jonathan.creekmore@gmail.com> wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -11,6 +11,7 @@ export XEN_DOMAIN	?= $(shell ([ -x /bin/dnsdomainname ] && /bin/dnsdomainname) |
>  export XEN_BUILD_DATE	?= $(shell LC_ALL=C date)
>  export XEN_BUILD_TIME	?= $(shell LC_ALL=C date +%T)
>  export XEN_BUILD_HOST	?= $(shell hostname)
> +export XEN_CONFIG_EXPERT ?= n

This, I'm afraid, invalidates what I've said in another reply on
the earlier thread a few minutes ago. What Makefile.kconfig
gets to see must be consistent for FORCE to not be added to
include/config/auto.conf's dependencies by auto.conf.cmd.

Or in other words - did you check (in conjunction with that other
patch fixing incremental rebuilds) whether incremental rebuilds
aren't again becoming full rebuilds because of this when there's
no XEN_CONFIG_EXPERT in the environment?

Jan
Jonathan Creekmore Jan. 15, 2016, 5:33 p.m. UTC | #2 
> On Jan 15, 2016, at 11:20 AM, Jan Beulich <JBeulich@suse.com> wrote:
> 
>>>> On 15.01.16 at 18:01, <jonathan.creekmore@gmail.com> wrote:
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -11,6 +11,7 @@ export XEN_DOMAIN	?= $(shell ([ -x /bin/dnsdomainname ] && /bin/dnsdomainname) |
>> export XEN_BUILD_DATE	?= $(shell LC_ALL=C date)
>> export XEN_BUILD_TIME	?= $(shell LC_ALL=C date +%T)
>> export XEN_BUILD_HOST	?= $(shell hostname)
>> +export XEN_CONFIG_EXPERT ?= n
> 
> This, I'm afraid, invalidates what I've said in another reply on
> the earlier thread a few minutes ago. What Makefile.kconfig
> gets to see must be consistent for FORCE to not be added to
> include/config/auto.conf's dependencies by auto.conf.cmd.
> 
> Or in other words - did you check (in conjunction with that other
> patch fixing incremental rebuilds) whether incremental rebuilds
> aren't again becoming full rebuilds because of this when there's
> no XEN_CONFIG_EXPERT in the environment?

I have applied your patch on top of my branch and I do not see incremental 
rebuilds becoming full rebuilds whether XEN_CONFIG_EXPERT is not in the
environment.
Jan Beulich Jan. 18, 2016, 7:46 a.m. UTC | #3 
>>> On 15.01.16 at 18:33, <jonathan.creekmore@gmail.com> wrote:

>> On Jan 15, 2016, at 11:20 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> 
>>>>> On 15.01.16 at 18:01, <jonathan.creekmore@gmail.com> wrote:
>>> --- a/xen/Makefile
>>> +++ b/xen/Makefile
>>> @@ -11,6 +11,7 @@ export XEN_DOMAIN	?= $(shell ([ -x /bin/dnsdomainname ] && 
> /bin/dnsdomainname) |
>>> export XEN_BUILD_DATE	?= $(shell LC_ALL=C date)
>>> export XEN_BUILD_TIME	?= $(shell LC_ALL=C date +%T)
>>> export XEN_BUILD_HOST	?= $(shell hostname)
>>> +export XEN_CONFIG_EXPERT ?= n
>> 
>> This, I'm afraid, invalidates what I've said in another reply on
>> the earlier thread a few minutes ago. What Makefile.kconfig
>> gets to see must be consistent for FORCE to not be added to
>> include/config/auto.conf's dependencies by auto.conf.cmd.
>> 
>> Or in other words - did you check (in conjunction with that other
>> patch fixing incremental rebuilds) whether incremental rebuilds
>> aren't again becoming full rebuilds because of this when there's
>> no XEN_CONFIG_EXPERT in the environment?
> 
> I have applied your patch on top of my branch and I do not see incremental 
> rebuilds becoming full rebuilds whether XEN_CONFIG_EXPERT is not in the
> environment.

Thanks; indeed I've meanwhile realized that the "export" here
should be taking care of avoiding that situation

Jan
diff mbox

Patch

diff --git a/xen/Kconfig b/xen/Kconfig
index ffe3f45..fa8b27c 100644
--- a/xen/Kconfig
+++ b/xen/Kconfig
@@ -22,3 +22,7 @@  config DEFCONFIG_LIST
 	string
 	option defconfig_list
 	default "$ARCH_DEFCONFIG"
+
+config EXPERT
+	string
+	option env="XEN_CONFIG_EXPERT"
diff --git a/xen/Makefile b/xen/Makefile
index 3699b20..e03e79b 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -11,6 +11,7 @@  export XEN_DOMAIN	?= $(shell ([ -x /bin/dnsdomainname ] && /bin/dnsdomainname) |
 export XEN_BUILD_DATE	?= $(shell LC_ALL=C date)
 export XEN_BUILD_TIME	?= $(shell LC_ALL=C date +%T)
 export XEN_BUILD_HOST	?= $(shell hostname)
+export XEN_CONFIG_EXPERT ?= n
 
 export BASEDIR := $(CURDIR)
 export XEN_ROOT := $(BASEDIR)/..