[OSSTEST,v1,1/5] mg-show-flight-runvars: collect rows into @rows, output in second step

Commit Message

Ian Campbell Feb. 1, 2016, 2:28 p.m. UTC

This will make it easier to collect more rows.

Signed-off-by: Ian Campbell <[e-mail]>
---
 mg-show-flight-runvars | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Ian Jackson Feb. 1, 2016, 2:42 p.m. UTC | #1

Ian Campbell writes ("[PATCH OSSTEST v1 1/5] mg-show-flight-runvars: collect rows into @rows, output in second step"):
> This will make it easier to collect more rows.

Acked-by: Ian Jackson <[e-mail]>

Patch

diff --git a/mg-show-flight-runvars b/mg-show-flight-runvars
index c800110..820c577 100755
--- a/mg-show-flight-runvars
+++ b/mg-show-flight-runvars
@@ -46,6 +46,7 @@  die unless @ARGV==1 && $ARGV[0] =~ m/^\w+$/;
 our ($flight) = @ARGV;
 
 our @cols = qw(job name val);
+our @rows;
 
 $flight =~ m/^\d+/ or $flight = "'$flight'";
 my $qfrom = "FROM runvars WHERE flight=$flight AND $synthcond";
@@ -62,6 +63,10 @@  $colws[1] += length $synthsufx;
 while (my (@row) = $q->fetchrow_array()) {
     my $synth = shift @row;
     $row[1] .= $synthsufx if $synth && $synth ne 'f'; # sqlite3 is typeless
-    printf "%-*s %-*s %-*s\n", map { $colws[$_], $row[$_] } qw(0 1 2)
+    push @rows, \@row;
+}
+
+foreach my $row (@rows) {
+    printf "%-*s %-*s %-*s\n", map { $colws[$_], $row->[$_] } qw(0 1 2)
         or die $!;
 }